Repository navigation
Decouple shared assembly from component implementations - #105
Merged
Merged
Conversation
stevenaya
force-pushed
the
refactor/shared-kinematic-components
branch
from
October 29, 2026 09:20
545f981 to
8ee11c4
Compare
stevenaya
changed the title
stevenaya
force-pushed
the
refactor/shared-kinematic-components
branch
from
October 29, 2026 15:52
8ee11c4 to
14e4e46
Compare
stevenaya
changed the title
stevenaya
marked this pull request as ready for review
October 29, 2026 16:07
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
stevenaya
force-pushed
the
refactor/shared-kinematic-components
branch
from
October 30, 2026 14:48
14e4e46 to
658348c
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
stevenaya
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract preset validation and recursive assembly into shared macros. The V2 entry loads the component implementation and supplies its describe/emit operations to the assembler. Product-specific checks run with component loading.
Validation: the 13 existing tests pass on Jazzy, and 13 robot/gripper configurations produce equivalent URDFs. Test files and CMake are unchanged.