Repository navigation
Prepare for releasing through the ROS buildfarm - #173
Merged
Merged
Conversation
We want to release openarm_can with bloom so that ROS 2 packages that depend on it can be installed from the ROS apt repository. See enactic/openarm_ros2#101. ## `package.xml` - Use `opensource@enactic.ai` as the maintainer address. It's the address of our release key. - Depend on `cmake` instead of `ament_cmake` because we use plain CMake. - Add the missing CLI11 build dependency (`cli11`). The buildfarm builds in a clean environment, so the build fails without it. ## `CMakeLists.txt` - Build a shared library by default. bloom doesn't specify `BUILD_SHARED_LIBS`, so we built a static library for ROS. Other plain CMake packages in ROS, such as ruckig, do the same. - `packages/debian/rules` doesn't need `-DBUILD_SHARED_LIBS=ON` anymore. - The Python bindings still build their bundled copy statically. ## CI - Add a ROS job. It installs dependencies with rosdep based only on `package.xml` and builds a `.deb` with bloom, as the buildfarm does. It uploads the built `.deb` packages as artifacts. - Set `LD_LIBRARY_PATH` in the Python test. The Python bindings now link to the shared library, which is installed in a non-standard location. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to release openarm_can with bloom so that ROS 2 packages that depend on it can be installed from the ROS apt repository. See enactic/openarm_ros2#101.
package.xmlopensource@enactic.aias the maintainer address. It's the address of our release key.cmakeinstead ofament_cmakebecause we use plain CMake.cli11). The buildfarm builds in a clean environment, so the build fails without it.CMakeLists.txtBUILD_SHARED_LIBS, so we built a static library for ROS. Other plain CMake packages in ROS, such as ruckig, do the same.packages/debian/rulesdoesn't need-DBUILD_SHARED_LIBS=ONanymore.CI
package.xmland builds a.debwith bloom, as the buildfarm does. It uploads the built.debpackages as artifacts.LD_LIBRARY_PATHin the Python test. The Python bindings now link to the shared library, which is installed in a non-standard location.