Repository navigation
Fix Studio authoring layouts, Test Runs and stale diagnostics - #3504
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
[Codex] On behalf of @sfmskywalker. Continue the same branch and push each scoped fix, as requested in this chat. The branch was resumed for this new repair after #3487 merged; this PR contains only the new Properties scrolling change. Local evidence for
Hosted checks are pending. The PR remains a draft; no merge or hosted-check completion is claimed. |
|
Activity availability height repair is pushed as Evidence for the integrated head:
Non-pass outcomes remain distinct:
The worktree is clean, the existing branch is pushed, and the PR remains a draft. Other hosted jobs are still pending; no merge or complete-hosted-suite claim is made. |
|
Activity Definition interface cleanup is pushed at Presentation changes: flat member groups and plain counts; focused detail form with bounded width and quieter secondary actions; two related designer-connection sections grouped together; shared Studio buttons; aligned selectors; Advanced details and optional suggestions remain available below the routine flow. The same forms collapse to one column on narrow screens. Exact-head local validation:
No authoring state, identifiers, binding payloads, permission/read-only gates, persistence or publication contracts changed. No tests were weakened, skipped or quarantined. The worktree is clean and the same branch is pushed. The PR remains a draft with latest-head hosted checks pending. |
|
Test Run fixes pushed on the existing branch at Confirmed defects: Test Run options/draft/version compilation dropped the current tenant, unlike normal publication; TestRun source references also lacked it. Compilation-rejected views then started observation and controls, which could replace the useful rejection with a scoped-runtime 404. Compilation and source references now retain the current tenant, and compilation rejections never begin execution observation or controls. Existing cross-tenant, publication and ambiguity guards are unchanged. Local validation:
Live read-only evidence: Dispatchee exists at published 3.0.0 with one live Published reference to artifact-23315e9d9d91. This validates the user's observation. Tenant propagation is a confirmed source bug consistent with that rejection; its role in the exact live failure is not yet confirmed by a rebuilt-host run. No live workflow execution, publication or host restart was performed. Hosted checks are pending; PR stays draft. |
|
Workflow-definition table density fix pushed at Modified now uses a content-sized column and a non-wrapping timestamp, so it takes the width it needs from the flexible Name column. Rows use 44px minimum height with 6px vertical padding, including the workspace appearance that previously forced 64px rows. Other table density styles are unchanged. Validation:
No data, API, permission, selection or action behavior changes. Hosted checks for this new head are pending; PR remains draft. |
|
Stale validation fix pushed on the existing branch at Workflow draft validation now waits for the matching draft snapshot to be saved before reading the server's stored-state validations. The save/load acknowledgement includes draft and definition identity plus the authored signature. Unsaved edits cancel the prior validation read; successful autosave or manual saving starts a fresh read even though saving does not change the authored signature. The reproduced race was a validation read at 600ms beating autosave at 1200ms, leaving a deleted Run Etl's required Pipeline error in the server-validation list after saving completed. The same race persists with a slow save, so increasing the debounce alone would not solve it. The fix retains the existing save queue, publication checks, server validators and optional-capability fallback. Local validation:
No backend/API, permission, validation rule, publication guard, or dependency changes. No live user workflow was edited or executed. Hosted checks on the new head remain pending; the PR stays draft. |
|
Self-review round 1 Reviewed head: Three independent, isolated reviewers inspected the complete 31-file PR diff and surrounding code, plus the PR discussion and review threads:
Surviving findings: none. Findings fixed/dropped in this round: none. No human holds or inline review threads were present. Review converged in one round. The current-head frontend, browser, backend and architecture qualification is running after main integration. Earlier green evidence belongs to its named earlier heads and is not substituted for this integrated-head run. Earlier scoped negative controls remain documented in the PR receipts. Marking ready to start the required full tier. Delivery will use the Codex/Claude standing self-merge authorization (org AGENTS.md, 18 Oct 2026) only after exact-head required checks and all applicable gates pass, with the prescribed audit comment and label before merge. No merge is claimed yet. |
|
This PR does not match any of the 1 configured review trigger rule. |
|
Integrated-head local qualification Head:
Independent review round 1 converged with no actionable findings on this exact head. Earlier negative controls remain valid for the unchanged owned behavior and are recorded in previous receipts. Hosted CI, Studio CI and ready-PR full tier are still pending; no merge is claimed. Superseded draft full-tier planning was cancelled by readiness and does not count as a pass. Existing quarantine entries are unchanged and will be reported separately from passed tests. |
|
Final local shuffled qualification for reviewed head
All three runs passed without retries. Local qualification is complete. Hosted required gates remain pending; this does not authorize merging before their exact-head results pass. |
|
Self-review round 2 Reviewed head: CI finding fixed: the graph-authoring browser journey still asserted the old Completion paths help paragraph after the approved UI copy rewrite. Hosted Studio browser qualification on Fix: Validation: the updated graph-authoring, activity-authoring and interface-layout group passed 27 browser checks. Browser fixture TypeScript and targeted ESLint passed. All other production files are byte-identical to the prior locally qualified head (4,018 workspace tests, 172 browser checks, three 2,781-test shuffles, 906 Publishing API, 380 Dispatch Workflow, 592 architecture). Three isolated reviewers re-reviewed the current full diff and the incremental change for correctness, standards, and acceptance/test quality. No actionable findings remain; round 2 converged. Prior-head hosted CI and Full tier passed, but they are superseded for exact-head gating by this test-only commit and are not counted as the new head's checks. Full-tier artifacts showed no retry-only passes or unquarantined failures; existing quarantine #3261 failed and was excluded under the unchanged quarantine policy. It is not reported as a passed test. Marking ready for fresh exact-head CI/Studio/Full tier. Merge remains gated on those results. |
|
Self-review round 3 Reviewed head: Main advanced with #3510, a compensation-browser focus test correction. It merged cleanly. Independent comparison confirms the complete PR-owned diff against the new base is byte-identical to the previously reviewed diff against its old base; only the separate base browser test changed in the integration. Three isolated reviewers independently verified correctness, repository standards and acceptance/test quality on the new head/base. No actionable findings or new acceptance gaps; round 3 converged. Findings fixed/dropped in this round: none. No production changes were introduced by this integration. Current-head workspace unit, affected browser (including graph authoring and compensation), lint/typecheck/build, Publishing API, Dispatch Workflow, architecture and maps qualification is running. Marking ready to start fresh exact-head hosted qualification. Earlier check results are retained as historical evidence and are not used as this head's merge gates. |
|
Current-head local qualification Head:
Three independent review lenses converged with no actionable findings in round 3. Earlier negative controls are retained as named historical receipts. Current-head CI/Studio/full-tier hosted gates remain pending; no merge is claimed and no superseded check is substituted for this head. |
|
Self-merge (standing authorization, Oct 18 2026) Rounds run: 3 (round 1, round 2, round 3). Each used independent correctness, standards and acceptance/test-quality reviewers. Final round converged with no actionable findings. Current base Exact-head hosted gates:
Test outcome artifacts: PR tier has no retry-only passes, failed-twice entries, quarantined failures or aborted tests. Full tier has no retry-only passes, unquarantined failures or aborts; existing quarantine #3261 failed/excluded under the unchanged policy and is not counted as passed. Local current-head evidence (4,018 unit / 253 browser / 906 Publishing / 380 Dispatch / 592 architecture) and negative controls are recorded in earlier receipts. The non-required license/cla check remains queued; CodeRabbit is skipped. Standing authorization explicitly permits the pending non-required CLA check. No protection bypass will be used. Org instructions were re-fetched and confirmed unchanged before this audit. |
|
Merged as Verified resulting main and reviewed head have identical tree Post-merge gates on this exact SHA are running: Merge is complete; resulting-main qualification remains pending. No pending, skipped or quarantined outcome is reported as a pass. |
|
Post-merge qualification update: Ancestry verification confirms our merge is included. GitHub cancelled the original merge's CI, Studio and CodeQL runs as superseded; those cancellations are not reported as passes. The original Packages run succeeded. Qualifying the descendant instead: Resulting-main qualification remains pending; the PR is merged, not reopened or changed. |
Final postmerge qualification — completePR merged as Qualified descendant main: All four workflows completed successfully on that exact descendant:
Audited all nine main shard outcome artifacts and verified their head SHA. No failed-twice, retry-only or aborted outcomes. The existing compensation sample quarantine #3261 remains failed/excluded, not passed; no quarantine policy was changed. Main skips EF container shards by workflow policy; all corresponding exact-head premerge Full tier shards passed. Earlier postmerge CI/Studio/CodeQL runs canceled by the later main push were superseded and were not counted as passes. No deployment or live workflow execution claim is made; the exact captured Dispatch Workflow failure still awaits a rebuilt-backend live rerun. Source fixes and regression qualification are complete. Separate intermittent assertions #3505/#3506 are not claimed fixed. |
|
After this qualification completed, separate Weaver PR #3497 advanced main to |
Studio authoring surfaces clipped content, wasted space and retained validation results for older draft state. This PR fixes the layouts, simplifies Activity Definition editing, and corrects workflow Test Run and validation state handling.
Current reviewed head:
c54ea9539ee39b991960b2f73a7104b660787b31, againsta01980064aed293502b9ada57a682286d950c7fd. Current main's separate compensation-browser focus fix is integrated. Three independent lenses converged in three review rounds. The graph-authoring journey's obsolete help-copy assertion now checks its semantic Completion paths heading; all subsequent mapping, JSON, Test Run and legacy-schema assertions remain.Current-head local qualification:
Existing intermittent assertions remain tracked in #3505/#3506; no fix for them is claimed. Current-head full-tier qualification reported existing quarantine #3261 as failed/excluded, not passed; the quarantine policy is unchanged.
Read-only live inspection confirmed Dispatchee published 3.0.0 with one live Published reference. The tenant omission is a confirmed source defect consistent with its rejection; the exact live failure has not been rerun with a rebuilt backend. User workflows were not executed or republished.
No projects, dependencies, public APIs, persistence contracts or validation rules changed. Each fix was pushed on the same branch. Merged as
a2cf47488fc7db8ba60c93c8b03fe4d78f6530d9under standing authorization, with the prescribed audit comment and self-merged label. The merge tree exactly matches the reviewed tree. End-to-end qualification is complete on descendant maind4dcd947c50b0e5e305b708401d3844b3683da38: all 32 PR-owned files still match the reviewed head, and CI, Studio CI, Packages and CodeQL completed successfully. Hosted browser: 737 passed, 6 opt-in screenshot cases skipped. Package build passed; release and feed publication were skipped on this descendant. Main skips EF container shards by policy; the exact-head premerge Full tier EF shards passed. Existing quarantine #3261 remains failed/excluded, with no other failed-twice, retry-only or aborted outcomes in the nine audited main shard artifacts. Earlier postmerge CI/Studio/CodeQL runs canceled by the descendant push are superseded evidence, not passes.After this qualification completed, separate Weaver PR #3497 advanced main to
ab46bc22a52aa6e456bca6ac0e803c80904de081. Its CI is running and is not counted as passed here. Ancestry and all 32 PR-owned files were rechecked on that newer main; they still match the reviewed head. The completed postmerge gate evidence above applies specifically tod4dcd947c50b0e5e305b708401d3844b3683da38.