Skip to content

Fix Studio authoring layouts, Test Runs and stale diagnostics - #3504

Merged
elsa-workflows-codex[bot] merged 17 commits into
mainfrom
codex/inspector-run-data-spacing
Oct 31, 2026
Merged

elsa-workflows-codex[bot] merged 17 commits into
mainfrom
codex/inspector-run-data-spacing

Conversation

@elsa-workflows-codex

@elsa-workflows-codex elsa-workflows-codex Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Studio authoring surfaces clipped content, wasted space and retained validation results for older draft state. This PR fixes the layouts, simplifies Activity Definition editing, and corrects workflow Test Run and validation state handling.

  • Workflow Properties scrolls above an expanded bottom panel. Activity availability fills the remaining workspace and keeps its list/details scrollable.
  • Activity Definition Inputs & outputs uses a flat member navigator, a focused form, quieter secondary controls and grouped designer connections. Narrow layouts, keyboard actions, read-only behavior, autosave and saved mappings are retained.
  • Workflow definitions sizes Modified to a single-line timestamp and uses compact 44px rows in standard and workspace styles.
  • Workflow Test Run options, draft compilation and version compilation pass the current tenant into the compiler; generated TestRun source references retain it. Same-tenant, publication and ambiguity checks remain intact.
  • Compilation-rejected Test Runs retain their original reason and do not poll for an execution or mount reconnect/waiting-trigger controls.
  • Draft validation reads wait for a saved snapshot matching the current draft identity and authored signature. This prevents a 600ms validation read from retaining a deleted Run Etl's error after the 1200ms autosave. Slow and manual saving are covered.

Current reviewed head: c54ea9539ee39b991960b2f73a7104b660787b31, against a01980064aed293502b9ada57a682286d950c7fd. Current main's separate compensation-browser focus fix is integrated. Three independent lenses converged in three review rounds. The graph-authoring journey's obsolete help-copy assertion now checks its semantic Completion paths heading; all subsequent mapping, JSON, Test Run and legacy-schema assertions remain.

Current-head local qualification:

  • 4,018 frontend unit tests passed across the complete Studio workspace.
  • 253 affected browser checks passed, including graph authoring, compensation, layouts, editing, navigation, validation, rejection and Linen workspace styles. An earlier local attempt lost a reused fixture server; the unchanged-code rerun used an owned server/port. That infrastructure failure and the successful rerun are recorded separately in the PR receipts.
  • Complete Publishing API, Dispatch Workflow and architecture suites: 906, 380, and 592 passed, respectively; zero failed/skipped.
  • Full Studio lint/typecheck, maps and workflow production build/budgets passed. Lint: zero errors and 54 existing warnings.
  • Behavioral negative controls and three passing 2,781-test shuffled runs on the earlier byte-identical production source are recorded in the PR receipts. Exact-head CI, Full tier and Studio CI passed. Hosted browser: 737 passed, 6 skipped (existing opt-in screenshot cases).

Existing intermittent assertions remain tracked in #3505/#3506; no fix for them is claimed. Current-head full-tier qualification reported existing quarantine #3261 as failed/excluded, not passed; the quarantine policy is unchanged.

Read-only live inspection confirmed Dispatchee published 3.0.0 with one live Published reference. The tenant omission is a confirmed source defect consistent with its rejection; the exact live failure has not been rerun with a rebuilt backend. User workflows were not executed or republished.

No projects, dependencies, public APIs, persistence contracts or validation rules changed. Each fix was pushed on the same branch. Merged as a2cf47488fc7db8ba60c93c8b03fe4d78f6530d9 under standing authorization, with the prescribed audit comment and self-merged label. The merge tree exactly matches the reviewed tree. End-to-end qualification is complete on descendant main d4dcd947c50b0e5e305b708401d3844b3683da38: all 32 PR-owned files still match the reviewed head, and CI, Studio CI, Packages and CodeQL completed successfully. Hosted browser: 737 passed, 6 opt-in screenshot cases skipped. Package build passed; release and feed publication were skipped on this descendant. Main skips EF container shards by policy; the exact-head premerge Full tier EF shards passed. Existing quarantine #3261 remains failed/excluded, with no other failed-twice, retry-only or aborted outcomes in the nine audited main shard artifacts. Earlier postmerge CI/Studio/CodeQL runs canceled by the descendant push are superseded evidence, not passes.

After this qualification completed, separate Weaver PR #3497 advanced main to ab46bc22a52aa6e456bca6ac0e803c80904de081. Its CI is running and is not counted as passed here. Ancestry and all 32 PR-owned files were rechecked on that newer main; they still match the reviewed head. The completed postmerge gate evidence above applies specifically to d4dcd947c50b0e5e305b708401d3844b3683da38.

@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 992a5675-cace-4ef2-b55e-a71c0b071abe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

[Codex] On behalf of @sfmskywalker. Continue the same branch and push each scoped fix, as requested in this chat. The branch was resumed for this new repair after #3487 merged; this PR contains only the new Properties scrolling change.

Local evidence for 80198458b2df2a7d15019ecc1dd0acc4b1cf39aa, based on main d2f99623d4313b7e40ec0a67b492ca9883719e3d:

  • Browser reproduction: with Structured Logs expanded, Properties had clientHeight=scrollHeight=1040 while its bottom was1188px and the bottom panel began at460px. After the fix, Properties occupies312px above the panel, retains1040px scrollHeight and reaches scrollTop728; the final Versions content is visible above the panel.
  • pnpm exec playwright test workflow-properties-scroll.spec.ts studio-scroll-containment.spec.ts editor-run-canvas.spec.ts --workers=2: 21 passed. Light/dark Properties regressions at1440px/390px include native wheel scrolling and focus returning to an earlier field.
  • Causal control using the final test: temporarily restore only the pre-fix CSS, then run the four new cases. All four fail with zero scroll range. Restore the fix byte-for-byte and repeat: four passed.
  • pnpm --recursive --workspace-concurrency=1 test --maxWorkers=2 --minWorkers=1: 3,976 passed across19 package summaries; no failed test summary.
  • pnpm lint: zero errors,54 existing warnings; CSS/layout checks passed. pnpm typecheck and the workflow production build/bundle budgets passed. Final browser test typecheck and targeted ESLint also passed after test refinements.
  • dotnet run --project tools/maps/Elsa.Maps.Generator -- check: passed. Graph restore followed by the complete architecture suite: 592 passed, zero failed/skipped.
  • The diff preserves the existing disabled fieldset and changes only its flex sizing; no new production abstraction, project/dependency/API/persistence changes or obsolete behavior. No constitutional exception is needed. Worktree is clean and the commit is pushed.

Hosted checks are pending. The PR remains a draft; no merge or hosted-check completion is claimed.

@elsa-workflows-codex elsa-workflows-codex Bot changed the title Fix workflow Properties scrolling above the bottom panel Fix workflow Properties scrolling and Activity availability sizing Oct 31, 2026
@elsa-workflows-codex

elsa-workflows-codex Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor Author

Activity availability height repair is pushed as 3d73f0cf3, with latest-main integration at 359e8cc9ea112a5a4e11c82f02964f9afb935b8e. Both the list and details pane now follow the shell's available height; there is no 520px cap. The page body provides overflow for short workspaces and stacked details. This also preserves the earlier Properties scrolling repair.

Evidence for the integrated head:

  • pnpm exec playwright test activity-availability-layout.spec.ts workflow-properties-scroll.spec.ts studio-scroll-containment.spec.ts editor-run-canvas.spec.ts workspace-appearance.spec.ts collection-slots.spec.ts --workers=2:99 passed.
  • Full local Studio lint/typecheck and workflow production build/bundle budgets:passed (lint 0 errors/54 existing warnings).
  • Hosted frontend CI job124388254510:3,989 passed in the normal run; each of seeds 1/11/29 passed2,775. Checkout 0f7d3b06827d90f93d15ccd720bd946e1cf41a69 merges this exact head into its ancestor main d481d6a5e; its tree and local head both equal cc6efd9cc1041a86a9c0e8ed482628069820f7c1.
  • Availability negative control:all four tall/sparse light/dark cases failed without the change:long lists stopped at 520px, sparse lists at 185.5px. All six new cases passed with the fix, including bottom-panel resize, independent details overflow, filtering/empty results, host-locked switches and short/narrow auxiliary controls. The relevant CSS and tests are unchanged through main integration.
  • Architecture:592 passed,0 failed/skipped; generated-map check passed before the frontend-only integration, whose .NET sources and graph are unchanged.

Non-pass outcomes remain distinct:

  • The pre-integration partial unit run was stopped when main advanced; superseded, not passed.
  • The first integrated local frontend run completed the Workflows project with 2,774 passed and one Advanced-expansion assertion failure (Investigate intermittent Advanced expansion assertion in dynamic-input tests #3505); an unchanged full-file recheck passed all six tests.
  • A one-worker local retry encountered a different folder-rename case (Element not found, Investigate intermittent element lookup in rejected folder-rename test #3506). The retry was stopped after the full hosted qualification passed; it is not a successful whole local retry. The unchanged four-case rename family passed separately (133 other cases excluded by its name filter).
  • No cause or repair of these intermittent failures is claimed; both follow-ups remain open. No new skip, quarantine or weakened assertion was introduced.

The worktree is clean, the existing branch is pushed, and the PR remains a draft. Other hosted jobs are still pending; no merge or complete-hosted-suite claim is made.

@elsa-workflows-codex elsa-workflows-codex Bot changed the title Fix workflow Properties scrolling and Activity availability sizing Fix Studio panel sizing and simplify Activity Definition editing Oct 31, 2026
@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Activity Definition interface cleanup is pushed at 4dfeb8d42b56d209513428de4febe1d5cfcc8c4b. The previous panel fixes remain unchanged.

Presentation changes: flat member groups and plain counts; focused detail form with bounded width and quieter secondary actions; two related designer-connection sections grouped together; shared Studio buttons; aligned selectors; Advanced details and optional suggestions remain available below the routine flow. The same forms collapse to one column on narrow screens.

Exact-head local validation:

  • pnpm exec playwright test activity-authoring.spec.ts activity-interface-layout.spec.ts --workers=2: 26 passed. Six new cases cover light/dark, 1920px/390px, save/reload of stable completion mappings, keyboard Connect, and read-only controls. Existing journeys cover unapplied defaults, default errors, variables, saved output bindings and header/navigation behavior.
  • pnpm --recursive --workspace-concurrency=1 test --maxWorkers=2 --minWorkers=1: 3,989 passed, 19 passing package summaries, no failed summary. This run passed on its first attempt; earlier Investigate intermittent Advanced expansion assertion in dynamic-input tests #3505/Investigate intermittent element lookup in rejected folder-rename test #3506 failures remain separately recorded and are not claimed fixed.
  • pnpm lint: 0 errors, 54 existing warnings, CSS/layout checks passed; pnpm typecheck: passed. Workflow production build and all bundle budgets passed.
  • Generated-map check passed. Complete architecture suite: 592 passed, 0 failed/skipped.
  • Negative control: temporarily replace only the two changed layout stylesheets with their pre-fix versions. Both desktop cases fail at the over-wide member navigator (389.2px); restore the refined CSS byte-for-byte and repeat the complete browser group: all 26 pass.
  • Visual review completed on desktop and narrow screenshots. Dark and light desktop previews are retained locally as activity-interface-dark-desktop.png and activity-interface-light-desktop.png.

No authoring state, identifiers, binding payloads, permission/read-only gates, persistence or publication contracts changed. No tests were weakened, skipped or quarantined. The worktree is clean and the same branch is pushed. The PR remains a draft with latest-head hosted checks pending.

@elsa-workflows-codex elsa-workflows-codex Bot changed the title Fix Studio panel sizing and simplify Activity Definition editing Fix Studio authoring layouts and tenant-scoped Test Runs Oct 31, 2026
@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Test Run fixes pushed on the existing branch at 79e2fa9afab6d9a9b2146dc73cc50727260f4075 (tenant fix 69bb4c8e0, rejection UI fix 79e2fa9af).

Confirmed defects: Test Run options/draft/version compilation dropped the current tenant, unlike normal publication; TestRun source references also lacked it. Compilation-rejected views then started observation and controls, which could replace the useful rejection with a scoped-runtime 404. Compilation and source references now retain the current tenant, and compilation rejections never begin execution observation or controls. Existing cross-tenant, publication and ambiguity guards are unchanged.

Local validation:

  • Publishing API: 906 passed, 0 failed/skipped. Dispatch Workflow: 380 passed, 0 failed/skipped. Architecture: 592 passed, 0 failed/skipped.
  • Complete Studio workspace: 3,991 passed. Validation/rejection browser group: 4 passed, including light/dark no-request and no-controls regressions.
  • Full Studio lint/typecheck, browser fixture typecheck, map check and workflow production build/budgets passed. Lint: 0 errors, 54 existing warnings.
  • Negative controls: tenant cases fail before the backend fix (3 fail / 3 global pass); observation regression fails before its fix; removing only the UI fixes makes both new browser cases fail, and restoring them returns the full four-case browser group to passing.

Live read-only evidence: Dispatchee exists at published 3.0.0 with one live Published reference to artifact-23315e9d9d91. This validates the user's observation. Tenant propagation is a confirmed source bug consistent with that rejection; its role in the exact live failure is not yet confirmed by a rebuilt-host run. No live workflow execution, publication or host restart was performed. Hosted checks are pending; PR stays draft.

@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Workflow-definition table density fix pushed at c0d690b33b21d034efaa1d9f01bb38531c35cb2a on the same branch.

Modified now uses a content-sized column and a non-wrapping timestamp, so it takes the width it needs from the flexible Name column. Rows use 44px minimum height with 6px vertical padding, including the workspace appearance that previously forced 64px rows. Other table density styles are unchanged.

Validation:

  • Before the fix, all four light/dark laptop/desktop regression cases fail because Modified wraps. After the fix, all 20 workflow-definition browse browser cases pass, including existing 320px/390px alignment, copy, keyboard and navigation checks.
  • Eight new density cases pass across 1280px/1920px, light/dark and standard/workspace styles; final screenshot-enabled rerun: 8 passed. They check single-line timestamps that fit their columns, rows no taller than 44px for ordinary values, and accessible actions. Light/dark screenshots were visually reviewed.
  • Complete Studio workspace: 3,991 unit tests passed. Architecture: 592 passed, 0 failed/skipped. Studio lint/typecheck, generated-map check and workflow build/budgets passed. Lint retains 54 existing warnings, 0 errors.

No data, API, permission, selection or action behavior changes. Hosted checks for this new head are pending; PR remains draft.

@elsa-workflows-codex elsa-workflows-codex Bot changed the title Fix Studio authoring layouts and tenant-scoped Test Runs Fix Studio authoring layouts, Test Runs and stale diagnostics Oct 31, 2026
@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Stale validation fix pushed on the existing branch at 87d64a523237c9b843facbde70d629a391145795.

Workflow draft validation now waits for the matching draft snapshot to be saved before reading the server's stored-state validations. The save/load acknowledgement includes draft and definition identity plus the authored signature. Unsaved edits cancel the prior validation read; successful autosave or manual saving starts a fresh read even though saving does not change the authored signature.

The reproduced race was a validation read at 600ms beating autosave at 1200ms, leaving a deleted Run Etl's required Pipeline error in the server-validation list after saving completed. The same race persists with a slow save, so increasing the debounce alone would not solve it. The fix retains the existing save queue, publication checks, server validators and optional-capability fallback.

Local validation:

  • Four new rendered hook regressions cover normal autosave, slow saves, manual saving with autosave disabled, and clearing the diagnostic after saving. Replacing only the validation hook with its pre-fix version makes all four fail; the fixed hook passes them in the complete suite.
  • 18 browser checks passed: four new light/dark normal/slow-save journeys use the actual workflow editor, delete Run Etl, verify validation reads the saved deletion, verify Undo restores the diagnostic or reload preserves the deletion, plus existing duplicate/edit/start-toggle keyboard journeys.
  • Complete Studio workspace: 3,995 unit tests passed. Architecture: 592 passed, 0 failed/skipped. Full Studio typecheck/lint, workflow production build/budgets and generated-map check passed. Lint: 0 errors, 54 existing warnings.

No backend/API, permission, validation rule, publication guard, or dependency changes. No live user workflow was edited or executed. Hosted checks on the new head remain pending; the PR stays draft.

@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Self-review round 1

Reviewed head: 342741c9f3ebafeb8996835aef7dd3d3e5a94e51
Review base: dec598d9997eaf0b3f8c778ca358f8393a673171 (main, including Linen presentation #3498).

Three independent, isolated reviewers inspected the complete 31-file PR diff and surrounding code, plus the PR discussion and review threads:

  • Correctness: no actionable findings.
  • Repository standards/constitutional boundaries: no actionable findings.
  • User acceptance and test quality: no actionable findings.

Surviving findings: none. Findings fixed/dropped in this round: none. No human holds or inline review threads were present. Review converged in one round.

The current-head frontend, browser, backend and architecture qualification is running after main integration. Earlier green evidence belongs to its named earlier heads and is not substituted for this integrated-head run. Earlier scoped negative controls remain documented in the PR receipts.

Marking ready to start the required full tier. Delivery will use the Codex/Claude standing self-merge authorization (org AGENTS.md, 18 Oct 2026) only after exact-head required checks and all applicable gates pass, with the prescribed audit comment and label before merge. No merge is claimed yet.

@elsa-workflows-codex
elsa-workflows-codex Bot marked this pull request as ready for review October 31, 2026 02:03
@greptile-apps

greptile-apps Bot commented Oct 31, 2026

Copy link
Copy Markdown

This PR does not match any of the 1 configured review trigger rule.

@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Integrated-head local qualification

Head: 342741c9f3ebafeb8996835aef7dd3d3e5a94e51
Base: dec598d9997eaf0b3f8c778ca358f8393a673171
Synthetic CI merge: ff4010233ea5013f231aeaa8507461da32d2fbd3
Both reviewed head and synthetic merge have tree b211dcaed4742377ebdf9d4c1feb8d6168b4035c.

  • Complete Studio workspace (pnpm --recursive --workspace-concurrency=1 test --maxWorkers=2 --minWorkers=1): 4,018 passed, 19 package summaries, no failing summary.
  • Browser group (workflow-properties-scroll, activity-availability-layout, activity-authoring, activity-interface-layout, workflow-definition-browse-context, validation-labels, draft-validation-autosave, activity-duplicate, workflow-start-toggle, workspace-appearance, --workers=2): 172 passed. Includes Linen style/color combinations from the integrated main.
  • Publishing API complete project: 906 passed, 0 failed/skipped. Dispatch Workflow complete project: 380 passed, 0 failed/skipped.
  • Architecture complete project: 592 passed, 0 failed/skipped, repeated after bash tools/architecture/restore-ci-project-graph.sh restored both configuration graphs.
  • Full Studio lint/typecheck, map check and workflow production build/bundle budgets passed. Lint retains 54 existing warnings, zero errors.
  • Workflow shuffled unit seed 1: 2,781 passed. Seeds 11/29 are running; exact results will be recorded separately.

Independent review round 1 converged with no actionable findings on this exact head. Earlier negative controls remain valid for the unchanged owned behavior and are recorded in previous receipts. Hosted CI, Studio CI and ready-PR full tier are still pending; no merge is claimed. Superseded draft full-tier planning was cancelled by readiness and does not count as a pass. Existing quarantine entries are unchanged and will be reported separately from passed tests.

@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Final local shuffled qualification for reviewed head 342741c9f3ebafeb8996835aef7dd3d3e5a94e51:

pnpm --filter @elsa-workflows/studio-workflows exec vitest run --sequence.shuffle --sequence.seed=<seed> --maxWorkers=2 --minWorkers=1

  • Seed 1: 2,781 passed, 205 test files passed.
  • Seed 11: 2,781 passed, 205 test files passed.
  • Seed 29: 2,781 passed, 205 test files passed.

All three runs passed without retries. Local qualification is complete. Hosted required gates remain pending; this does not authorize merging before their exact-head results pass.

@elsa-workflows-codex
elsa-workflows-codex Bot marked this pull request as draft October 31, 2026 02:37
@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Self-review round 2

Reviewed head: 7449bf0633f2c6173c23f1705a11bb48787466a7
Base: dec598d9997eaf0b3f8c778ca358f8393a673171

CI finding fixed: the graph-authoring browser journey still asserted the old Completion paths help paragraph after the approved UI copy rewrite. Hosted Studio browser qualification on 342741c9f reported 735 passed, 1 failed, 6 skipped (the six existing opt-in screenshot cases). The failing journey was reproduced locally with its unchanged assertion.

Fix: 7449bf063 checks the visible Completion paths heading inside the same Public Interface tabpanel. It retains all subsequent source/target selections, both resulting mappings, JSON editing, diagnostics, Test Run and schema-1 compatibility assertions. No production file changed and no test was skipped or behavior assertion weakened.

Validation: the updated graph-authoring, activity-authoring and interface-layout group passed 27 browser checks. Browser fixture TypeScript and targeted ESLint passed. All other production files are byte-identical to the prior locally qualified head (4,018 workspace tests, 172 browser checks, three 2,781-test shuffles, 906 Publishing API, 380 Dispatch Workflow, 592 architecture).

Three isolated reviewers re-reviewed the current full diff and the incremental change for correctness, standards, and acceptance/test quality. No actionable findings remain; round 2 converged.

Prior-head hosted CI and Full tier passed, but they are superseded for exact-head gating by this test-only commit and are not counted as the new head's checks. Full-tier artifacts showed no retry-only passes or unquarantined failures; existing quarantine #3261 failed and was excluded under the unchanged quarantine policy. It is not reported as a passed test.

Marking ready for fresh exact-head CI/Studio/Full tier. Merge remains gated on those results.

@elsa-workflows-codex
elsa-workflows-codex Bot marked this pull request as ready for review October 31, 2026 02:38
@elsa-workflows-codex
elsa-workflows-codex Bot marked this pull request as draft October 31, 2026 03:03
@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Self-review round 3

Reviewed head: c54ea9539ee39b991960b2f73a7104b660787b31
Review base: a01980064aed293502b9ada57a682286d950c7fd

Main advanced with #3510, a compensation-browser focus test correction. It merged cleanly. Independent comparison confirms the complete PR-owned diff against the new base is byte-identical to the previously reviewed diff against its old base; only the separate base browser test changed in the integration.

Three isolated reviewers independently verified correctness, repository standards and acceptance/test quality on the new head/base. No actionable findings or new acceptance gaps; round 3 converged. Findings fixed/dropped in this round: none. No production changes were introduced by this integration.

Current-head workspace unit, affected browser (including graph authoring and compensation), lint/typecheck/build, Publishing API, Dispatch Workflow, architecture and maps qualification is running. Marking ready to start fresh exact-head hosted qualification. Earlier check results are retained as historical evidence and are not used as this head's merge gates.

@elsa-workflows-codex
elsa-workflows-codex Bot marked this pull request as ready for review October 31, 2026 03:04
@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Current-head local qualification

Head: c54ea9539ee39b991960b2f73a7104b660787b31
Base: a01980064aed293502b9ada57a682286d950c7fd
Synthetic CI merge: 7ebf8aff77c57bd4922aba414fcbe3556a8f0cf4
Reviewed head and synthetic merge both have tree 4fe03f608b0cc4717c87578cc9deff440e5e56c2.

  • Complete Studio workspace: 4,018 unit tests passed, 19 package summaries, no failed summary.
  • Complete affected browser group, including graph authoring and current-main compensation journeys: 253 passed on an owned port/server with reuse disabled. The first local attempt reused a shared fixture server that disappeared mid-run (connection refused; 19 passed / 234 failed). That attempt is recorded as an infrastructure failure, not a product pass; the unchanged-code isolated rerun passed all 253 cases. No test source, timeout, skip or product guard was relaxed.
  • Publishing API: 906 passed, 0 failed/skipped. Dispatch Workflow: 380 passed, 0 failed/skipped. Architecture: 592 passed, 0 failed/skipped. Production source is unchanged from the prior graph-restored build.
  • Full Studio lint/typecheck, generated-map check, workflow production build and all bundle budgets passed. Lint: zero errors and 54 existing warnings.

Three independent review lenses converged with no actionable findings in round 3. Earlier negative controls are retained as named historical receipts. Current-head CI/Studio/full-tier hosted gates remain pending; no merge is claimed and no superseded check is substituted for this head.

@elsa-workflows-codex elsa-workflows-codex Bot added the self-merged Merged by Codex or Claude after a clean self-review loop under standing authorization label Oct 31, 2026
@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Self-merge (standing authorization, Oct 18 2026)

Rounds run: 3 (round 1, round 2, round 3). Each used independent correctness, standards and acceptance/test-quality reviewers. Final round converged with no actionable findings.
Findings fixed: obsolete graph-authoring help-copy assertion: 7449bf0633f2c6173c23f1705a11bb48787466a7.
Remaining Low notes: none.
Reviewed head SHA: c54ea9539ee39b991960b2f73a7104b660787b31.

Current base a01980064aed293502b9ada57a682286d950c7fd is integrated. Synthetic CI merge 7ebf8aff77c57bd4922aba414fcbe3556a8f0cf4 and reviewed head both have tree 4fe03f608b0cc4717c87578cc9deff440e5e56c2.

Exact-head hosted gates:

  • CI: Build & test, Generated maps fresh, all PR shards, architecture and core-only checks passed.
  • Full tier: all integration and EF container shards and aggregate passed.
  • Studio CI: frontend lint/typecheck/unit/shuffles, package/consumer qualification and browser gate passed. Browser: 737 passed, 6 skipped; the six are existing opt-in screenshot cases.
  • GitGuardian passed. No submitted reviews, unresolved review threads, human holds, blocked/needs:decision labels or failed current-head checks were present in the final audit.

Test outcome artifacts: PR tier has no retry-only passes, failed-twice entries, quarantined failures or aborted tests. Full tier has no retry-only passes, unquarantined failures or aborts; existing quarantine #3261 failed/excluded under the unchanged policy and is not counted as passed. Local current-head evidence (4,018 unit / 253 browser / 906 Publishing / 380 Dispatch / 592 architecture) and negative controls are recorded in earlier receipts.

The non-required license/cla check remains queued; CodeRabbit is skipped. Standing authorization explicitly permits the pending non-required CLA check. No protection bypass will be used. Org instructions were re-fetched and confirmed unchanged before this audit.

@elsa-workflows-codex
elsa-workflows-codex Bot merged commit a2cf474 into main Oct 31, 2026
26 of 27 checks passed
@elsa-workflows-codex
elsa-workflows-codex Bot deleted the codex/inspector-run-data-spacing branch October 31, 2026 03:53
@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Merged as a2cf47488fc7db8ba60c93c8b03fe4d78f6530d9 under the standing authorization audit, using the normal merge API with reviewed-head guard and no protection bypass.

Verified resulting main and reviewed head have identical tree 4fe03f608b0cc4717c87578cc9deff440e5e56c2. The worktree is clean.

Post-merge gates on this exact SHA are running:

Merge is complete; resulting-main qualification remains pending. No pending, skipped or quarantined outcome is reported as a pass.

@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Post-merge qualification update: main advanced to d4dcd947c50b0e5e305b708401d3844b3683da38 with #3502 (JavaScript workflow args), after merge a2cf47488.

Ancestry verification confirms our merge is included. GitHub cancelled the original merge's CI, Studio and CodeQL runs as superseded; those cancellations are not reported as passes. The original Packages run succeeded.

Qualifying the descendant instead:

Resulting-main qualification remains pending; the PR is merged, not reopened or changed.

@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

Final postmerge qualification — complete

PR merged as a2cf47488fc7db8ba60c93c8b03fe4d78f6530d9. Its tree exactly matches reviewed head c54ea9539ee39b991960b2f73a7104b660787b31 (tree 4fe03f608b0cc4717c87578cc9deff440e5e56c2).

Qualified descendant main: d4dcd947c50b0e5e305b708401d3844b3683da38. Ancestry verified; all 32 PR-owned files match the reviewed head byte-for-byte. The intervening PR changes six separate files with no overlap.

All four workflows completed successfully on that exact descendant:

  • CI: PR, integration, architecture, core-only and aggregate gates passed; generated maps freshness and publication passed.
  • Studio CI: frontend lint/typecheck/unit/shuffle checks, .NET qualification and Chromium passed. Browser result: 737 passed, 6 skipped; skips are existing opt-in screenshot cases.
  • Packages: package build passed; release and feed publication skipped on this descendant.
  • CodeQL: C#, JavaScript/TypeScript, Python and Actions analyses passed.

Audited all nine main shard outcome artifacts and verified their head SHA. No failed-twice, retry-only or aborted outcomes. The existing compensation sample quarantine #3261 remains failed/excluded, not passed; no quarantine policy was changed. Main skips EF container shards by workflow policy; all corresponding exact-head premerge Full tier shards passed.

Earlier postmerge CI/Studio/CodeQL runs canceled by the later main push were superseded and were not counted as passes. No deployment or live workflow execution claim is made; the exact captured Dispatch Workflow failure still awaits a rebuilt-backend live rerun. Source fixes and regression qualification are complete. Separate intermittent assertions #3505/#3506 are not claimed fixed.

@elsa-workflows-codex

Copy link
Copy Markdown
Contributor Author

After this qualification completed, separate Weaver PR #3497 advanced main to ab46bc22a52aa6e456bca6ac0e803c80904de081. Its CI is running and is not counted as passed here. Ancestry and all 32 PR-owned files were rechecked on that newer main; they still match the reviewed head. The completed postmerge gate evidence above applies specifically to d4dcd947c50b0e5e305b708401d3844b3683da38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

self-merged Merged by Codex or Claude after a clean self-review loop under standing authorization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant