Repository navigation
Prove Weaver extension through independent package consumers - #3497
Conversation
|
Integration refresh: main Project65 was reread: Kanban WIP is a real Board view excluding Program/epic rollups; only#3438 is In review, M1/Program In progress, M2–M5/remaining leaves Backlog. Completed M0/#3437 remain Done. No downstream implementation leaf or Ready promotion is activated. |
|
@elsa-workflows-codex[bot] please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
1 similar comment
|
@elsa-workflows-codex[bot] please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
There was a problem hiding this comment.
Elsa 4 Code Review: APPROVE + medium-high @ 2d65108
Code Review, Round 1/6 (carried forward)
The new head only merges main (#3502). I checked that the PR's own diff against the new merge base is byte-identical to the diff I reviewed at 90c71c7f2cfa41ee754abac650f9cfa99f788f55, so the Round 1 verdict and notes above still apply.
Blockers
None.
Non-blocking
The items in the previous review are unchanged: one Low each on the workflow's cost, the store's constructor and reload, and the per-request assembly scan, plus two Nits.
I'll approve and merge this head once Build & test, Generated maps fresh and Full tier are green.
|
[Codex] On behalf of @sfmskywalker. The supported test-credential disposition is verified on integration-head check124438659512, exact source |
|
Current-main integration candidate PASSED the complete package witness: All 135 stages exit 0; all 38 cases qualify (16 positives and 22 precisely recognized Failed controls). Original and restored resource/workflow journeys complete through actual Copilot and Anthropic adapters with exact provider continuation and module-owned effect evidence. Both consumers have zero source references and frontend invocations. Native add/remove/incompatible/restore preserves all common published files byte-for-byte: 155 backend / 10,114 Studio. The new main adds six Studio baseline files relative to the earlier90c run; identity is required within each complete lifecycle. Owned hosts27430/27431 exit0 with empty final runtime caches. Report SHA256 Exact-head CI is running. Round4's clean verdict covers earlier90c; final review will target the eligible current integration head before merge. Merge, resulting-main verification and final owning acceptance/Done remain pending. Project #65 keeps #3438 In review and M1/Program In progress; M2–M5 remain open. |
|
Code Review has now inspected exact integration head Advisory notes assessed: the constructor migration/source break is already documented in the canonical preview migration table. Synchronous host reload is the currently demonstrated native configuration transition; no remote-provider behavior is claimed. The broad witness trigger intentionally guards common Studio/backend/package changes that broke the demonstrated journey; retaining that gate through this Program is deliberate. Asset-scan caching and registration handoff style have no reproduced correctness failure, so no extra mechanism is added. Documentation's implementation snapshot points to the owning issue/PR for current integration status; final evidence and checklists are maintained here. Current-head local conformance is complete (135 stages, 38 cases; report582dfb3d…). Exact-head required CI and the Linux package witness are still running. The normal Code Review approval/merge lane remains active; resulting-main verification and final issue/Project completion remain pending. |
|
@elsa-workflows-codex[bot] please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
|
Actual CI result/retention distinction: Linux run41167676042 passed the complete native package qualification at2d651086b: report Downloaded artifact13029797648 and audited it against its own index. The uploaded artifact is incomplete: 11,829 declared references but11,734 retained; exactly95 hidden paths omitted (94 Fixed in PR was returned to Draft while making this bounded correction. Own diff review is complete with no surviving finding. Next use the normal Code Review lane on this exact head; no new local three-reviewer round is claimed. Global review history is preserved: local rounds1–4 plus Code Review Round1/carried-forward; the next substantive Code Review review is the sixth overall. Do not reset the count. Merge and Done still require exact-head gates and resulting-main verification. |
|
@elsa-workflows-codex[bot] please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
|
Current frozen candidate is Own bounded diff review is complete with no surviving finding; all7 exporter privacy/reference/status tests and diff checks pass. The original2d native result remains Passed on macOS and Linux, while its uploaded archive remains incomplete. Fresh current-head CI must repeat qualification and retain every indexed file/hash before completion evidence is accepted. PR is Ready for the normal Code Review lane. No new local independent round is claimed or review count reset. Merge and resulting-main verification remain pending; #3438 stays In review, M1/Program In progress. M2–M5 remain open. No downstream implementation leaf is active. |
|
@elsa-workflows-bot review |
|
@elsa-workflows-codex[bot] please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
2 similar comments
|
@elsa-workflows-codex[bot] please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
|
@elsa-workflows-codex[bot] please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
There was a problem hiding this comment.
Elsa 4 Code Review: APPROVE + high @ 0258201
Code Review, Round 2/6
Delta reviewed since 2d65108 (two commits, 1f1a22e3 and 0258201c): the evidence artifact upload now keeps hidden files, and the spec, plan, quickstart, tasks and probe README point at owning issue #3438 for live gate status instead of a frozen PR comment anchor.
Blockers
None.
Non-blocking
- Low:
include-hidden-files: trueis safe here only becauseexport_evidence.pycopies just the files the report references by path and hash. Keep that selection reference-driven; if the exporter ever globs a directory, revisit this flag. - Low (carried from Round 1, unchanged): the earlier non-blocking notes still stand and can go to follow-ups.
Notes
- No file renames, so no published docs URLs change.
- GitGuardian is not a required check; the hits remain synthetic fixtures.
- Round is clean. Verdict holds for this exact head once
Build & test,Generated maps freshandFull tierare green; I'll approve and merge then.
|
Final source review is clean on The retained-file flag remains restricted to the reference-driven, hash-checked exporter output. The selector is unchanged; its privacy/status controls pass. The reviewer explicitly confirmed that boundary. CI's core-only build now passes; remaining exact-head tests and full uploaded-manifest audit are still pending. Preserve the incomplete older2d archive and its successful native result as distinct facts. Merge/main verification/owning acceptance remain open. |
|
[Codex] On behalf of @sfmskywalker. Current-head GitGuardian check124442526784 ( |
|
Exact-head Linux package qualification PASSED on The actual uploaded artifact13030288861 was downloaded and fully audited: all11,829 indexed files are present and hash-correct, including all95 hidden paths; zero missing, extra or mismatched files.
Required Build & test and Generated maps fresh now pass, with architecture592/592 (0skipped) and core-only successful. Remaining Full tier and Studio jobs are running; current-head Code Review is clean/Commented pending formal approval and merge. No Done or resulting-main claim. #3438 remains In review, M1/Program In progress; M2–M5 remain open. |
There was a problem hiding this comment.
Elsa 4 Code Review: APPROVE + high @ 0258201
Round 2/6 was clean and Build & test, Generated maps fresh and Full tier are green on this exact head. Approving and squash-merging.
|
Merged by Post-merge qualification is pending. #3438 was observed open after merge and remains open for the required resulting-main gate, with Project65 In review; no reopening action was necessary. This is planned verification, not a newly observed main failure. M1/Program remain In progress; no Done claim and no downstream implementation leaf yet. Verify current resulting main/CI and the composed package path, then reconcile acceptance, dependencies and board before starting#3439. |
|
Resulting-main runtime qualification PASSED on merged
The actual main upload/download audit verifies all11,829 indexed files and hashes, including hidden metadata, with no private runtime state or status promotion. Evidence remains deterministic provider-protocol; live-provider success is unclaimed. Whole Studio .NET verification reconciles653passed/0skipped against646listed entries: one discovered theory expands to8runtime rows (+7), with no unexecuted listed method. This matches CI's653pass result. Agent262, Modularity401 and architecture592 pass on the reviewed source; frontend Hosting678/Workflows2803 pass per invocation, without multiplying repeated invocations. Core CI's pre-existing SQLite pool stress test remains opt-in Skipped ( Current main Build & test, Generated maps fresh and its integration shards pass, with no failed checks or open main-red report. Main Studio browser CI is still active. M1/#3438 remain In progress/In review until that final verification and checklist reconciliation; no downstream implementation leaf is active. |
|
M1 final verification complete at resulting main Evidence: macOS and Linux main each qualify135stages/38cases (16positives /22 precisely recognized Failed controls); owning-resource effects, native workflow validation/atomic working state/whole Undo/explicit Save, authority/stale/cancel/duplicate/confirmation/removal controls and restoration are observed. Both consumers use only packages with zero source references/frontend invocations;155backend/10,114Studio common files remain byte-identical through the module lifecycle. The actual main artifact contains all11,829 referenced files and verified hashes; report Main browser summary is 737passed /6skipped: all six are opt-in screenshot-capture cases, not failed/quarantined cases. Core's SQLite pool stress test remains an unchanged opt-in skip. Studio .NET653passed reconciles646discovery entries plus7runtime theory rows; Agent262, Modularity401, architecture592, frontend Hosting678/Workflows2803 per invocation and driver106 pass. Skips remain skips, not passed cases. Evidence is deterministic provider-protocol; live-provider success is unclaimed. Any derived optional image-publication job is outside this Program's release/deployment scope and is not claimed here. The bounded M1 minimum, preview migration, scoped extension catalogs and reusable independent package fixture are accepted and delivered. Live owning-issue receipts fulfill T026–T028; committed tasks intentionally preserve their preparation snapshot. #3438 and M1#3430 can now be completed/Done. This does not complete Program3428: M2–M5 remain open, with3439 the next eligible leaf. No new Ready promotion or second implementation leaf is introduced. |
Problem and result
An external module must contribute a complete Weaver journey through supported distributions without changes to Weaver core, Studio host or provider adapters. Add a reusable conformance driver, independently authored resource/backend/Studio packages, and a resource-agnostic provider-protocol fixture. The composed native Studio/backend proves context → tool → review → owning application/readback through both actual Copilot and Anthropic adapters.
Modules own context, guidance, tools, validation, risk, rendering and effects. Bounded product corrections preserve that boundary: startup readability waits for normal application readiness; persisted feature configuration reloads synchronously; module assets resolve through the existing package catalog; consumed prompt intents do not replay on remount; Copilot preserves refused semantic outcomes; workflow positioning preserves unrelated layout metadata. The external resource checkbox has stable native pointer activation.
Fixes #3438. Program #3428; M1 #3430; spec1174.
Acceptance evidence
Validation and remaining gates
Complete qualified baseline
76ec58d0061135cfa028e1bc47ec7639fd139e7f: 135 stages, 38 cases (16 positives /22 precisely recognized Failed controls), 80 product packages and actual SDK tgz. Both package-only consumers have zero product-source references/frontend invocations. Both hosts exit0 with empty runtime caches. Curated receipt and owning evidence retain hashes and boundaries; safe export contains11,823 referenced evidence files and excludes private authentication/runtime state.Documentation head
b0a92a2469c4feccac51d373f0ee518aef507ecealso passed135stages/38cases (report SHA256135e71f4ebf23e151a725e8a22738cdf8872b58c41c60eb8cb6f822e661e33ed). Round2's shutdown outcome gate was fixed in6ebd6d811 with real owned-process causal regressions. Subsequent423 remains Failed: native owner/application passed, but the witness navigated before the receipt turn completed and strict correlation rejected the missing continuation. Two actual dock-completion waits repair that race; real Chromium controls reproduce old-source failures, and missing continuation still fails qualification.Current integration source
0258201cd44f17cc439ffc0eb92df9ebba40a9a1includes maind4dcd947c50b0e5e305b708401d3844b3683da38. Its product, fixture and validator bytes match qualified2d; changes only retain hidden references in the filtered evidence upload and point documentation at live issue/PR status.Candidate2d passed all135stages/38cases on macOS (report
582dfb3de816e27aebc44368869782de1542aed4a0538a7dc250d8e1c6449db7) and Linux CI (report4932354412c615e6c3ea27218417eb8766225540da966844e01faa0e41ebcdf4), with155backend/10,114Studio common files unchanged and zero consumer source/frontend use. Linux also passed106/106 driver tests. Its uploaded artifact omitted95 hidden references despite native success; the original archive remains incomplete.include-hidden-files: trueapplies only to the already-filtered safe export. All7 selector privacy/reference/status tests pass; current-head CI must prove complete retention by matching every indexed hash.Four independent local review rounds converged; Code Review reported no blockers on2d with GitHub state Commented pending CI. Updated-head normal review, required CI, complete uploaded evidence, merge and resulting-main verification remain pending. Earlier failed reports remain Failed; no no-op or transport-only effect is accepted.
The two authorized historical synthetic GitGuardian incidents received the supported test-credential disposition on2d (Skipped). Current-head security is reverified separately; this is not a passed scan or incident-closure claim.
Limits
Evidence is deterministic provider-protocol; live-provider success is unclaimed. Process-local proposal retention, one mutating operation per turn and explicit client review remain documented limits. Full workflow/current-module journeys and broader shared recovery/provider/custom-host qualification remain M2–M5. Release, deployment, provider purchase, credential extraction and publisher activation are outside this PR.