Skip to content

menubutton: arrow: Use open-menu-symbolic when no direction - #1354

Merged
danirabbit merged 3 commits into
mainfrom
ryonakano/arrow-open-menu-when-none
Aug 30, 2026
Merged

danirabbit merged 3 commits into
mainfrom
ryonakano/arrow-open-menu-when-none

Conversation

@ryonakano

@ryonakano ryonakano commented Aug 30, 2026

Copy link
Copy Markdown
Member

Backport of elementary/granite#1013 as requested at elementary/granite#1013 (comment)

Checklists

  • Confirmed the expected icon is used when building our File Roller with the following diff
    image
  • Confirmed other widgets like dropdowns is not affected to this change
    image
A patch to build this branch inside the sanbox
diff --git a/org.gnome.FileRoller.json b/org.gnome.FileRoller.json
index c3ccc8e..2c2e562 100644
--- a/org.gnome.FileRoller.json
+++ b/org.gnome.FileRoller.json
@@ -99,6 +99,65 @@
                 }
             ]
         },
+        {
+            "name": "stylesheet",
+            "buildsystem": "meson",
+            "sources": [
+                {
+                    "type": "git",
+                    "url": "https://github.com/elementary/stylesheet.git",
+                    "commit": "b87aa2020a59fdeb6aac5be0d8d27fc4ca920d01",
+                    "x-checker-data": {
+                        "type": "git",
+                        "tag-pattern": "^([\\d.]+)$"
+                    }
+                }
+            ],
+            "modules": [
+                {
+                    "name": "sassc",
+                    "cleanup": [
+                        "*"
+                    ],
+                    "sources": [
+                        {
+                            "type": "git",
+                            "url": "https://github.com/sass/sassc.git",
+                            "tag": "3.6.2"
+                        },
+                        {
+                            "type": "script",
+                            "dest-filename": "autogen.sh",
+                            "commands": [
+                                "autoreconf -si"
+                            ]
+                        }
+                    ],
+                    "modules": [
+                        {
+                            "name": "libsass",
+                            "cleanup": [
+                                "*"
+                            ],
+                            "sources": [
+                                {
+                                    "type": "git",
+                                    "url": "https://github.com/sass/libsass.git",
+                                    "tag": "3.6.5"
+                                },
+                                {
+                                    "type": "script",
+                                    "dest-filename": "autogen.sh",
+                                    "commands": [
+                                        "autoreconf -si"
+                                    ]
+                                }
+                            ]
+                        }
+                    ]
+                }
+            ]
+        },
         {
             "name": "file-roller",
             "buildsystem": "meson",

@ryonakano ryonakano changed the title menubuttons: arrow: Use open-menu-symbolic when no direction menubutton: arrow: Use open-menu-symbolic when no direction Aug 30, 2026
@ryonakano
ryonakano requested a review from danirabbit August 30, 2026 04:39
@ryonakano ryonakano added this to OS 9 Aug 30, 2026
@ryonakano ryonakano moved this to Needs Review in OS 9 Aug 30, 2026
@ryonakano

Copy link
Copy Markdown
Member Author

I'll separate to different file as requested at elementary/granite#1013 (review)

@ryonakano
ryonakano removed the request for review from danirabbit August 30, 2026 04:42
@ryonakano ryonakano moved this from Needs Review to In progress in OS 9 Aug 30, 2026
@ryonakano
ryonakano requested a review from danirabbit August 30, 2026 05:01
@ryonakano ryonakano moved this from In progress to Needs Review in OS 9 Aug 30, 2026
@danirabbit
danirabbit merged commit ce64905 into main Aug 30, 2026
3 checks passed
@danirabbit
danirabbit deleted the ryonakano/arrow-open-menu-when-none branch August 30, 2026 05:20
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in OS 9 Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Use open-menu-symbolic instead of pan-down-symbolic when Gtk.ArrowType.NONE is set

2 participants