menubutton: arrow: Use open-menu-symbolic when no direction

[ryonakano]

Fixes #1012

Checklist

• Confirmed the expected icon is used when building our File Roller with the following diff and changing GTK Theme to Granite using GTK Inspector
  
• Confirmed other widgets like dropdowns is not affected to this change
  

A patch to build this branch inside the sanbox

diff --git a/org.gnome.FileRoller.json b/org.gnome.FileRoller.json
index c3ccc8e..1713862 100644
--- a/org.gnome.FileRoller.json
+++ b/org.gnome.FileRoller.json
@@ -99,6 +99,68 @@
                 }
             ]
         },
+        {
+            "name": "granite-7",
+            "buildsystem": "meson",
+            "config-opts": [
+                "-Ddemo=false"
+            ],
+            "sources": [
+                {
+                    "type": "git",
+                    "url": "https://github.com/elementary/granite.git",
+                    "commit": "bc4455f175f5e56da9632f5139f6dfc57c02d03f",
+                    "x-checker-data": {
+                        "type": "git",
+                        "tag-pattern": "^([\\d.]+)$"
+                    }
+                }
+            ],
+            "modules": [
+                {
+                    "name": "sassc",
+                    "cleanup": [
+                        "*"
+                    ],
+                    "sources": [
+                        {
+                            "type": "git",
+                            "url": "https://github.com/sass/sassc.git",
+                            "tag": "3.6.2"
+                        },
+                        {
+                            "type": "script",
+                            "dest-filename": "autogen.sh",
+                            "commands": [
+                                "autoreconf -si"
+                            ]
+                        }
+                    ],
+                    "modules": [
+                        {
+                            "name": "libsass",
+                            "cleanup": [
+                                "*"
+                            ],
+                            "sources": [
+                                {
+                                    "type": "git",
+                                    "url": "https://github.com/sass/libsass.git",
+                                    "tag": "3.6.5"
+                                },
+                                {
+                                    "type": "script",
+                                    "dest-filename": "autogen.sh",
+                                    "commands": [
+                                        "autoreconf -si"
+                                    ]
+                                }
+                            ]
+                        }
+                    ]
+                }
+            ]
+        },
         {
             "name": "file-roller",
             "buildsystem": "meson",

[danirabbit]

Thanks! We'll want to cherry pick this fix back to the granite-7 branch I imagine since main is granite 9?

[ryonakano]

Thanks! We'll want to cherry pick this fix back to the granite-7 branch I imagine since main is granite 9?

Am I understand correctly that what we should work on is the stylesheet repository not here because the new stylesheet has not been released yet?

[danirabbit]

@ryonakano yes exactly. Sorry I misspoke about committing it to granite-7. It would need to be in Stylesheet

[ryonakano]

Ah, I noticed we should limit this style to menubutton as done in libadwaita, otherwise it will widely applied like this:

[ryonakano]

@danirabbit I modified this fix so that it won't be affected to other places like dropdowns. Also backported it to stylesheet: elementary/stylesheet#1354

[danirabbit]

Can you add a MenuButton file so we can stick to one class per file?

Sorry to keep asking for changes 🙇🏻‍♀️

[ryonakano]

Should be good now 👍

[danirabbit]

Perfect thank you!