Skip to content

Bin/Box: add has_frame property #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danirabbit wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bin/Box: add has_frame property #1054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dc2889
Bin/Box: add has_frame property
danirabbit Sep 19, 2026
75582a1
add since
danirabbit Sep 19, 2026
f4b5598
Merge branch 'main' into danirabbit/binbox-card
zeebok Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions demo/Views/CSSView.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,20 @@ public class CSSView : DemoPage {
secondary_text = "\"Granite.CssClass.CARD\" and \"Granite.CssClass.CHECKERBOARD\""
};

var card = new Gtk.Box (VERTICAL, 0) {
var card = new Granite.Box (VERTICAL, NONE) {
has_frame = true,
height_request = 128,
hexpand = true
};
card.add_css_class (Granite.CssClass.CARD);

var card_checkered = new Granite.Bin () {
child = new Gtk.Image.from_icon_name ("battery-low") {
halign = CENTER,
icon_size = LARGE
},
has_frame = true,
hexpand = true
};
card_checkered.add_css_class (Granite.CssClass.CARD);
card_checkered.add_css_class (Granite.CssClass.CHECKERBOARD);

var card_box = new Gtk.Box (HORIZONTAL, 24);
Expand Down
2 changes: 1 addition & 1 deletion demo/Views/LabelView.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ public class LabelView : DemoPage {
var copy_label_card = new Granite.Bin () {
child = copy_label,
halign = START,
has_frame = true,
width_request = 128
};
copy_label_card.add_css_class (Granite.CssClass.CARD);

var accellabel_box = new Granite.Box (VERTICAL, NONE);
accellabel_box.append (accellabel_header);
Expand Down
17 changes: 17 additions & 0 deletions lib/Widgets/Bin.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,23 @@ public class Granite.Bin : Gtk.Widget {
}
}

/**
* Whether #this has a frame
*/
[Version (since = "9.0.0")]
public bool has_frame {
get {
return has_css_class (Granite.CssClass.CARD);
}
set {
if (value && !has_css_class (Granite.CssClass.CARD)) {
add_css_class (Granite.CssClass.CARD);
} else if (has_css_class (Granite.CssClass.CARD)) {
remove_css_class (Granite.CssClass.CARD);
}
}
}

~Bin () {
if (child != null) {
child.unparent ();
Expand Down
17 changes: 17 additions & 0 deletions lib/Widgets/Box.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,23 @@ public class Granite.Box : Gtk.Box {
*/
public Spacing child_spacing { get; construct set; }

/**
* Whether #this has a frame
*/
[Version (since = "9.0.0")]
public bool has_frame {
get {
return has_css_class (Granite.CssClass.CARD);
}
set {
if (value && !has_css_class (Granite.CssClass.CARD)) {
add_css_class (Granite.CssClass.CARD);
} else if (has_css_class (Granite.CssClass.CARD)) {
remove_css_class (Granite.CssClass.CARD);
}
}
}

/**
* Constructs a new {@link Granite.Box}
*/
Expand Down
Loading