Bin/Box: add has_frame property - #1054
Open
danirabbit wants to merge 3 commits into
Open
danirabbit wants to merge 3 commits into
danirabbit wants to merge 3 commits into
Conversation
leolost2605
reviewed
Sep 19, 2026
leolost2605
left a comment
leolost2605
left a comment
Member
There was a problem hiding this comment.
What about just having a granite.card widget? Would scale a lot better
Member
Author
|
@leolost2605 im not sure because it's really just a visual effect and other widgets have a frame property so it seems in keeping with what is expected of GTK widgets? |
leolost2605
approved these changes
Sep 22, 2026
leolost2605
left a comment
leolost2605
left a comment
Member
There was a problem hiding this comment.
Hmm but GTK uses it for kind of standalone widgets where it always could make sense to have a frame (button, entry, etc.). They don't have it on every container widget, that's what Gtk.Frame is for.
Idk I'm not super opposed to this it just feels kinda weird.
Code LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1033