Repository navigation
feat: give the plugin a registry icon - #33
Merged
Merged
Conversation
The registry showed a letter placeholder: the manifest declared screenshots but no icon. images/icon.png (256x256, 8.6 KB) is rendered from images/icon.source.html in the banner's language: base-50 ground, faint ink waves, EmDash's gradient on a rising traffic line. It is declared under release.artifacts.icon, so it shows from the next published release on. Checked against EmDash 1.1.0, 1.2.0 and 1.3.0 with scripts/compat-matrix.sh: 314 of 314 tests pass on each, no code change needed. From 1.2.0 plugin:activate also fires for plugins: [] installs, so the comments that said it never does now name the version; the fallback scheduling stays for the 1.0.1 floor. The activate hook cannot throw, which matters because 1.2.0 disables a plugin whose activate hook throws. Patch changeset: 0.3.2.
🦋 Changeset detectedLatest commit: 0ad2f03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
danielmlr
added a commit
that referenced
this pull request
Oct 16, 2026
The icon from #33 read as a thin line on near-black and disappeared at the ~50 px the registry shows. Now a thick rising line in EmDash's gradient on Eisbachcode ink (#06070A), picked because it read best as a tiny icon on a phone. No changeset: 0.3.2 is not released and its changeset already describes the icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry showed a letter placeholder for Analytics: the manifest declared screenshots but no icon.
images/icon.png(256×256, 8.6 KB), rendered fromimages/icon.source.htmlin the banner's language: base-50 ground, faint ink waves, EmDash's gradient on a rising traffic line. Render command is in the source file.release.artifacts.icon. It's part of the release record, so it shows from the next published version (0.3.2) on.Compatibility with newest EmDash
scripts/compat-matrix.sh 1.1.0:0.2.7 1.2.0:0.2.8 1.3.0:0.2.9:Changelog items that touch this plugin, none needing a code change:
plugin:activatenow also fires forplugins: []installs, and a throwing activate hook disables the plugin. Ours catches everything (scheduleFromSettings→ensureScheduled). Comments that said it never fires now name the version; the fallback scheduling stays for the 1.0.1 floor.ctx.site.urlnow prefers the configuredsiteUrl;hostsdefaults from it, which is the more correct value.views30/views7paging.analytics__*.The floor stays
>=1.0.1; the toolchain pin stays on 1.0.1.Checks:
pnpm typecheck,pnpm test(validate + 314 tests),pnpm build,pnpm bundle. Not checked: the actual upload to the publisher PDS (emdash-plugin publishhas no dry run); that happens with the Version Packages release.