Repository navigation
chore: make this the analytics plugin's own repository - #27
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 0ee0b12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes this repository the analytics plugin's own: the plugin moves from
packages/analyticsto the root, and the two unreleased plugins leave. The repository will be renamed toeisbachcode/emdash-plugin-analytics; GitHub redirects the old address.Do not merge before the two new repositories exist and the rename is done (see the order below).
Changes
packages/analyticsmoves to the root, so GitHub's landing page and the registry's "View source" show the plugin's README.emdash-plugin release planfinds a plugin at the repository root (discoverPluginDirectoriesinpackages/plugin-cli/src/release-prepare.ts, emdash@1.0.1), soemdash-release.ymlneeds no change.packages/content-freshnessandpackages/content-link-checkmove toeisbachcode/emdash-plugin-content-freshnessandeisbachcode/emdash-plugin-content-link-check.packages/sharedgoes: analytics used onlyclampNumber(nowsrc/values.ts, with its tests) and the typePluginContentItem(now insrc/index/bootstrap.ts).repository,homepageandbugsinpackage.json,repoin the manifest (which the registry profile takes) and the README image URLs point to the new name.package.json(the plugin's, plus the Changesets scripts), oneAGENTS.md(the plugin's, plus what applies from the old workspace file),.claude/CLAUDE.mdas the only link to it;pnpm-workspace.yamlkeeps its settings without a package list.pnpm test;scripts/compat-matrix.shruns the one suite at the root.Verified
pnpm install,pnpm typecheck,pnpm build: pass.pnpm test: 314 passed (the 312 before, plus the twoclampNumbertests from the shared package).emdash-plugin bundle: finds the plugin at the root; the bundle holdsbackend.js,manifest.jsonandREADME.md(131.5 KB), not the banner.scripts/compat-matrix.sh --no-baseline 1.0.1:0.2.6: 314 passed.Order
mainat1dea814).emdash-plugin-analytics(Settings → General).emdash-plugin-analytics(workflowrelease.yml, environmentnpm).pnpm exec emdash-plugin profile setup --provenance optional -yin a checkout ofmain.