-
Notifications
You must be signed in to change notification settings - Fork 16
Update Proto submodule and GH actions #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,13 +30,13 @@ jobs: | |
| outputs: | ||
| project-version: ${{ steps.version.outputs.PROJECT_VERSION }} | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the reason to use a specific hash instead of the more loose tagging? In general, I welcome using the direct hashes instead of the tag approach as the tag may change later. So we could decide to use the hash for the references in all actions. What confuses me though was the mix of the two approaches here.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not "my action" but I think some Eclipse people. And they like hashes (I don't), but I kept the style here |
||
| with: | ||
| persist-credentials: false | ||
| fetch-depth: 0 | ||
| ref: ${{ github.event.inputs.version }} | ||
|
|
||
| - uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0 | ||
| - uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0 | ||
| with: | ||
| python-version: ${{ env.PYTHON_VERSION }} | ||
|
|
||
|
|
@@ -63,7 +63,7 @@ jobs: | |
| run: cyclonedx-py requirements ${{ env.PRODUCT_PATH }}/requirements.txt -o bom.json | ||
|
|
||
| - name: Upload sbom | ||
| uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0 | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| name: sbom | ||
| path: bom.json | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,7 +27,7 @@ RUN pip install --no-cache-dir dist/*.whl | |
| WORKDIR / | ||
| RUN rm -rf dist | ||
| # Letting pyinstaller collect everything that is required | ||
| RUN pyinstaller --collect-data kuksa_client --add-data=/kuksa-python-sdk/kuksa-client/kuksa:kuksa --add-data=/kuksa-python-sdk/kuksa-client/sdv:sdv --clean -s /usr/local/bin/kuksa-client | ||
| RUN pyinstaller --collect-data kuksa_client --add-data=/kuksa-python-sdk/kuksa-client/kuksa:kuksa --clean -s /usr/local/bin/kuksa-client | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just to understand this essentially means that you are dropping support for the sdv api within the kuksa-client in this Dockerfile?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually.... I found it never really had sdv API support (only val.v1 and later val.v2) except it just shipped the generated proto files, so theoretically you could use them yourself when importing the package. As those proto files do not exist anymore, I removed all references as well |
||
|
|
||
|
|
||
| # Debian 13 is trixie, so the glibc version matches. Distroless is a lot smaller than | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| include *.py | ||
| recursive-include kuksa *.py | ||
| recursive-include sdv *.py | ||
| global-exclude *.pyc | ||
| global-exclude protobuild.py | ||
| global-exclude prototagandcopy.py |
| +11 −0 | kuksa/val/v1/README.md | |
| +0 −0 | kuksa/val/v1/types.proto | |
| +277 −0 | kuksa/val/v1/v1.md | |
| +0 −0 | kuksa/val/v1/val.proto | |
| +11 −0 | kuksa/val/v2/README.md | |
| +25 −0 | kuksa/val/v2/types.proto | |
| +712 −0 | kuksa/val/v2/v2.md | |
| +108 −18 | kuksa/val/v2/val.proto | |
| +0 −6 | proto/kuksa/val/v1/README.md | |
| +0 −7 | proto/kuksa/val/v2/README.md | |
| +0 −8 | proto/sdv/databroker/v1/README.md | |
| +0 −96 | proto/sdv/databroker/v1/broker.proto | |
| +0 −97 | proto/sdv/databroker/v1/collector.proto | |
| +0 −184 | proto/sdv/databroker/v1/types.proto |
Uh oh!
There was an error while loading. Please reload this page.