Update Proto submodule and GH actions - #63
Conversation
Signed-off-by: Sebastian Schildt <sebastian.schildt@hs-heilbronn.de>
Signed-off-by: Sebastian Schildt <sebastian.schildt@hs-heilbronn.de>
f04c515 to
8c37457
Compare
| project-version: ${{ steps.version.outputs.PROJECT_VERSION }} | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 |
There was a problem hiding this comment.
What is the reason to use a specific hash instead of the more loose tagging?
In general, I welcome using the direct hashes instead of the tag approach as the tag may change later. So we could decide to use the hash for the references in all actions. What confuses me though was the mix of the two approaches here.
There was a problem hiding this comment.
This is not "my action" but I think some Eclipse people. And they like hashes (I don't), but I kept the style here
| RUN rm -rf dist | ||
| # Letting pyinstaller collect everything that is required | ||
| RUN pyinstaller --collect-data kuksa_client --add-data=/kuksa-python-sdk/kuksa-client/kuksa:kuksa --add-data=/kuksa-python-sdk/kuksa-client/sdv:sdv --clean -s /usr/local/bin/kuksa-client | ||
| RUN pyinstaller --collect-data kuksa_client --add-data=/kuksa-python-sdk/kuksa-client/kuksa:kuksa --clean -s /usr/local/bin/kuksa-client |
There was a problem hiding this comment.
Just to understand this essentially means that you are dropping support for the sdv api within the kuksa-client in this Dockerfile?
There was a problem hiding this comment.
Actually.... I found it never really had sdv API support (only val.v1 and later val.v2) except it just shipped the generated proto files, so theoretically you could use them yourself when importing the package. As those proto files do not exist anymore, I removed all references as well
eriksven
left a comment
eriksven
left a comment
There was a problem hiding this comment.
LGTM, and we could merge as is from my point of view.
However, it would be great if we could align on how we reference external actions such as actions/checkout (either through tag or hash). I slightly lean towards the hash-based approach.
I am leaving this PR open to leave the decision whether you want to deal with referencing as part of this PR or whether we leave this to later PR.
|
Thanks for reviewing. Actually I prefer tags, easier to handle for human without setting up yet another automation or having more people on this project. The one exception with hashes was an action by someone who had equally strong opinion, so I kept that style.... |
2 participants
Some housekeeping tasks
Tested locally and tested container created by CI run