-
Notifications
You must be signed in to change notification settings - Fork 2
refactor: extract Jakarta EE to separate module #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ronjaquensel
merged 6 commits into
eclipse-dataplane-core:main
from
FraunhoferISST:refactor/53-extract-jersey
Jun 9, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
42860e6
chore: separate modules
ronjaquensel b5416e8
refactor: move controllers and tests
ronjaquensel 6fa0713
chore: re-add constants from Jakarta
ronjaquensel 0ad9059
chore: move config to subprojects
ronjaquensel e5b08a8
refactor: move auth to dataplane
ronjaquensel 50b9ff7
chore: PR remarks
ronjaquensel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /* | ||
| * Copyright (c) 2026 Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V. | ||
| * | ||
| * This program and the accompanying materials are made available under the | ||
| * terms of the Apache License, Version 2.0 which is available at | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * Contributors: | ||
| * Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V. - initial API and implementation | ||
| * | ||
| */ | ||
|
|
||
| plugins { | ||
| `java-library` | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation(libs.jackson.databind) | ||
| implementation(libs.nimbus.jwt) | ||
|
|
||
| compileOnly(libs.jakarta.rsApi) | ||
|
|
||
| testImplementation(platform(libs.junit.bom)) | ||
| testImplementation(libs.junit.jupiter) | ||
| testRuntimeOnly(libs.junit.launcher) | ||
| testImplementation(libs.restAssured) | ||
| testImplementation(libs.assertJ) | ||
| testImplementation(libs.awaitility) | ||
|
|
||
| testImplementation(libs.mockito.core) | ||
| testImplementation(libs.slf4j.simple) | ||
|
|
||
| testImplementation(libs.testcontainers.junit.jupiter) | ||
| testImplementation(libs.testcontainers.postgresql) | ||
| testImplementation(libs.postgresql) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
23 changes: 23 additions & 0 deletions
23
...ne-sdk-core/src/main/java/org/eclipse/dataplane/port/exception/UnauthorizedException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * Copyright (c) 2026 Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V. | ||
| * | ||
| * This program and the accompanying materials are made available under the | ||
| * terms of the Apache License, Version 2.0 which is available at | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * Contributors: | ||
| * Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V. - initial API and implementation | ||
| * | ||
| */ | ||
|
|
||
| package org.eclipse.dataplane.port.exception; | ||
|
|
||
| public class UnauthorizedException extends RuntimeException { | ||
|
|
||
| public UnauthorizedException(String message) { | ||
| super(message); | ||
| } | ||
|
|
||
| } |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * Copyright (c) 2026 Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V. | ||
| * | ||
| * This program and the accompanying materials are made available under the | ||
| * terms of the Apache License, Version 2.0 which is available at | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * Contributors: | ||
| * Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V. - initial API and implementation | ||
| * | ||
| */ | ||
|
|
||
| plugins { | ||
| `java-library` | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation(project(":dataplane-sdk-core")) | ||
|
|
||
| implementation(libs.jakarta.rsApi) | ||
| } |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this module should be excluded from the publication |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * Copyright (c) 2026 Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V. | ||
| * | ||
| * This program and the accompanying materials are made available under the | ||
| * terms of the Apache License, Version 2.0 which is available at | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * Contributors: | ||
| * Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e.V. - initial API and implementation | ||
| * | ||
| */ | ||
|
|
||
| plugins { | ||
| `java-library` | ||
| } | ||
|
|
||
| dependencies { | ||
| testImplementation(project(":dataplane-sdk-core")) | ||
| testImplementation(project(":dataplane-sdk-jakarta-ee")) | ||
|
|
||
| testImplementation(libs.nimbus.jwt) | ||
|
|
||
| testImplementation(platform(libs.junit.bom)) | ||
| testImplementation(libs.junit.jupiter) | ||
| testRuntimeOnly(libs.junit.launcher) | ||
| testImplementation(libs.restAssured) | ||
| testImplementation(libs.assertJ) | ||
| testImplementation(libs.awaitility) | ||
|
|
||
| testImplementation(libs.jakarta.rsApi) | ||
| testImplementation(libs.jersey.servlet) | ||
| testImplementation(libs.jersey.hk2) | ||
| testImplementation(libs.jersey.jackson) | ||
| testImplementation(libs.jetty.ee10.servlet) | ||
| testImplementation(libs.jetty.server) | ||
| testImplementation(libs.wiremock.jetty12) | ||
| } | ||
|
|
||
| tasks.withType<PublishToMavenRepository>().configureEach { | ||
| enabled = false | ||
| } | ||
|
|
||
| tasks.withType<PublishToMavenLocal>().configureEach { | ||
| enabled = false | ||
| } |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as for now, this package will be published with this groupId/artifactId:
org.eclipse.dataplane-core:core, maybe it would be better to call itsdkordataplane-sdkto make itorg.eclipse.dataplane-core:dataplane-sdk, as there could be something more in the future (see in the "rust" world there are also "facet" and "siglet")we could keep a convention like:
org.eclipse.dataplane-core:dataplane-sdkorg.eclipse.dataplane-core:dataplane-sdk-jakarta-eeand so on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! I'm so used to it from EDC that I completely missed that 😄 adjusted it. I opted for
dataplane-sdk-coreinstead of justdataplane-sdk, as with just the core module it would be missing the controllers anddataplane-sdkcould sound like it's complete