Skip to content

refactor: extract Jakarta EE to separate module#89

Merged
ronjaquensel merged 6 commits into
eclipse-dataplane-core:mainfrom
FraunhoferISST:refactor/53-extract-jersey
Jun 9, 2026
Merged

refactor: extract Jakarta EE to separate module#89
ronjaquensel merged 6 commits into
eclipse-dataplane-core:mainfrom
FraunhoferISST:refactor/53-extract-jersey

Conversation

@ronjaquensel

@ronjaquensel ronjaquensel commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Splits the code into different modules to allow using other controller/web technologies (like e.g. Spring). The code is split into the following modules:

  • core: contains dataplane, logic interfaces, stores and model classes
  • web-jakarta-ee: contains the existing controllers (based on Jakarta EE API)
  • e2e-tests: contains all tests using the API

In a subsequent PR, the Postgres stores could also be extracted to a separate module.

Additional notes

  • method for extracting the control plane id from the auth header has been moved from the controller to the Dataplane class, as this holds the Authorizations anyway and thus makes the logic available for other controller implementations
  • the methods returning the controllers have been removed from the Dataplane class, as they were only used in tests and coupled the dataplane to the specific controller implementation. Controllers are now instantiated separately

Closes #53

@ronjaquensel ronjaquensel requested a review from ndr-brt June 8, 2026 13:27
@ronjaquensel ronjaquensel self-assigned this Jun 8, 2026
@ronjaquensel ronjaquensel added the enhancement New feature or request label Jun 8, 2026
@@ -0,0 +1,38 @@
/*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as for now, this package will be published with this groupId/artifactId:
org.eclipse.dataplane-core:core, maybe it would be better to call it sdk or dataplane-sdk to make it org.eclipse.dataplane-core:dataplane-sdk, as there could be something more in the future (see in the "rust" world there are also "facet" and "siglet")

we could keep a convention like:

  • org.eclipse.dataplane-core:dataplane-sdk
  • org.eclipse.dataplane-core:dataplane-sdk-jakarta-ee

and so on

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I'm so used to it from EDC that I completely missed that 😄 adjusted it. I opted for dataplane-sdk-core instead of just dataplane-sdk, as with just the core module it would be missing the controllers and dataplane-sdk could sound like it's complete

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this module should be excluded from the publication

@ronjaquensel ronjaquensel requested a review from ndr-brt June 9, 2026 09:06
@ronjaquensel ronjaquensel merged commit 4ac07e2 into eclipse-dataplane-core:main Jun 9, 2026
3 checks passed
@ronjaquensel ronjaquensel deleted the refactor/53-extract-jersey branch June 9, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract Jersey to separate module

2 participants