refactor: extract Jakarta EE to separate module#89
Conversation
| @@ -0,0 +1,38 @@ | |||
| /* | |||
There was a problem hiding this comment.
as for now, this package will be published with this groupId/artifactId:
org.eclipse.dataplane-core:core, maybe it would be better to call it sdk or dataplane-sdk to make it org.eclipse.dataplane-core:dataplane-sdk, as there could be something more in the future (see in the "rust" world there are also "facet" and "siglet")
we could keep a convention like:
org.eclipse.dataplane-core:dataplane-sdkorg.eclipse.dataplane-core:dataplane-sdk-jakarta-ee
and so on
There was a problem hiding this comment.
good catch! I'm so used to it from EDC that I completely missed that 😄 adjusted it. I opted for dataplane-sdk-core instead of just dataplane-sdk, as with just the core module it would be missing the controllers and dataplane-sdk could sound like it's complete
There was a problem hiding this comment.
this module should be excluded from the publication
Splits the code into different modules to allow using other controller/web technologies (like e.g. Spring). The code is split into the following modules:
core: contains dataplane, logic interfaces, stores and model classesweb-jakarta-ee: contains the existing controllers (based on Jakarta EE API)e2e-tests: contains all tests using the APIIn a subsequent PR, the Postgres stores could also be extracted to a separate module.
Additional notes
Dataplaneclass, as this holds theAuthorizations anyway and thus makes the logic available for other controller implementationsDataplaneclass, as they were only used in tests and coupled the dataplane to the specific controller implementation. Controllers are now instantiated separatelyCloses #53