Skip to content

feat!: drop the inline-edit content routes; contribute the bar's admin buttons; webhooks follow page events; typed keys - #21

Closed
zumbrunn wants to merge 4 commits into
feat/capabilitiesfrom
feat/own-bar-actions
Closed

zumbrunn wants to merge 4 commits into
feat/capabilitiesfrom
feat/own-bar-actions

Conversation

@zumbrunn

@zumbrunn zumbrunn commented Nov 8, 2026

Copy link
Copy Markdown
Member

Part of duneorg/dune#127 (slice 2). Stacked on #20. /admin/api/content/* moves to plugin-inline-edit. The admin contributes Edit source and Open in admin to the bar's bar.actions point, content webhooks listen to the page events (any writer), and the extension points are exported as typed keys ADMIN_PAGES, ADMIN_ROUTES, ADMIN_EDITOR.

Known and not in this PR: deno publish --dry-run still fails on adminPluginFactory (TS2652, a default export merged with property assignments), which predates this work and gets its own PR.

🤖 Generated with Claude Code

zumbrunn and others added 4 commits November 7, 2026 19:36
…n.routes, admin.editor) (#127)

The registration types leave core's contract and live here; the keys are
declared by declaration merging. editor.content is renamed admin.editor.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…n buttons; webhooks follow page events (duneorg/dune#127)

The source/commit/fields routes moved to @dune/plugin-inline-edit
(/api/inline-edit/content/*), so /admin/api/content/* is gone. The admin now
contributes its own buttons to the bar's `bar.actions` point (edit source in an
overlay, open in admin) instead of the bar hard-coding them.

Content webhooks are a listener on the page events (onPageCreate, onPageUpdate,
onPageDelete, onPageMove, onWorkflowChange), so writes from any writer reach
them, not only admin routes. announcePageEvent names the signed-in user as
`actor`.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…127)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ugmentation (duneorg/dune#127)

JSR rejects 'declare module' in a published package.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@zumbrunn

Copy link
Copy Markdown
Member Author

Landed in 4.0.0 as part of #26 (one squash of the whole stack: its intermediate commits only type-check against the final contract). Verified against the published @dune/core 0.36.0 and @dune/testing 2.0.0.

@zumbrunn zumbrunn closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant