Skip to content

feat: declare admin.pages, admin.routes and admin.editor as the admin's own extension points - #20

Closed
zumbrunn wants to merge 1 commit into
feat/capabilitiesfrom
feat/own-contributions
Closed

zumbrunn wants to merge 1 commit into
feat/capabilitiesfrom
feat/own-contributions

Conversation

@zumbrunn

@zumbrunn zumbrunn commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Update: extension points are no longer declared by declare module augmentation (JSR rejects it in a published package). They are typed CapabilityKey<T> tokens instead; wherever this description says "declaration merging", read "typed key". Done in the slice-2 PR stacked on this one.

Part of duneorg/dune#127. Stacked on #17; pairs with the core contract-split PR.

Adds @dune/plugin-admin/contributions with the three contribution types and a declare module merge for admin.editor (renamed from editor.content), admin.pages, admin.routes.

🤖 Generated with Claude Code

…n.routes, admin.editor) (#127)

The registration types leave core's contract and live here; the keys are
declared by declaration merging. editor.content is renamed admin.editor.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@zumbrunn

Copy link
Copy Markdown
Member Author

Closing: this version declared the extension points with declare module, which JSR rejects (no-slow-types: ambient module). #21, stacked on this branch, replaces it with typed capability keys, so it is retargeted to feat/capabilities and review sees the typed-key version once. The branch feat/own-contributions is kept; nothing is lost.

@zumbrunn zumbrunn closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant