Repository navigation
chore: 🧑💻 skip raw tasks if API key is empty #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bc0cfd6
chore: ♻️ add env example file
lwjohnst86 5e8e25f
Merge branch 'main' into chore/load-env-example-last
lwjohnst86 67cbc49
chore: 🧑💻 skip raw tasks if API key is empty
lwjohnst86 1755c32
chore: ✏️ automatic pre-commit hook fixes
pre-commit-ci[bot] 983dba5
chore: 🧑💻 skip raw tasks if API key is empty
lwjohnst86 0a16217
chore: ✏️ automatic pre-commit hook fixes
pre-commit-ci[bot] 5dfb4e0
Merge branch 'chore/skip-if-no-api-key' of https://github.com/dp-next…
lwjohnst86 6dc92a0
revert: ⏪️ use Optional, fixed from pre-commit change
lwjohnst86 0cd43b4
chore: edits from review
lwjohnst86 add994c
chore: ✏️ automatic pre-commit hook fixes
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it the intention to make the
metadatatasks run without the download step? If I runuv run pytask build -m metadatait will skip all tasks now because -- I think -- it still can't see that this first dependency is satisfied (rather, the file's existence doesn't mean that the dependency is satisfied). Or is it working for you?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I hadn't noticed that it wasn't working for me, but I wasn't specifically checking how you describe it. It might need a
@mark.persisttag...?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I played around with it a bit and I think
@mark.persistmight actually be better than skip here. At least, with just@mark.persistit skips the download task but runs the processing tasks.Then there is also the older idea of having the download task in a separate pipeline with no pytask dependency between the download step and the other steps.