Skip to content

chore: 🧑‍💻 skip raw tasks if API key is empty - #107

Open
lwjohnst86 wants to merge 10 commits into
chore/load-env-example-lastfrom
chore/skip-if-no-api-key
Open

lwjohnst86 wants to merge 10 commits into
chore/load-env-example-lastfrom
chore/skip-if-no-api-key

Conversation

@lwjohnst86

Copy link
Copy Markdown
Member

Description

To make local development easier.

Needs a quick review.

Checklist

  • Ran just run-all
  • (When relevant) Ran just build-package

@lwjohnst86
lwjohnst86 added this pull request to stack #108 September 27, 2026 15:47
@lwjohnst86
lwjohnst86 force-pushed the chore/skip-if-no-api-key branch from 1755c32 to 0a16217 Compare September 27, 2026 15:48
Comment thread src/questionnaire_data/common/redcap.py Outdated
Comment thread src/questionnaire_data/common/redcap.py Outdated
Comment thread src/questionnaire_data/build.py Outdated


@mark.metadata
@mark.skipif(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it the intention to make the metadata tasks run without the download step? If I run uv run pytask build -m metadata it will skip all tasks now because -- I think -- it still can't see that this first dependency is satisfied (rather, the file's existence doesn't mean that the dependency is satisfied). Or is it working for you?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I hadn't noticed that it wasn't working for me, but I wasn't specifically checking how you describe it. It might need a @mark.persist tag...?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I played around with it a bit and I think @mark.persist might actually be better than skip here. At least, with just @mark.persist it skips the download task but runs the processing tasks.

Then there is also the older idea of having the download task in a separate pipeline with no pytask dependency between the download step and the other steps.

lwjohnst86 and others added 2 commits September 28, 2026 10:36
Co-authored-by: martonvago <57952344+martonvago@users.noreply.github.com>
@fruvago fruvago mentioned this pull request Sep 28, 2026
1 of 2 tasks

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants