Repository navigation
Bound spline projection patches in a frame on each direction (ENG-3833) - #30
Merged
Merged
Conversation
Projecting a point onto a spline surface refines Bezier patches until none can be closer than the incumbent. One lower bound measures each patch in the frame (normal, S_u, normal x S_u). When S_v is oblique to S_u, a long, thin patch extends along S_u by its length times the skew, not by its width, and the bound misses the offset of a point beside it. RFPC-SMA16-FN-A has a spline face with a knot span 2e-4 mm wide next to spans 2.6 mm long, with S_v 3.8% oblique. Its patches across the thin span could not be told apart, so each split of the span doubled the live patches: some boundary points examined 50,000 patches, and two faces took 1.6 s and 1 s on one core. The patch is now also bounded in the frame (normal, S_v, normal x S_v), and the larger bound is kept. Both are valid bounds, so the search returns the same minimum to within roundoff. RFPC-SMA16-FN-A now takes 0.3 s instead of 1.8 s.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Not approved. This is a functional spline-projection change rather than a small fixup, so human review is needed and no reviewers were assigned. Cursor Security Agent completed with no findings; Cursor Bugbot was not running.
Sent by Cursor Approval Agent: Pull Request Router and Approver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spline projection now bounds each Bezier patch in a frame on each parameter direction, not only on u. With one frame, thin oblique patches next to a sliver knot span stay unpruned. RFPC-SMA16-FN-A now takes 0.3 s instead of 1.7 s, and corpus output changes on 1 of 1,004 models with the same triangles, failed faces and error check. Part of ENG-3833.