Skip to content

Reduce NURBS projection cost - #20

Closed
akhilles wants to merge 1 commit into
masterfrom
perf/nurbs-projection-refinement
Closed

akhilles wants to merge 1 commit into
masterfrom
perf/nurbs-projection-refinement

Conversation

@akhilles

@akhilles akhilles commented Sep 11, 2026 •

Copy link
Copy Markdown

I see a ~5x to ~6x improvement on complicated boards.

@akhilles
akhilles requested a review from LK September 11, 2026 21:56

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approved: this changes NURBS projection/subdivision behavior and is not a small fixup, so it still needs human review. Cursor Security Agent completed with no findings; Bugbot was not running. Reviewers were not assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

Copy link
Copy Markdown
Author

Closing as superseded. Since this PR, #22, #26, #29 and #30 reworked NURBS projection: #30 fixed the patch bound that made a few faces slow, and #29 projects boundary points in parallel. This PR now conflicts with those changes.

@akhilles akhilles closed this Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants