Repository navigation
Conversation
Faceted STEP models from mesh converters (gltf2step, the Diode registry's iges2facetstep) bound every face with a POLY_LOOP, which failed as an invalid bound. Emit triangles as they are and triangulate larger polygons, with holes, in the plane, with normals from the plane and same_sense. Fixes ENG-3787.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Left a non-blocking comment: this is a functional meshing change, not a small fixup, so it is not approved. Cursor Security Agent completed with no findings; Cursor Bugbot was not present. Human review is needed and no reviewers were assigned.
Sent by Cursor Approval Agent: Pull Request Router and Approver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes foxtrot mesh faceted STEP models, where each face is a plane bounded by a POLY_LOOP. Foxtrot emits each triangle as it is and triangulates larger polygons and their holes in the plane. Before this change, it failed every face of these models. In the corpus, the 50 POLY_LOOP models now mesh with 0 failed faces, and the other 897 meshes are the same as on master.
Fixes ENG-3787.