Skip to content

chore: remove retired and duplicate dev tooling - #955

Merged
devswha merged 1 commit into
devfrom
bot/remove-dead-dev-tools
Sep 26, 2026
Merged

devswha merged 1 commit into
devfrom
bot/remove-dead-dev-tools

Conversation

@devswha

@devswha devswha commented Sep 26, 2026

Copy link
Copy Markdown
Owner

Summary

Removes dev and research tooling that is retired, orphaned, or duplicated elsewhere. None of it ships in the npm package; the product runtime, CLI, API, detection and scoring are untouched. Policy: docs/WORKFLOW.md

No Issue: part of the owner-requested 2026-09-26 dead-feature sweep; dev-tooling only.

Removed Why
scripts/katfish-calibration.mjs + test, benchmark:katfish-ko docs/benchmarks/README.md already marks the KatFish report frozen and its regeneration retired (unlicensed private inputs).
scripts/qa/pattern-overlap.js + test + tests/fixtures/pattern-overlap/ No npm script and no doc; its .sh wrapper was already removed in #937.
scripts/qa/mdx-score.mjs + test, qa:mdx oh-my-docs loop tool; #340 and #398 are closed. flooredScore stays because patina-score rows carry it.
scripts/badge-json.mjs + test, npm run badge Duplicates devswha/patina-action's badge payload (same bands and message format) and has not shipped in the npm package since 9.0.0. COOKBOOK now describes the Action's badge-branch output.
scripts/rewrite-ab.mjs, scripts/iterative-rewrite-baseline.mjs + tests, quality:rewrite-ab Parked for H-4a with no open Issue. Both are intact at 9108a63 if H-4a starts.

Docs follow: docs/HARNESS.md (map rows and diagram, whose line (4) also fits its box again), docs/QA.md, docs/ARCHITECTURE.md and scripts/check-architecture.mjs (research-module list), docs/COOKBOOK.md, tests/quality/README.md, artifacts/rebaseline-2025/README.md.

Left as historical records on purpose: the dated 2026-05-22 KatFish calibration note in core/stylometry.md, docs/research/**, and the adversarial-mps-report.mjs guidance line that generates the committed docs/research/adversarial-mps.md.

Scope and risk

  • Contract impact: dev-only npm scripts benchmark:katfish-ko, qa:mdx, badge, quality:rewrite-ab are gone. scripts/** is not a compatibility promise (docs/ARCHITECTURE.md), and none of these files are in the npm tarball.
  • Not changed: runtime src/, bin/, api/, the skill, prompts, detection, scoring, benchmark figures.
  • Size: 23 files, +12 / −3656; whole-file deletions carry almost all of it.

Verification

  • npm test → 0 (2083 tests: 2082 pass, 1 skipped, 0 fail)
  • npm run lint → 0 (architecture: 110 modules, 363 edges, 0 violations; unchanged, since none of these files are in the runtime graph)
  • npm run release:check, npm run check:no-private-assets, npm run dogfood, git diff --check → 0
  • Base: origin/dev 9108a63.

Release and rollback

  • Semver impact: none (dev tooling only).
  • Rollback: revert the squash commit.

Removes katfish-calibration (its regeneration was already retired),
qa/pattern-overlap (no entry point or doc), qa/mdx-score (oh-my-docs
loop closed), badge-json (duplicates patina-action's badge payload),
and rewrite-ab with iterative-rewrite-baseline (parked for H-4a with no
open issue; both are intact at 9108a63). None of them ship in the npm
package.
@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
patina Ready Ready Preview Sep 26, 2026 8:12am UTC

Request Review

@devswha

devswha commented Sep 26, 2026

Copy link
Copy Markdown
Owner Author

Independent review (read-only, one pass): APPROVE

Reviewer: separate read-only gate-review agent (did not write the change).

  • No blocker, major, or minor findings.
  • Nits, both intentional: the dated 2026-05-22 KatFish note in core/stylometry.md:220 still names the retired command (kept as a historical record in skill prompt text), and scripts/adversarial-mps-report.mjs:161 keeps "iterative-baseline selection" because changing it would mean regenerating the committed docs/research/adversarial-mps.md.

Verified by the reviewer: no remaining references outside historical records, CI workflows, or configs; no runtime change (flooredScore is still produced and exposed); check-architecture 110 modules / 0 violations; prose-score tests 20/20; quality:adversarial-mps 10/10; HARNESS diagram lines all 80 columns (fixes the 83-column overflow on dev); the COOKBOOK badge text matches patina-action's scripts/score.mjs payload. CI: all checks green.

@devswha
devswha marked this pull request as ready for review September 26, 2026 08:16
@devswha
devswha merged commit f980d06 into dev Sep 26, 2026
8 checks passed
@devswha
devswha deleted the bot/remove-dead-dev-tools branch September 26, 2026 08:16

This branch was successfully deployed

1 active deployment
Preview — 421f53a5 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant