Repository navigation
feat!: remove the kimi-cli backend - #954
Merged
Merged
Conversation
Kimi Code takes the prose as a --prompt argv value that other local users can read from the process list, which is why the skill helper already refused it. `--backend kimi-cli` is now an unknown backend (exit 2) and `--model kimi-*` stays on openai-http. The Kimi/Moonshot HTTP presets and the hosted kimi provider stay; the research harness drops its kimi transport with the backend.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Review follow-up for #954: the English and Korean FAQ still offered a logged-in Kimi CLI as an API-key alternative. Also renames a sample backend error in batch.test.js.
Owner
Author
Independent review (read-only, one pass): APPROVE (after one fix round)Reviewer: separate read-only gate-review agent (did not write the change).
Verified by the reviewer: HTTP |
devswha
marked this pull request as ready for review
September 26, 2026 08:18
This was referenced Sep 26, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
kimi-clibackend. Kimi Code takes the prose as a--promptargv value that other local users can read from the process list, which is why the skill helper already refused it (backend_argv_exposes_input). The Kimi/Moonshot HTTP presets (--provider kimi|moonshot) and the hostedkimiprovider stay. Policy:docs/WORKFLOW.mdNo Issue: part of the owner-requested 2026-09-26 dead-feature sweep (Tier 2 "kimi-cli backend").
src/backends/kimi-cli.js,scripts/research/kimi-study-transport.mjs,tests/unit/kimi-study-transport.test.js,tests/unit/kimi-isolation.test.js.--model kimi-*), batch safety entry, default model, help text, skill-helper guard andSKILL.mdsentence, AUTHENTICATION (+KR), CLI.md, FLAG-PARITY.md,.env.example, live-quality help text.model-evaluation-transport.mjs, the kimi-onlyprofileIdentityVerifiedpath instudy-journal.mjs(acceptedStudyIdentitynow takes the call only), and thestudySemanticsfile list.Scope and risk
--backend kimi-clinow exits 2 (Unknown backend: kimi-cli);--model kimi-*no longer routes to a local CLI and stays onopenai-http;patina auth login kimi-cliis gone.--provider kimi/--provider moonshot,KIMI_API_KEY/MOONSHOT_API_KEYfor those presets, the hosted kimi provider, detection, scoring, prompts.docs/researchare unchanged.scripts/rewrite-ab.mjskeeps a string-onlykimi-clijudge-family mapping; the dev-tools PR deletes that file.Verification
kimi-cliis an unknown backend, the fallback hint lists five backends) failed on the unmodified tree (3 fail) and pass after the change.npm test→ 0 (2120 tests: 2119 pass, 1 skipped, 0 fail)npm run lint→ 0 (architecture: 109 modules, 357 edges, 0 violations)npm run release:check,npm run check:no-private-assets,npm run dogfood,git diff --check→ 0echo … | node bin/patina.js --backend kimi-cli --lang en→ exit 2 listing the five remaining backends;--list-backendshas no kimi row.origin/dev9108a63.Release and rollback