Skip to content

fix(operator): satisfy current Go lint - #8

Open
sttts wants to merge 5 commits into
devivasudevan:dgdr-request-controllerfrom
sttts:sttts-dgh-1426-dgdr-request-controller-lint
Open

sttts wants to merge 5 commits into
devivasudevan:dgdr-request-controllerfrom
sttts:sttts-dgh-1426-dgdr-request-controller-lint

Conversation

@sttts

@sttts sttts commented Oct 27, 2026 •

Copy link
Copy Markdown

Summary

Follow-up to ai-dynamo#17097 that changes supersession from deleting the immutable Run to canceling only its execution:

  • when a newer Request generation arrives, write nvidia.com/dgdr-cancel-requested-by-generation onto the active non-terminal Run;
  • retain the Run and wait for its authoritative Completed condition before creating the newest generation;
  • keep the cancellation generation monotonic across coalesced Request updates and repair malformed, nonpositive, or stale marker values;
  • grant the Request controller patch on Runs and regenerate the operator Role;
  • preserve terminal Run references and Candidate history instead of losing them with the superseded Run object.

The Run controller side is implemented in ai-dynamo#17195: it accepts the marker only when its parsed generation is strictly newer than the Run's immutable Request-generation annotation, deletes the execution Job, and terminalizes the retained Run as Completed=True, reason=Superseded.

Refs DGH-1426 and ai-dynamo#17097.

Compatibility

This does not add a typed Kubernetes API field. The annotation is controller-owned causal intent. Invalid, equal, and older values never stop a Run; only a strictly newer generation does. An unchanged Request may continue running indefinitely.

Validation

  • KUBEBUILDER_ASSETS=... go test ./internal/controller -run 'TestV1beta2Request|TestDGDRV1beta2Controller' -count=1: passed (10.739s)
  • focused tables cover malformed, zero, negative, stale, equal, and newer cancellation generations
  • repository pre-commit hooks: passed

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added 2 commits October 28, 2026 18:06
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to sttts/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to sttts/dynamo that referenced this pull request Oct 28, 2026
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
…an#8]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 29, 2026
]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant