Repository navigation
Conversation
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
1 of 5 tasks
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 26, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 26, 2026
…: pr-4] Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 26, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 26, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com> (cherry picked from commit 9ed993fc070f33cb91e84364bd3e97b75869db4b)
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 27, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 27, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 27, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 27, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 27, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 27, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 27, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Upstreamed through devivasudevan#4. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to ai-dynamo#16661.
This change makes AISimulate execution operator-owned and aligns the typed v1beta2 workload with the public AISimulate recommendation input:
spec.aisimulate.imageandversionOverride, their admission defaults, Helm/CLI flags, and image-to-AISimulate version mapping;parameterstoinputOverrides;status.aisimulate.inputtoDynamoGraphDeploymentRunfor the exact effective input used by execution;internal/aisimulate;The operator and its configured Planner image form one tested release bundle. A DGDR cannot select a skewed Planner/AISimulate image or version. The Job reconciler consumes the Planner image directly from operator configuration instead of persisting it in Request or Run objects.
Refs DGH-1426.
API
The model-only form remains small:
Admission materializes its workload as:
loadhas no redundanttypediscriminator. Exactly one variant is required whenever the object exists:An explicitly empty static object is the defaulting opt-out:
Every other nonempty static object is completed by admission. For example:
becomes:
The typed API deliberately exposes no stop policy. Lowering supplies
traffic.stop.requests: 1000; advanced callers replace it through the public AISimulate input override:inputOverridesis an RFC 7386 JSON Merge Patch. It uses upstream AISimulate field names, is applied last, and wins over typed fields and derived defaults:A native KV-capacity range derives
optimizer.max_trials: 320; native SLA bounds deriveoptimization.strict_sla: true. Overrides may replace or delete either value, and defaults are not recalculated after the override.The immutable Run preserves the accepted typed search input. Its status exposes the exact effective document passed to AISimulate:
status.aisimulate.inputis controller-owned output, not another override surface.Validation and compatibility
Admission validates the typed Kubernetes API structurally, then verifies that the accepted typed fields can be lowered to the public recommendation input.
inputOverridesremains opaque. Validating the final effective input against JSON Schema generated from the bundled AISimulate Pydantic model is a separate ratcheting-validation follow-up.The v1beta2 API remains behind its pre-release feature gate, so the removed and renamed fields do not require persisted-object migration.
Validation
go test ./api/... ./internal/aisimulate ./internal/webhook/defaulting ./internal/webhook/validation -count=1make manifests generate-api-docsgit diff --check