Repository navigation
Conversation
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
marked this pull request as ready for review
October 26, 2026 10:40
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 26, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 26, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 27, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
1 of 5 tasks
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 27, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 27, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 27, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…evivasudevan#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to sttts/dynamo
that referenced
this pull request
Oct 28, 2026
…evivasudevan#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to sttts/dynamo
that referenced
this pull request
Oct 28, 2026
…stream: devivasudevan#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to sttts/dynamo
that referenced
this pull request
Oct 28, 2026
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to sttts/dynamo
that referenced
this pull request
Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to sttts/dynamo
that referenced
this pull request
Oct 28, 2026
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to sttts/dynamo
that referenced
this pull request
Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…evivasudevan#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to sttts/dynamo
that referenced
this pull request
Oct 28, 2026
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
…evivasudevan#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
force-pushed
the
sttts-dgh-2212-v1beta2-aggregate-budget
branch
from
October 28, 2026 19:17
a8644cf to
53ada5f
Compare
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…evivasudevan#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…evivasudevan#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…evivasudevan#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Squashed from devivasudevan#3. Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…evivasudevan#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 28, 2026
…van#3] Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v1beta2 DGDR admission path in ai-dynamo#16661 must default a budget that can actually be scheduled on the node shape selected by shared GPU discovery.
This change consumes
gpu.GPUInfo.SelectedShapeGPUsfrom the source fix in Pranjulcr7/dynamo#1, rather than using total same-SKU inventory. It updates every admission/defaulting fixture and covers the heterogeneous 8+4 case at both the resolver and complete API-server admission boundaries.For example, discovery of matching H200 nodes with 8 and 4 GPUs records inventory 12 but admission persists the executable selected-shape capacity:
The existing API semantics remain unchanged:
spec.hardware,gpu,sku, andbudgetremain optional;spec.hardware.gpu.budgetis authoritative and is never capped;Part of ai-dynamo#17192.
Depends on ai-dynamo#17262 plus Pranjulcr7/dynamo#1.
Stacked on ai-dynamo#16661.
Validation
Validated locally with the source fix from Pranjulcr7#1 applied as a temporary, uncommitted overlay:
go test ./internal/webhook/defaulting -count=1TestDynamoGraphDeploymentRequestValidator_Validateadmission tablegit diff --checkThis branch intentionally does not duplicate the shared discovery source change; it compiles directly once its declared dependency is present in the base stack.