Skip to content

fix(operator): use selected-shape GPU capacity for v1beta2 budget - #3

Open
sttts wants to merge 5 commits into
devivasudevan:dgdr-admission-v2from
sttts:sttts-dgh-2212-v1beta2-aggregate-budget
Open

sttts wants to merge 5 commits into
devivasudevan:dgdr-admission-v2from
sttts:sttts-dgh-2212-v1beta2-aggregate-budget

Conversation

@sttts

@sttts sttts commented Oct 26, 2026 •

Copy link
Copy Markdown

Summary

The v1beta2 DGDR admission path in ai-dynamo#16661 must default a budget that can actually be scheduled on the node shape selected by shared GPU discovery.

This change consumes gpu.GPUInfo.SelectedShapeGPUs from the source fix in Pranjulcr7/dynamo#1, rather than using total same-SKU inventory. It updates every admission/defaulting fixture and covers the heterogeneous 8+4 case at both the resolver and complete API-server admission boundaries.

For example, discovery of matching H200 nodes with 8 and 4 GPUs records inventory 12 but admission persists the executable selected-shape capacity:

apiVersion: nvidia.com/v1beta2
kind: DynamoGraphDeploymentRequest
spec:
  hardware:
    gpu:
      sku: h200_sxm # ADMISSION-DEFAULT from discovery when omitted
      budget: 8     # ADMISSION-DEFAULT from SelectedShapeGPUs when omitted

The existing API semantics remain unchanged:

  • spec.hardware, gpu, sku, and budget remain optional;
  • the automatic budget is capped at 32 after selected-shape aggregation;
  • an explicit spec.hardware.gpu.budget is authoritative and is never capped;
  • SKU filtering still happens in shared discovery;
  • total same-SKU inventory remains diagnostic and is not exposed as the default budget.

Part of ai-dynamo#17192.
Depends on ai-dynamo#17262 plus Pranjulcr7/dynamo#1.
Stacked on ai-dynamo#16661.

Validation

Validated locally with the source fix from Pranjulcr7#1 applied as a temporary, uncommitted overlay:

  • go test ./internal/webhook/defaulting -count=1
  • complete TestDynamoGraphDeploymentRequestValidator_Validate admission table
  • admission Envtest with the repository's Kubernetes assets (7.936s)
  • repository pre-commit hooks
  • git diff --check

This branch intentionally does not duplicate the shared discovery source change; it compiles directly once its declared dependency is present in the base stack.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
sttts marked this pull request as ready for review October 26, 2026 10:40
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 26, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 26, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 27, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 27, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 27, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 27, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…evivasudevan#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to sttts/dynamo that referenced this pull request Oct 28, 2026
…evivasudevan#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to sttts/dynamo that referenced this pull request Oct 28, 2026
…stream: devivasudevan#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to sttts/dynamo that referenced this pull request Oct 28, 2026
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to sttts/dynamo that referenced this pull request Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to sttts/dynamo that referenced this pull request Oct 28, 2026
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to sttts/dynamo that referenced this pull request Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…evivasudevan#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to sttts/dynamo that referenced this pull request Oct 28, 2026
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts sttts changed the title fix(operator): use aggregate GPU count for v1beta2 budget fix(operator): use selected-shape GPU capacity for v1beta2 budget Oct 28, 2026
sttts added 4 commits October 28, 2026 20:17
…evivasudevan#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@sttts
sttts force-pushed the sttts-dgh-2212-v1beta2-aggregate-budget branch from a8644cf to 53ada5f Compare October 28, 2026 19:17
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…evivasudevan#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…evivasudevan#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…evivasudevan#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Squashed from devivasudevan#3.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…evivasudevan#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
sttts added a commit to ai-dynamo/dynamo that referenced this pull request Oct 28, 2026
…van#3]

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant