Count LSP commands only when the file has a provider for them

apps/review-desktop/code-oss/src/vs/review/contrib/telemetry/reviewLspTelemetry.contribution.ts

@@ -116,7 +116,7 @@ class ReviewLspTelemetryContribution extends Disposable implements IWorkbenchCon
 			}
 			const editor = this.activeEditor();
 			const model = editor?.getModel();
-			if (!editor || !model) {
+			if (!editor || !model || !this.hasProvider(feature, model)) {
 				return;
 			}
 			if (feature === 'hover') {
@@ -229,6 +229,33 @@ class ReviewLspTelemetryContribution extends Disposable implements IWorkbenchCon
 		this.editorStores.delete(editor);
 	}
 
+	private hasProvider(feature: string, model: ITextModel): boolean {
+		const features = this.languageFeaturesService;
+		switch (feature) {
+			case 'goto_definition':
+			case 'peek_definition':
+				return features.definitionProvider.has(model) || features.declarationProvider.has(model);
+			case 'goto_type_definition':
+				return features.typeDefinitionProvider.has(model);
+			case 'goto_implementation':
+				return features.implementationProvider.has(model);
+			case 'references':
+				return features.referenceProvider.has(model);
+			case 'rename':
+				return features.renameProvider.has(model);
+			case 'format':
+				return features.documentFormattingEditProvider.has(model) || features.documentRangeFormattingEditProvider.has(model);
+			case 'code_action':
+				return features.codeActionProvider.has(model);
+			case 'hover':
+				return features.hoverProvider.has(model);
+			case 'symbol_search':
+				return features.documentSymbolProvider.has(model);
+			default:
+				return true;
+		}
+	}
+
 	private captureLspUsed(editor: ICodeEditor, model: ITextModel, feature: string, via: string): void {
 		this.telemetryService.capture('lsp_used', {
 			feature,

docs/telemetry.md

@@ -300,7 +300,7 @@ session with `outcome: "app_quit"`, the same as quitting.
 
 | Event                             | Additional properties                                                                                                                                                                                                                       | When                                        |
 | --------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------- |
-| `review_lsp_used`                 | `feature` in hover, goto_definition, peek_definition, goto_type_definition, goto_implementation, references, rename, format, code_action, symbol_search; `via` in command, mouse; `language`; `editor_kind` in files_tab, inline_peek, diff, definition_peek | A user invokes an LSP feature               |
+| `review_lsp_used`                 | `feature` in hover, goto_definition, peek_definition, goto_type_definition, goto_implementation, references, rename, format, code_action, symbol_search; `via` in command, mouse; `language`; `editor_kind` in files_tab, inline_peek, diff, definition_peek | A user invokes an LSP feature the file supports |
 | `review_ls_activated`             | `group` in python, go, rust, swift, csharp; `ok`                                                                                                                                                                                            | A language server activation check ends     |
 | `review_extension_installed`      | Allowlisted `extension_id`; `trigger` in user, auto_upgrade, startup_seed, keymap, rollback; `cached`; `duration_ms`                                                                                                                        | An optional extension installs              |
 | `review_extension_install_failed` | Allowlisted `extension_id`; allowlisted `trigger`; `phase` in download, install                                                                                                                                                             | An optional extension install fails         |