Repository navigation
Count LSP commands only when the file has a provider for them - #1515
Merged
Merged
Conversation
Agent-Session: 9384a605-d9c3-4fb4-90ee-785315d819c8 Agent-Session: e35ee3f1-35bb-443a-a7fa-2d0fcb48c31e Agent-Session: b8a1d0cf-9b38-4aa4-b9f2-62aeab83bfb0
sidkmenon
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
review_lsp_usedfrom keyboard commands fired for any mapped command, even when the file had no provider for that feature. The mouse and hover paths already check for a provider. For example, F12 on the base side of a side-by-side peek has no language features since #1175. It shows "No definition found" but was still counted asgoto_definition.docs/telemetry.mdnotes the new condition.Context
This is a follow-up to #1511. In a dev Desktop, go-to-definition in canvas peeks works for hover, ⌘-click and F12, in unified and side-by-side views and on lower peeks. Every case is tagged
editor_kind: inline_peek. PostHog shows the ratio of go-to-definition to hover falling steadily from week to week, including within 0.2, not a sudden drop at 0.3.0. About a third of earlier go-to-definition users still use it on 0.3+. So the drop is not a regression.Testing
pnpm lint,pnpm format.