Skip to content

Count LSP commands only when the file has a provider for them - #1515

Merged
thesiti92 merged 1 commit into
mainfrom
fix/lsp-command-provider-gate
Nov 4, 2026
Merged

thesiti92 merged 1 commit into
mainfrom
fix/lsp-command-provider-gate

Conversation

@thesiti92

Copy link
Copy Markdown
Contributor

review_lsp_used from keyboard commands fired for any mapped command, even when the file had no provider for that feature. The mouse and hover paths already check for a provider. For example, F12 on the base side of a side-by-side peek has no language features since #1175. It shows "No definition found" but was still counted as goto_definition.

  • The command path now checks the matching provider (definition or declaration, type definition, implementation, references, rename, formatting, code action, hover, document symbols) before it records the event.
  • docs/telemetry.md notes the new condition.

Context

This is a follow-up to #1511. In a dev Desktop, go-to-definition in canvas peeks works for hover, ⌘-click and F12, in unified and side-by-side views and on lower peeks. Every case is tagged editor_kind: inline_peek. PostHog shows the ratio of go-to-definition to hover falling steadily from week to week, including within 0.2, not a sudden drop at 0.3.0. About a third of earlier go-to-definition users still use it on 0.3+. So the drop is not a regression.

Testing

  • pnpm lint, pnpm format.
  • Desktop fork typecheck.
  • Fork test tier: 569 pass, 0 fail.
  • Not yet run in a Desktop.

Agent-Session: 9384a605-d9c3-4fb4-90ee-785315d819c8
Agent-Session: e35ee3f1-35bb-443a-a7fa-2d0fcb48c31e
Agent-Session: b8a1d0cf-9b38-4aa4-b9f2-62aeab83bfb0
@thesiti92
thesiti92 enabled auto-merge (squash) November 4, 2026 17:45
@thesiti92
thesiti92 merged commit 9f3422a into main Nov 4, 2026
3 checks passed
@thesiti92
thesiti92 deleted the fix/lsp-command-provider-gate branch November 4, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants