Use Keybind.matches so hotkey 'Not set' disables the hotkey. - #93
Open
pensive-owl wants to merge 1 commit into
Open
pensive-owl wants to merge 1 commit into
pensive-owl wants to merge 1 commit into
Conversation
Author
|
@riktenx Any issues with this? |
Collaborator
|
i can release this later but i dont have capacity to test it at all, so hopefully you have done so, if a bunch of people come into the discord and complain i will just revert it |
Author
I have tested it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87.
The hotkey check compared keycodes manually. Keybind
Not setis keycode 0, and keyTyped events always report keycode 0, so with the hotkeyNot setany typed key matched and hid the chat. Switched tomatches(), which returns false forNot setand handles modifier combos. No behavior change otherwise.