Repository navigation
fix: stop content showing through the top bar and navigation while scrolling #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Topbar scroll glitch | ||
|
|
||
| Scrolling down and back to the top shows visual glitches in the top bar and the | ||
| Home/History/Dictionary/Settings navigation: content shows through (reported | ||
| with the mouse wheel). | ||
|
|
||
| - [x] Reproduce the glitch in WebKitGTK (the engine the Tauri app uses) with captured frames | ||
| - [x] Identify the root cause from the reproduction | ||
| - [x] Failing test: switching views resets the scroll position of `main` | ||
| - [x] Shell layout: only `main` scrolls, topbar and nav are not sticky; scroll reset targets `main` | ||
| - [x] Same reproduction no longer shows the glitch | ||
| - [x] e2e fit check also covers horizontal overflow inside `main` | ||
| - [x] Frontend CI checks pass locally (typecheck, lint, tests, responsive e2e) | ||
| - [ ] PR filed, reviews addressed, required checks green | ||
| - [ ] PR merged | ||
|
|
||
| ## Findings | ||
|
|
||
| - Reproduced only on native Wayland (in-process capture of the frames WebKit | ||
| hands to GTK while sending smooth wheel deltas). XWayland and Xvfb never | ||
| showed it. | ||
| - Baseline: 12, 27 (920 wide) and 22 (1280 wide) of 420 frames had the sticky | ||
| topbar or nav drawn out of place with content showing through. | ||
| - `content-visibility: visible` on transcript rows: 11 and 20 of 420, so not the cause. | ||
| - Only `main` scrolling (bars not sticky): 0 of 420 in three runs, at 920 and 1280. | ||
| - The user confirmed on their machine: the glitch shows in the old build and not in the fixed one. | ||
| - Screen recordings of the user's own mouse scrolling on Home (GNOME screencast, | ||
| bar region checked frame by frame): old build 21 of 1558 frames with the top | ||
| bar displaced 15 to 30px; fixed build 0 of 1515. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.