Repository navigation
fix: stop content showing through the top bar and navigation while scrolling - #212
Conversation
The page scrolled as a whole with the top bar and navigation pinned by position: sticky. On native Wayland, WebKitGTK repositions sticky layers separately from the scrolled content, so during smooth wheel scrolling some frames drew the bars partly scrolled away with content showing through. The shell now fills the window and only main scrolls, so the bars no longer move. Switching views resets main's scroll position instead of the window's, and the e2e fit check now also covers horizontal overflow inside main.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
main became the only scroller, so PageDown, arrow keys, Home and End no longer scrolled anything while focus sat on the body or a nav button. main is now programmatically focusable and takes focus on each view change, including first load.
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Scrolling down and back up made content flash through the top bar and the Home/History/Dictionary/Settings navigation. This happened with the mouse wheel in the app on Wayland.
The whole page scrolled, and the bars were pinned with
position: sticky. On native Wayland, WebKitGTK repositions sticky layers separately from the scrolled content. During smooth wheel scrolling, some frames drew the bars partly scrolled away with rows overlapping them. Now the app fills the window and only the content area scrolls, so the bars never move.window.scrollTo, which does nothing once the window no longer scrolls. It now resets the content area instead, with a test that failed before the change.mainis now focusable without becoming a tab stop, and it takes focus on first load and on every view change, so PageDown, the arrow keys, Home and End scroll it. Before this, they no longer scrolled anything (flagged by Sentry, confirmed in WebKitGTK).Proof:
content-visibilityon transcript rows did not help, which ruled it out as the cause.mainon first load and after a nav click.verify-settings-ux.sh(25 Playwright tests) pass.Reviewed with sol-loop: 2 rounds with gpt-6.1-sol. Sol verdict: approved
Created with Claude Opus 5.5 in Claude Code.