Skip to content

fix: stop content showing through the top bar and navigation while scrolling - #212

Merged
vriesd merged 3 commits into
mainfrom
fix/topbar-scroll-glitch
Oct 29, 2026
Merged

vriesd merged 3 commits into
mainfrom
fix/topbar-scroll-glitch

Conversation

@vriesd

@vriesd vriesd commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Scrolling down and back up made content flash through the top bar and the Home/History/Dictionary/Settings navigation. This happened with the mouse wheel in the app on Wayland.

The whole page scrolled, and the bars were pinned with position: sticky. On native Wayland, WebKitGTK repositions sticky layers separately from the scrolled content. During smooth wheel scrolling, some frames drew the bars partly scrolled away with rows overlapping them. Now the app fills the window and only the content area scrolls, so the bars never move.

  • Switching views used to call window.scrollTo, which does nothing once the window no longer scrolls. It now resets the content area instead, with a test that failed before the change.
  • main is now focusable without becoming a tab stop, and it takes focus on first load and on every view change, so PageDown, the arrow keys, Home and End scroll it. Before this, they no longer scrolled anything (flagged by Sentry, confirmed in WebKitGTK).
  • The e2e fit check now also catches horizontal overflow inside the content area, because the document itself can no longer overflow.

Proof:

  • I captured frames in a native Wayland WebKitGTK harness during smooth wheel scrolling over a 60-row History list. Before the fix, 12 to 27 of 420 frames showed the bars displaced (920 and 1280 wide). After it, 0 of about 420 in each of 4 runs (920 and 1280 wide, dark and light).
  • Turning off content-visibility on transcript rows did not help, which ruled it out as the cause.
  • Screen recordings of the reporter's own mouse scrolling on Home, checked frame by frame: the old build had the top bar displaced 15 to 30px in 21 of 1558 frames, the fixed build in 0 of 1515.
  • Keyboard scrolling, real WebKitGTK window: PageDown, the arrow keys, End and Home scroll main on first load and after a nav click.
  • Build, lint, 332 unit tests and verify-settings-ux.sh (25 Playwright tests) pass.

Reviewed with sol-loop: 2 rounds with gpt-6.1-sol. Sol verdict: approved

Created with Claude Opus 5.5 in Claude Code.

The page scrolled as a whole with the top bar and navigation pinned by
position: sticky. On native Wayland, WebKitGTK repositions sticky layers
separately from the scrolled content, so during smooth wheel scrolling some
frames drew the bars partly scrolled away with content showing through.

The shell now fills the window and only main scrolls, so the bars no longer
move. Switching views resets main's scroll position instead of the window's,
and the e2e fit check now also covers horizontal overflow inside main.
@vriesd

vriesd commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T07:16:04.837597Z a3663cd Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 8102bc9477

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/src/App.tsx Resolved
main became the only scroller, so PageDown, arrow keys, Home and End no
longer scrolled anything while focus sat on the body or a nav button. main
is now programmatically focusable and takes focus on each view change,
including first load.
@vriesd

vriesd commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: a3663cdd9a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@vriesd
vriesd merged commit 99f4e9e into main Oct 29, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants