Skip to content

refactor(select): hide empty option for placeholder and floating label right away #6477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mfranzke wants to merge 14 commits into
base: main
Choose a base branch
from
+13 −3
Open

refactor(select): hide empty option for placeholder and floating label right away #6477

Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1449787
refactor(select): hide our empty `option` right away
mfranzke Apr 13, 2026
e5ff84b
Apply suggestion from @mfranzke
mfranzke Apr 13, 2026
4d8a338
Apply suggestion from @mfranzke
mfranzke Apr 14, 2026
72e089c
Create famous-dryers-sniff.md
mfranzke Apr 16, 2026
cb7e951
Update famous-dryers-sniff.md
mfranzke Apr 16, 2026
fc9b177
Update packages/components/src/components/select/select.scss
mfranzke Apr 17, 2026
639501f
Merge branch 'main' into refactor-select-hide-our-empty-option-right-…
mfranzke Apr 17, 2026
1567f5f
Update select.scss
mfranzke Apr 17, 2026
3abba78
auto update snapshots (#6516)
github-actions[bot] Apr 20, 2026
8523944
Merge branch 'main' into refactor-select-hide-our-empty-option-right-…
mfranzke Apr 20, 2026
f5cc736
fix: selector
mfranzke Apr 20, 2026
16404d3
auto update snapshots (#6520)
github-actions[bot] Apr 20, 2026
3cdd3ae
refactor: another try
mfranzke Apr 20, 2026
1027973
Revert "refactor: another try"
mfranzke Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/components/src/components/select/select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@
background-color: colors.$db-adaptive-bg-basic-level-3-default;
}

&:has(> select option:checked:not(.placeholder)) {
// TODO: we could remove the `> select option:checked:not(.placeholder), ` selector part as soon as `:open` is baseline.
&:has(> select option:checked:not(.placeholder), > select:open) {
Comment thread
mfranzke marked this conversation as resolved.
Outdated
Comment thread
mfranzke marked this conversation as resolved.
Outdated
[id$="-placeholder"],
// Hide placeholder option in dropdown for required selects after a selection has been made
Comment thread
mfranzke marked this conversation as resolved.
Outdated
// This prevents users from selecting an invalid empty option when the field is required
Expand Down
Loading