Skip to content

refactor(select): hide empty option for placeholder and floating label right away#6477

Open
mfranzke wants to merge 14 commits intomainfrom
refactor-select-hide-our-empty-option-right-away
Open

refactor(select): hide empty option for placeholder and floating label right away#6477
mfranzke wants to merge 14 commits intomainfrom
refactor-select-hide-our-empty-option-right-away

Conversation

@mfranzke
Copy link
Copy Markdown
Collaborator

@mfranzke mfranzke commented Apr 13, 2026

Proposed changes

As a follow up to #5888, we should even already hide the first, empty option that we're inserting for placeholder and floating label DBSelect components, right away, in case that showEmptyOption is defined. That for we use the :open CSS pseudo selector as progressive enhancement.

As soon as :open is supported widely (only Safari is missing support currently, but will release it most likely with version 26.5), we could even also remove the first part of this :has selector.

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/refactor-select-hide-our-empty-option-right-away

As a follow up to #5888, we should even already hide the first, empty `option` that we're inserting for placeholder and floating label DBSelect components, right away, in case that `showEmptyOption` is defined. That for we use the `:open` CSS pseudo selector as progressive enhancement.

As soon as `:open` is supported widely (only Safari is missing, but will release it most likely with version 26.5), we could even also remove the first part of this `:has` selector.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 13, 2026

🦋 Changeset detected

Latest commit: 1027973

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@db-ux/core-components Minor
@db-ux/ngx-core-components Minor
@db-ux/v-core-components Minor
@db-ux/wc-core-components Minor
@db-ux/react-core-components Minor
@db-ux/core-foundations Minor
@db-ux/core-stylelint Minor
@db-ux/core-migration Minor
@db-ux/agent-cli Minor
@db-ux/core-eslint-plugin Minor
@db-ux/core-vite-plugin Minor
@db-ux/core-postcss-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/components/src/components/select/select.scss Outdated
@mfranzke mfranzke moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Apr 13, 2026
@mfranzke mfranzke enabled auto-merge (squash) April 13, 2026 11:27
Comment thread packages/components/src/components/select/select.scss Outdated
@mfranzke mfranzke added this to the 4.7.0 milestone Apr 16, 2026
@mfranzke mfranzke added this to Roadmap Apr 16, 2026
@mfranzke mfranzke changed the title refactor(select): hide our empty option right away refactor(select): hide empty option for palceholder and floating label right away Apr 16, 2026
@mfranzke mfranzke changed the title refactor(select): hide empty option for palceholder and floating label right away refactor(select): hide empty option for placeholder and floating label right away Apr 16, 2026
@github-actions github-actions bot added the 📕documentation Improvements or additions to documentation label Apr 16, 2026
@michaelmkraus michaelmkraus moved this from 🎁 Ready for review to 👀 Actively In Review in UX Engineering Team Backlog Apr 17, 2026
@michaelmkraus michaelmkraus self-requested a review April 17, 2026 08:26
Comment thread packages/components/src/components/select/select.scss Outdated
@michaelmkraus michaelmkraus moved this from 👀 Actively In Review to 🎶 Waiting for feedback in UX Engineering Team Backlog Apr 17, 2026
@mfranzke mfranzke moved this from 🎶 Waiting for feedback to ⏰ready for release in UX Engineering Team Backlog Apr 17, 2026
@mfranzke mfranzke requested a review from michaelmkraus April 17, 2026 16:25
@mfranzke mfranzke moved this from ⏰ready for release to 🎁 Ready for review in UX Engineering Team Backlog Apr 17, 2026
github-actions bot and others added 2 commits April 20, 2026 05:44
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke moved this from 🎁 Ready for review to 🏗 In progress in UX Engineering Team Backlog Apr 20, 2026
github-actions bot and others added 3 commits April 20, 2026 10:24
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏘components 📕documentation Improvements or additions to documentation 🍄🆙improvement New feature or request

Projects

Status: No status
Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

2 participants