refactor(select): hide empty option for placeholder and floating label right away#6477
Open
refactor(select): hide empty option for placeholder and floating label right away#6477
option for placeholder and floating label right away#6477Conversation
As a follow up to #5888, we should even already hide the first, empty `option` that we're inserting for placeholder and floating label DBSelect components, right away, in case that `showEmptyOption` is defined. That for we use the `:open` CSS pseudo selector as progressive enhancement. As soon as `:open` is supported widely (only Safari is missing, but will release it most likely with version 26.5), we could even also remove the first part of this `:has` selector.
🦋 Changeset detectedLatest commit: 1027973 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mfranzke
commented
Apr 13, 2026
mfranzke
commented
Apr 14, 2026
option right awayoption for palceholder and floating label right away
option for palceholder and floating label right awayoption for placeholder and floating label right away
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This reverts commit 3cdd3ae.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
As a follow up to #5888, we should even already hide the first, empty
optionthat we're inserting for placeholder and floating label DBSelect components, right away, in case thatshowEmptyOptionis defined. That for we use the:openCSS pseudo selector as progressive enhancement.As soon as
:openis supported widely (only Safari is missing support currently, but will release it most likely with version 26.5), we could even also remove the first part of this:hasselector.Types of changes
Further comments
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/refactor-select-hide-our-empty-option-right-away