Repository navigation
feat: per-contact shielded address index and a payment reference memo kind #5893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QuantumExplorer
merged 9 commits into
v5.1-dev
from
claude/dashpay-shielded-address-primitives
Nov 12, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ff58e1c
feat(sdk): derive the per-contact shielded address index and encrypt β¦
QuantumExplorer cf203fa
feat(dpp): payment reference kind for shielded memos
QuantumExplorer 3d366b4
feat(platform-wallet): derive a contact request's shielded address frβ¦
QuantumExplorer ba9bcb2
Merge remote-tracking branch 'origin/v5.1-dev' into claude/dashpay-shβ¦
QuantumExplorer cd62b4c
docs: qualify contact address uniqueness and what payment_ref_text reβ¦
QuantumExplorer 83901e2
fix: write the FFI headers to the profile directory under Cargo 1.100
QuantumExplorer fafe132
fix(platform-wallet): keep fresh shielded addresses out of the per-coβ¦
QuantumExplorer 240d13c
test(sdk): drop the 32-bit wallet band from a test comment
QuantumExplorer 2a6aa29
Update packages/rs-platform-wallet/src/wallet/shielded/keys.rs
QuantumExplorer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π‘ Suggestion: Document the enum additions as Rust source-compatibility changes
Both
ShieldedMemoandplatform_encryption::CryptoErrorare publicly exported enums without#[non_exhaustive]. AddingPaymentRefand the two error variants makes downstream exhaustive matches fail to compile when consumers update, even though existing workspace consumers still compile and the memo wire encoding remains compatible. Replace the PR's Breaking Changes claim of "None" with a migration note explaining that exhaustive matches need new arms or a fallback. Keep the ordinaryfeat:title: the book's "Commits, pull requests, and what to run before pushing" section reserves!for consensus-breaking changes, which this is not.source:
gpt-6.1-sol(phase2-reviewer: general, architecture-layering, platform-versioning, rust-quality, security-auditor)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in the description: Breaking Changes now says there is no consensus change (the title stays
feat:) and gives the migration note, thatShieldedMemoandCryptoErrorgain variants and code matching either exhaustively needs a new arm or a fallback.π€ Addressed by Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved (re-reviewed at
83901e22): Your current Breaking Changes section explicitly documents the added ShieldedMemo and CryptoError variants and the exhaustive-match migration, while retaining the ordinary feat title and unchanged memo-wire compatibility.