Skip to content

feat: per-contact shielded address index and a payment reference memo kind - #5893

Merged
QuantumExplorer merged 9 commits into
v5.1-devfrom
claude/dashpay-shielded-address-primitives
Nov 12, 2026
Merged

QuantumExplorer merged 9 commits into
v5.1-devfrom
claude/dashpay-shielded-address-primitives

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Basic explanation

What this does: Adds two building blocks for private DashPay payments. Nothing uses them yet, so behaviour does not change. The first works out which private (shielded) payment address a wallet gives to a contact. The address is computed from the contact request itself (who sends it, to whom, and its account reference) and a key only the wallet holds, and this change also encrypts and decrypts that address for the contact request, and lets the wallet's viewing keys turn a contact request into its address. The second is a new kind of note attached to a shielded payment, a payment reference: a value such as an invoice number that the payee gave to the payer.

Value: Every wallet that follows the rule gives each contact a different address, even with two devices on one seed and after a restore, with nothing to store or keep in step. A counter cannot guarantee that: two devices would hand the same address to different contacts. A payee can match a private payment to an invoice. Both live once in Rust, checked against the DIP's test vectors, for the Rust, Swift and Kotlin SDKs to share.

Risks: Low. No consensus rule changes and nothing calls the new functions yet. The derivation must never change once wallets use it, because a different result would give a contact a different address; the tests pin it to the DIP's vectors. A wallet without this change still keeps a payment reference memo intact, as a memo of an unknown kind.

Issue being fixed or feature implemented

The DashPay shielded payment addresses DIP (dashpay/dips#195) defines how a wallet derives the shielded address it gives each contact, how a contact request carries it, and a payment reference memo. Platform implements none of these. Today the wallet takes the address to send from the host application, so nothing stops one address going to every contact.

The contract field that carries the address is #5892, which is merged. This change does not depend on it.

What was done?

packages/rs-platform-encryption/src/shielded_address.rs (new)

  • shielded_contact_index_key(full_viewing_key): the key an account derives its per-contact indices under, HMAC-SHA256("DashPay/shielded/contact-index-key/v1", full viewing key).
  • shielded_contact_index(index_key, owner_id, to_user_id, account_reference): the 88-bit diversifier index of the address a contact request carries, a keyed hash of the request's unique key with bit 87 set, so it always lies in the range kept for contacts.
  • is_shielded_contact_index(index): whether an index lies in that range.
  • encrypt_shielded_address and decrypt_shielded_address: the 64-byte encryptedShieldedAddress, an IV followed by the 43-byte address under AES-256-CBC with the request's DIP-15 shared key. Decryption refuses any other field length, the reserved 80 bytes included, and a plaintext that is not 43 bytes.
  • Two CryptoError variants for those refusals.

The module needs no shielded pool types. Turning an index into an address is the wallet's step, below.

packages/rs-platform-wallet/src/wallet/shielded/keys.rs

  • AccountViewingKeys::contact_address(owner_id, to_user_id, account_reference): the address a shielded account gives the contact of one contact request, the external address at the request's index.
  • AccountViewingKeys::contact_index_of(address): the per-contact index an address of the account sits at, or None for another account's address and for the account's profile and wallet-local addresses. A wallet uses it to attribute a payment that arrives on a contact's address.

Neither decides which account an identity uses, or when a wallet sends an address; those come with the wallet's contact request flow.

AccountViewingKeys::fresh_address, added by #5888, drew its index from the whole index space, so about half of fresh addresses fell in the range kept for contact requests. It now redraws an index of 2^87 or above, as it already redraws index 0. A fresh address keeps 87 random bits, and contact_index_of returns None for every one.

  • Before: a fresh address at index ff..ff is the account's own, and contact_index_of returns Some(ff..ff).
  • After: that index is never used for a fresh address.

packages/rs-dpp/src/shielded/memo.rs

  • ShieldedMemo::PaymentRef([u8; 32]), memo kind 2: the payee's reference padded on the right with zero bytes.
  • ShieldedMemo::payment_ref(reference) builds one from 1 to 32 bytes and refuses an empty or all-zero reference.
  • ShieldedMemo::payment_ref_text gives the reference as text when it is valid UTF-8 without its padding.

Example, the index of a contact request from identity 0x11..11 to 0x22..22 with account reference 0x01234567, under the DIP's test account:

index key : 7233ea974f99a772e1f7cfeef7d1626f9d24cba429b32f5ecdabed7b14867791
index     : f90d5349d8530cf76835d0   (11 bytes, little-endian)
address   : 25611685f1aa7c3b7a2f7a758ea2f98ca16e32e20e0d3b403a1d81421f1185d67f47054ae98e55e05e839c

Example, decoding the memo 02000000 followed by INV-2026-0042 and zero padding:

  • Before: ShieldedMemo::Other { kind: 2, .. }.
  • After: ShieldedMemo::PaymentRef(..), whose text is INV-2026-0042.
  • Kind 2 with an all-zero payload is no reference and still decodes as Other.

Build scripts (not part of the feature)

The Swift SDK build fails on every branch since Rust 1.100.0 was released on 12 November: Cargo 1.100 moved build script output one directory deeper, and three build scripts wrote the FFI headers to the wrong place. The fix is its own pull request, #5898. The same commit is on this branch so that its Swift check can pass; the two are identical and merge cleanly in either order.

How Has This Been Tested?

  • shielded_address.rs: eight tests. They reproduce the DIP's vectors (the index key, three indices, the 64-byte field) and cover the refusals: other field lengths, a plaintext that is not 43 bytes, and a field that does not decrypt.
  • memo.rs: five tests for the new kind, including the DIP's memo vector and the all-zero payload.
  • keys.rs: a test that a fresh index in the contact range is redrawn, and three tests that run the DIP's vectors end to end through the wallet's own key derivation: seed, identity shielded account, full viewing key, profile address, and the address of each contact request, on mainnet and testnet.

Run locally:

  • cargo test -p platform-encryption --lib shielded_address
  • cargo test -p dpp --all-features --lib shielded::memo
  • cargo test -p platform-wallet --features shielded --lib shielded::keys
  • cargo clippy -p platform-encryption --all-targets, cargo clippy -p dpp --all-features --lib --tests and cargo clippy -p platform-wallet --features shielded --lib --tests

Breaking Changes

No consensus change, so the title carries no !.

Rust source compatibility: dpp::shielded::ShieldedMemo gains the PaymentRef variant, and platform_encryption::CryptoError gains InvalidEncryptedShieldedAddressLength and InvalidShieldedAddressLength. Neither enum is #[non_exhaustive], so code outside this workspace that matches one exhaustively will need a new arm or a fallback arm when it updates. Nothing in the workspace does. The memo's wire encoding is unchanged: a reader without this change keeps a kind 2 memo as Other.

Checklist:

  • I have performed a self-review of my own code
  • My Rust, FFI, WASM, Swift or Kotlin changes follow the coding conventions
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed
  • If I added or changed GroveDB structure, I described it in the area's structure.rs, regenerated grovedb-structure.json, and checked the structure viewer link posted on this pull request
  • If I added or changed a system contract's document schemas, I checked the contract viewer link posted on this pull request

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

PR Hygiene · 240d13c

  • Bots — thepastaclaw ✓
  • Self-review — post /self-reviewed
  • Build green
  • Approvals
    • dpp — you own it
    • files with no dedicated owner — you own it
    • rs-platform-wallet-ffi (packages/rs-platform-wallet-ffi/build.rs) — HashEngineering or ZocoLini or llbartekll or romchornyi
    • rs-platform-wallet (packages/rs-platform-wallet/src/wallet/shielded/keys.rs) — HashEngineering or ZocoLini or llbartekll or romchornyi
    • rust-sdk-ffi (packages/rs-sdk-ffi/build.rs) — lklimek or shumkov

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Summary by CodeRabbit

  • New Features
    • Added payment references to shielded transaction memos, with support for reading valid text references.
    • Added contact-specific shielded address derivation and recognition.
    • Added shielded address encryption and decryption, with validation of address formats and lengths.
  • Bug Fixes
    • Invalid payment references and malformed encrypted shielded addresses are now rejected rather than accepted as valid data.

QuantumExplorer and others added 2 commits November 12, 2026 19:38
…the address

The diversifier index of the shielded address a DashPay contact request
carries is a keyed hash of the request's unique key (owner, recipient,
account reference) under a key derived from the account's full viewing key.
Two devices on one seed derive the same address for the same request and
never the same address for two contacts, with no counter or stored state.

Also encodes and decodes `encryptedShieldedAddress`: an IV and the 43-byte
address under AES-256-CBC with the request's DIP-15 shared key, 64 bytes.

Tested against the vectors of the DashPay shielded payment addresses DIP.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Memo kind 2, `PaymentRef`, carries a reference the payee chose and gave to
the payer, such as an invoice or order number, so the payee can match a
shielded payment to its records. It is the reference padded on the right with
zero bytes to 32; an all-zero payload is no reference and decodes as an
unknown memo. It names what is paid, never who pays.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

No actionable comments were generated in the recent review.

Walkthrough

The changes add payment-reference support to shielded memos, contact-index derivation and shielded-address encryption helpers, and contact-address derivation and recognition in wallet viewing keys.

Changes: Payment-reference memos

Layer / File(s) Summary
Payment-reference memo support
packages/rs-dpp/src/shielded/memo.rs
ShieldedMemo adds a payment-reference kind with a 32-byte payload. Construction pads accepted references and rejects empty, all-zero, or oversized inputs. Encoding and decoding handle the new kind, while all-zero payloads decode as Other. Tests cover these cases and text access.

Shielded contact addresses

Layer / File(s) Summary
Contact-index and address-field primitives
packages/rs-platform-encryption/src/shielded_address.rs, packages/rs-platform-encryption/src/error.rs, packages/rs-platform-encryption/src/lib.rs
The encryption crate adds contact-index derivation and classification, plus AES-256-CBC encryption and decryption for shielded address fields. It exports the helpers and length constants, adds length errors, and tests derivation, round-tripping, and invalid inputs.
Wallet contact-address derivation
packages/rs-platform-wallet/src/wallet/shielded/keys.rs
AccountViewingKeys adds contact-address derivation and contact-index recognition. Tests cover account and contact vectors, and verify recognition behavior for contact, profile, local, and other-account addresses.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Possibly related PRs

  • dashpay/platform#5892: Adds the contact-request ciphertext field that accepts the 64-byte encrypted shielded address produced by this change.

Suggested reviewers: shumkov, romchornyi

Merge Risk: Minimal · previous review cd62b

This change adds new shielded contact-address helpers and a payment-reference memo kind without wiring them into existing flows, so current behavior should not change. No actionable merge-blocking risk is identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names two changes the changeset contains: a per-contact shielded address index (contact-index derivation, address encryption, and wallet contact-address methods) and a payment reference memo…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names two changes the changeset contains: a per-contact shielded address index (contact-index derivation, address encryption, and wallet contact-address methods) and a payment reference memo kind (ShieldedMemo::PaymentRef). It is a single, specific sentence in conventional-commit form. It does not cover every detail, such as the error variants or re-exports, but that is expected.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between cade2c0 and cd62b4c.

Files selected for processing: 5

  • packages/rs-dpp/src/shielded/memo.rs
  • packages/rs-platform-encryption/src/error.rs
  • packages/rs-platform-encryption/src/lib.rs
  • packages/rs-platform-encryption/src/shielded_address.rs
  • packages/rs-platform-wallet/src/wallet/shielded/keys.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions github-actions Bot added this to the v5.1.0 milestone Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Nov 12, 2026
@thepastaclaw

thepastaclaw commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Final review complete — no blockers (commit 240d13c)

…om the account's viewing keys

`AccountViewingKeys::contact_address` gives the address a shielded account
hands the contact of one contact request: the external address at the index
the request's unique key hashes to under the account's full viewing key.
`contact_index_of` maps an address of the account back to its per-contact
index, for attributing a payment that arrives on it.

Tests run the DashPay shielded payment addresses DIP's vectors end to end:
seed, identity shielded account, full viewing key, profile address, and the
address of each contact request.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 1 + Phase 2

Verified the findings against head 3d366b4. No blocking correctness, layering, or consensus-versioning issue was established; three non-blocking API/documentation clarifications remain. This was a static review: the current Kotlin SDK build/tests passed, no failed code checks were reported, and PastaClaw review and PR Hygiene remain pending.

🟡 3 suggestion(s)

Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: architecture-layering); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: platform-versioning); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); reviewer 5: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 6: muse-spark-1.3-contributor (agent: phase1-reviewer, role: rust-quality); reviewer 7: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: critical by gpt-6.1-sol (effort low) — The substantial new cryptographic implementation in shielded_address.rs and AccountViewingKeys::contact_address combines keyed address-index derivation, encryption/decryption, and viewing-key handling whose correctness determines stable per-contact payment addresses.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer, muse-spark-1.3-contributor — rust-quality (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Single stage: Phase 1 and Phase 2 reviewed this head side by side, with no blocker gate between them (triage tier)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — architecture-layering (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — platform-versioning (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — security-auditor (completed, effort xhigh); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.

In `packages/rs-dpp/src/shielded/memo.rs`:
- [SUGGESTION] packages/rs-dpp/src/shielded/memo.rs:47-53: Document the enum additions as Rust source-compatibility changes
  Both `ShieldedMemo` and `platform_encryption::CryptoError` are publicly exported enums without `#[non_exhaustive]`. Adding `PaymentRef` and the two error variants makes downstream exhaustive matches fail to compile when consumers update, even though existing workspace consumers still compile and the memo wire encoding remains compatible. Replace the PR's Breaking Changes claim of "None" with a migration note explaining that exhaustive matches need new arms or a fallback. Keep the ordinary `feat:` title: the book's "Commits, pull requests, and what to run before pushing" section reserves `!` for consensus-breaking changes, which this is not.
- [SUGGESTION] packages/rs-dpp/src/shielded/memo.rs:101-102: Document the actual non-text result of payment_ref_text
  The documentation says a non-UTF-8 reference "is shown in hexadecimal", but this helper only borrows valid UTF-8 and returns `None` otherwise; it performs no hexadecimal formatting. The new non-text round-trip test explicitly pins that behavior. Clarify that hexadecimal rendering is the caller's responsibility so consumers know how to handle the `None` result.

In `packages/rs-platform-wallet/src/wallet/shielded/keys.rs`:
- [SUGGESTION] packages/rs-platform-wallet/src/wallet/shielded/keys.rs:225-228: Qualify contact-address uniqueness and expose the collision-check duty
  `contact_address` promises that two requests never share an address, but `shielded_contact_index` truncates HMAC output to 11 bytes and forces the high bit, leaving a finite 87-bit output space. Its own documentation consequently requires callers to compare previously issued indices and retry under another `account_reference` on a collision. State that qualification at this wallet entry point, and soften the same absolute claim in `shielded_address.rs`'s module documentation. Derivation itself needs no allocation state; collision checking needs access to earlier requests or their derived indices, not necessarily a separately persisted index table. This is a documentation correction, not a request to add the future contact-request allocation flow here.

Comment on lines +47 to +53
/// A payment reference: what the payment is for, in a value the payee chose and
/// gave to the payer, such as an invoice or order number, padded on the right with
/// zero bytes. The payee matches all 32 bytes against its own records.
///
/// It never says who paid. Anyone who has seen a reference can attach it to a
/// payment, so the payee checks the amount it received against the request.
PaymentRef([u8; MEMO_PAYLOAD_SIZE]),

@thepastaclaw thepastaclaw Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Resolved at 83901e22; see the replies below.

🟡 Suggestion: Document the enum additions as Rust source-compatibility changes

Both ShieldedMemo and platform_encryption::CryptoError are publicly exported enums without #[non_exhaustive]. Adding PaymentRef and the two error variants makes downstream exhaustive matches fail to compile when consumers update, even though existing workspace consumers still compile and the memo wire encoding remains compatible. Replace the PR's Breaking Changes claim of "None" with a migration note explaining that exhaustive matches need new arms or a fallback. Keep the ordinary feat: title: the book's "Commits, pull requests, and what to run before pushing" section reserves ! for consensus-breaking changes, which this is not.

source: gpt-6.1-sol (phase2-reviewer: general, architecture-layering, platform-versioning, rust-quality, security-auditor)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in the description: Breaking Changes now says there is no consensus change (the title stays feat:) and gives the migration note, that ShieldedMemo and CryptoError gain variants and code matching either exhaustively needs a new arm or a fallback.

🤖 Addressed by Claude Code

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved (re-reviewed at 83901e22): Your current Breaking Changes section explicitly documents the added ShieldedMemo and CryptoError variants and the exhaustive-match migration, while retaining the ordinary feat title and unchanged memo-wire compatibility.

Comment on lines +225 to +228
/// The same request always gives the same address, and two requests never share
/// one, on every device holding the seed and with nothing stored. `owner_id` is
/// the identity that sends the request and owns this account, and
/// `account_reference` the value the request publishes.

@thepastaclaw thepastaclaw Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Resolved at 83901e22; see the replies below.

🟡 Suggestion: Qualify contact-address uniqueness and expose the collision-check duty

contact_address promises that two requests never share an address, but shielded_contact_index truncates HMAC output to 11 bytes and forces the high bit, leaving a finite 87-bit output space. Its own documentation consequently requires callers to compare previously issued indices and retry under another account_reference on a collision. State that qualification at this wallet entry point, and soften the same absolute claim in shielded_address.rs's module documentation. Derivation itself needs no allocation state; collision checking needs access to earlier requests or their derived indices, not necessarily a separately persisted index table. This is a documentation correction, not a request to add the future contact-request allocation flow here.

Suggested change
/// The same request always gives the same address, and two requests never share
/// one, on every device holding the seed and with nothing stored. `owner_id` is
/// the identity that sends the request and owns this account, and
/// `account_reference` the value the request publishes.
/// The same request always gives the same address on every device holding the
/// seed, without storing an address allocation. Distinct requests can collide
/// with negligible probability; before issuing an address, the caller checks
/// previously issued indices and retries with another `account_reference` on a
/// match (see [`shielded_contact_index`]). `owner_id` is the identity that sends
/// the request and owns this account, and `account_reference` is the value the
/// request publishes.

source: muse-spark-1.3-contributor (phase1-reviewer: general, rust-quality)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in cd62b4c: contact_address now says two requests share an address only if their 87-bit indices collide, and that the caller checks earlier indices and retries under another account_reference. The module documentation in shielded_address.rs drops the same absolute claim.

🤖 Addressed by Claude Code

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved (re-reviewed at 83901e22): Your updated contact_address and module documentation now acknowledge the finite 87-bit collision space and explain the caller's comparison-and-retry duty, resolving the original absolute uniqueness claim.

Comment thread packages/rs-dpp/src/shielded/memo.rs Outdated
Comment on lines +101 to +102
/// A payment reference as text, when it is valid UTF-8 once its zero padding is
/// removed. A reference that is not, a hash for example, is shown in hexadecimal.

@thepastaclaw thepastaclaw Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Resolved at 83901e22; see the replies below.

🟡 Suggestion: Document the actual non-text result of payment_ref_text

The documentation says a non-UTF-8 reference "is shown in hexadecimal", but this helper only borrows valid UTF-8 and returns None otherwise; it performs no hexadecimal formatting. The new non-text round-trip test explicitly pins that behavior. Clarify that hexadecimal rendering is the caller's responsibility so consumers know how to handle the None result.

Suggested change
/// A payment reference as text, when it is valid UTF-8 once its zero padding is
/// removed. A reference that is not, a hash for example, is shown in hexadecimal.
/// A payment reference as text, when it is valid UTF-8 once its zero padding is
/// removed. Returns `None` for an empty or non-UTF-8 reference; callers that need
/// to display a non-text reference render the raw bytes as hexadecimal.

source: muse-spark-1.3-contributor (phase1-reviewer: general, rust-quality)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in cd62b4c: the documentation now says payment_ref_text returns None for a reference that is not text, and that the caller renders its 32 bytes in hexadecimal.

🤖 Addressed by Claude Code

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved (re-reviewed at 83901e22): Your documentation update matches the implementation: payment_ref_text returns None for non-text references, and callers handle hexadecimal rendering.

@github-actions

Copy link
Copy Markdown
Contributor

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed and removed waiting-bots Waiting for the review bots to report on this head labels Nov 12, 2026
…ielded-address-primitives

Both sides added methods and tests to `AccountViewingKeys` at the same place:
v5.1-dev the fresh address and own-recipient check, this branch the
per-contact address and index. Both are kept.

`contact_index_of` now says that a fresh address, drawn from the whole index
space, can lie in the range per-contact addresses use and match no request.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added waiting-bots Waiting for the review bots to report on this head and removed waiting-self-review Waiting for the author to post /self-reviewed labels Nov 12, 2026

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 2 only (queue backlog)

The current head incorporates the base merge and correctly clarifies that contact_index_of does not by itself identify a known contact; no blocking defect was found in the reviewed changes. All three prior suggestions remain valid against the exact head, ba9bcb2. Validation was static-only: current Rust workspace, wasm32, Swift, Kotlin, and JS checks pass; the dedicated wallet test job is skipped, and review/PR Hygiene checks remain pending.

🟡 3 suggestion(s)

Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.

Still open from earlier rounds (3)

  • 🟡 Suggestion: Document the actual non-text result of payment_ref_text — packages/rs-dpp/src/shielded/memo.rs:101-102 (thread)
  • 🟡 Suggestion: Qualify contact-address uniqueness and expose the collision-check duty — packages/rs-platform-wallet/src/wallet/shielded/keys.rs:277-280 (thread)
  • 🟡 Suggestion: Document the enum additions as Rust source-compatibility changes — packages/rs-dpp/src/shielded/memo.rs:47-53 (thread)
Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: architecture-layering); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: platform-versioning); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); reviewer 5: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: critical by gpt-6.1-sol (effort low) — The change adds intricate cryptographic and key-handling logic in shielded_address.rs and AccountViewingKeys::contact_address, combining domain-separated keyed derivation, an 88-bit index namespace, and encrypted address encoding whose correctness must remain stable across wallet restores.
  • Phase 1 reviewers: not run (skipped for throughput: 12 PRs queued, above the 10 limit)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — architecture-layering (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — platform-versioning (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — security-auditor (completed, effort xhigh); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.

In `packages/rs-dpp/src/shielded/memo.rs`:
- [SUGGESTION] packages/rs-dpp/src/shielded/memo.rs:101-102: Document the actual non-text result of payment_ref_text
  (carried; thread: https://github.com/dashpay/platform/pull/5893#discussion_r4551448278)
- [SUGGESTION] packages/rs-dpp/src/shielded/memo.rs:47-53: Document the enum additions as Rust source-compatibility changes
  (carried; thread: https://github.com/dashpay/platform/pull/5893#discussion_r4551448221)

In `packages/rs-platform-wallet/src/wallet/shielded/keys.rs`:
- [SUGGESTION] packages/rs-platform-wallet/src/wallet/shielded/keys.rs:277-280: Qualify contact-address uniqueness and expose the collision-check duty
  (carried; thread: https://github.com/dashpay/platform/pull/5893#discussion_r4551448242)

@github-actions

Copy link
Copy Markdown
Contributor

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed and removed waiting-bots Waiting for the review bots to report on this head labels Nov 12, 2026
…turns

`contact_address` and the module documentation said two contact requests
never share an address. They share one only if their 87-bit indices collide,
which is negligible, and the sender checks for it before sending; both now
say so and point at the check.

`payment_ref_text` returns `None` for a reference that is not text. Its
documentation said such a reference is shown in hexadecimal, which is the
caller's part.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added waiting-bots Waiting for the review bots to report on this head and removed waiting-self-review Waiting for the author to post /self-reviewed labels Nov 12, 2026
Cargo 1.100 puts a build script's `OUT_DIR` one level deeper:
`target/<profile>/build/<package>/<hash>/out`, where it was
`target/<profile>/build/<package>-<hash>/out`. The three build scripts that
stage headers under `target/<profile>/include` found that directory by going
three levels up from `OUT_DIR`, so under the new layout the headers landed in
`target/<profile>/build/include` and the Swift SDK build, which installs the
stable toolchain, reported `rs-sdk-ffi.h` missing.

They now take the parent of the `build` directory, which is the profile
directory under both layouts.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 1 + Phase 2

The new contact-address helpers coexist with a fresh-address generator that can enter the DIP's reserved contact range on identity accounts; one non-blocking suggestion remains to reconcile that allocation policy. Static inspection found no additional issue in the memo encoding, encrypted-field handling, or header-output changes. Current CI passes Rust workspace, wasm32, Kotlin, Swift, and dashmate checks; three JavaScript test jobs remain pending, with no failed code checks reported.

🟡 1 suggestion(s)

Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: architecture-layering); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: ffi-engineer); reviewer 4: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 5: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); reviewer 6: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); reviewer 7: muse-spark-1.3-contributor (agent: phase1-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: critical by gpt-6.1-sol (effort low) — The substantial change adds cryptographic key derivation, shielded-address encryption/decryption, and wallet viewing-key handling in shielded_address.rs and keys.rs, directly affecting cryptography and key handling.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer, muse-spark-1.3-contributor — rust-quality (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Single stage: Phase 1 and Phase 2 reviewed this head side by side, with no blocker gate between them (triage tier)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — architecture-layering (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — ffi-engineer (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — security-auditor (completed, effort xhigh); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.

In `packages/rs-platform-wallet/src/wallet/shielded/keys.rs`:
- [SUGGESTION] packages/rs-platform-wallet/src/wallet/shielded/keys.rs:310-313: Keep wallet-local fresh addresses out of the per-contact range
  For an identity shielded account, `fresh_address_from` samples all 88 index bits and rejects only zero, so approximately half its results pass this new contact-range filter. The linked DIP's Identity Shielded Accounts section reserves `1..2^32-1` for wallet-local receiving addresses, `2^32..2^87-1` for future use, and the upper half exclusively for derived contact addresses. The documented requirement to match a returned index against an issued request prevents immediate false attribution, but does not preserve that partition. Provide a DIP-compliant wallet-local allocation path restricted to nonzero 32-bit indices for identity accounts, and test that its addresses return `None` from `contact_index_of`. Ordinary shielded accounts need not inherit this identity-specific restriction.

Comment on lines +310 to +313
self.incoming_viewing_key
.diversifier_index(address)
.map(|index| *index.as_bytes())
.filter(is_shielded_contact_index)

@thepastaclaw thepastaclaw Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Resolved at 240d13ca; see the replies below.

🟡 Suggestion: Keep wallet-local fresh addresses out of the per-contact range

For an identity shielded account, fresh_address_from samples all 88 index bits and rejects only zero, so approximately half its results pass this new contact-range filter. The linked DIP's Identity Shielded Accounts section reserves 1..2^32-1 for wallet-local receiving addresses, 2^32..2^87-1 for future use, and the upper half exclusively for derived contact addresses. The documented requirement to match a returned index against an issued request prevents immediate false attribution, but does not preserve that partition. Provide a DIP-compliant wallet-local allocation path restricted to nonzero 32-bit indices for identity accounts, and test that its addresses return None from contact_index_of. Ordinary shielded accounts need not inherit this identity-specific restriction.

source: gpt-6.1-sol (phase2-reviewer: general)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in fafe132 for every account: fresh_address now redraws an index of 2^87 or above, as it already did index 0, so a fresh address has 87 random bits and contact_index_of returns None for all of them (new test should_redraw_a_fresh_index_in_the_contact_range). I did not add a separate 32-bit path for identity accounts: this change has no notion of an identity account yet, and a 32-bit random index would start repeating addresses after tens of thousands of draws. Whether the DIP keeps its 32-bit wallet-local band or widens it to everything below 2^87 is being settled on the DIP.

🤖 Addressed by Claude Code

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved (re-reviewed at 240d13ca): Your redraw loop now rejects zero and every index at or above 2^87, so fresh addresses cannot be recognized by contact_index_of. The current DIP policy represented by this change permits wallet-local indices below 2^87, so the earlier request for a separate 32-bit allocation path no longer applies.

@github-actions

Copy link
Copy Markdown
Contributor

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-self-review Waiting for the author to post /self-reviewed label Nov 12, 2026
@github-actions github-actions Bot removed the waiting-bots Waiting for the review bots to report on this head label Nov 12, 2026
…ntact range

`fresh_address` drew its diversifier index from the whole 88-bit space, so
about half of the addresses it returned sat at 2^87 or above, the half that
holds the addresses of DashPay contact requests. Such an address was the
account's own but read as a contact's address that matched no request.

An index in that range is now redrawn, as index 0 already was. A fresh
address still has 87 random bits, and `contact_index_of` returns `None` for
every one.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added waiting-bots Waiting for the review bots to report on this head and removed waiting-self-review Waiting for the author to post /self-reviewed labels Nov 12, 2026
The DIP no longer keeps 1 to 2^32 - 1 for a wallet's own addresses: they
take any index below 2^87.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@thepastaclaw thepastaclaw left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 1 + Phase 2

Updated after discussion: 1 finding(s) of this review were settled in the inline threads.

  • ✅ Withdrawn: 🟡 Use the protocol account-reference type at the derivation boundary

Static review found no blocking correctness, security, or layering defects. Two non-blocking issues remain: the new derivation APIs accept account-reference values that cannot be represented by the current u32 protocol field, and the fresh-address documentation is unnecessarily contradictory. Rust workspace tests and the JavaScript build were still running in the supplied CI snapshot; completed relevant checks passed.

🟡 1 0 suggestion(s) | 💬 1 nitpick(s)

Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.

Review provenance

Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: architecture-layering); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: ffi-engineer); reviewer 5: gpt-6.1-sol (agent: phase2-reviewer, role: platform-versioning); reviewer 6: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); reviewer 7: muse-spark-1.3-contributor (agent: phase1-reviewer, role: rust-quality); reviewer 8: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: critical by gpt-6.1-sol (effort low) — The large diff implements cryptographic key derivation, shielded-address encryption/decryption, and wallet viewing-key address derivation in shielded_address.rs and keys.rs, directly changing critical cryptography and key-handling surfaces.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer, muse-spark-1.3-contributor — rust-quality (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Single stage: Phase 1 and Phase 2 reviewed this head side by side, with no blocker gate between them (triage tier)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — architecture-layering (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — ffi-engineer (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — platform-versioning (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — security-auditor (completed, effort xhigh); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.

In `packages/rs-platform-encryption/src/shielded_address.rs`:
- [SUGGESTION → WITHDRAWN in discussion; do not fix] packages/rs-platform-encryption/src/shielded_address.rs:90: Use the protocol account-reference type at the derivation boundary
  `account_reference` is a `u32` in the contact-request model, wallet flow, and contract schema, but this public derivation API accepts `u64`; `AccountViewingKeys::contact_address` repeats the same broader type at line 291. That permits callers to derive addresses for values above `u32::MAX`, even though no valid contact request can publish or later reproduce those values. Keep the required eight-byte little-endian DIP encoding internally, but accept `u32` at both public boundaries and widen it only when building the hash preimage.

In `packages/rs-platform-wallet/src/wallet/shielded/keys.rs`:
- [NITPICK] packages/rs-platform-wallet/src/wallet/shielded/keys.rs:220-225: Correct the fresh-address range documentation
  The comment first describes the returned index as below `2^87`, then uses an awkward `and so is an index of 2^87 or above` construction that can be read as contradicting the stated result rather than describing the rejected draw. Clarify that indices at or above `2^87` are redrawn, so the returned index is always below the contact range.

index_key: &[u8; 32],
owner_id: &[u8; 32],
to_user_id: &[u8; 32],
account_reference: u64,

@thepastaclaw thepastaclaw Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Withdrawn at 240d13ca; see the replies below.

🟡 Suggestion: Use the protocol account-reference type at the derivation boundary

account_reference is a u32 in the contact-request model, wallet flow, and contract schema, but this public derivation API accepts u64; AccountViewingKeys::contact_address repeats the same broader type at line 291. That permits callers to derive addresses for values above u32::MAX, even though no valid contact request can publish or later reproduce those values. Keep the required eight-byte little-endian DIP encoding internally, but accept u32 at both public boundaries and widen it only when building the hash preimage.

source: gpt-6.1-sol (phase2-reviewer: rust-quality)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping u64 here on purpose. The DIP defines the input as the accountReference the document publishes, encoded as an unsigned 64-bit integer, and DashPay v3 declares that property as an integer with a minimum of 0 and no maximum, stored in 64 bits. A consensus-valid contact request can therefore publish a value above u32::MAX, and a u32 parameter could not derive or recompute its address. Callers that hold the DIP-15 32-bit value widen it without loss.

🤖 Addressed by Claude Code

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right: contactRequest.accountReference in the v3 schema has minimum: 0 and no maximum, unlike the explicitly u32-bounded key indices. I conflated the wallet's current u32 model with the contract's allowed range, so my claim that values above u32::MAX cannot be published was wrong. Keeping u64 here preserves those values and the documented eight-byte derivation encoding; I withdraw the suggestion.

Withdrawing this finding.

@github-actions

Copy link
Copy Markdown
Contributor

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed and removed waiting-bots Waiting for the review bots to report on this head labels Nov 12, 2026
Co-authored-by: Lil Claw <pasta+claw@dashboost.org>
@QuantumExplorer
QuantumExplorer merged commit 18e6cad into v5.1-dev Nov 12, 2026
6 of 7 checks passed
@QuantumExplorer
QuantumExplorer deleted the claude/dashpay-shielded-address-primitives branch November 12, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-self-review Waiting for the author to post /self-reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants