Skip to content

fix(tokens): retain the creator when opening a registered contract - #1179

Draft
Claudius-Maginificent wants to merge 1 commit into
fix/token-json-exportfrom
fix/token-receipt-navigation
Draft

Claudius-Maginificent wants to merge 1 commit into
fix/token-json-exportfrom
fix/token-receipt-navigation

Conversation

@Claudius-Maginificent

Copy link
Copy Markdown
Collaborator

TL;DR

Opening a created token's contract no longer strands Token Creator on the keyword-search screen. Returning to the creator restores its receipt and draft, including Create another token.

User story

As a token creator, I can inspect my registered contract and return to its confirmation without restarting the application or losing my work.

Scenario

Actual behavior

After Open contract, choosing Token Creator shows keyword search while the creator remains selected in the sidebar.

Expected behavior

The contract opens in a separate preview. Returning to Token Creator reveals the retained receipt and allows starting another draft.

Detailed discussion

Stacked on #1178 (fix/token-json-export), which includes #1177. The preview owns its contract-fetch task instead of changing the persistent creator's internal mode. Closing the preview discards its late fetch result or error without changing the creator.

Testing

  • The two regression tests failed against the previous behavior, then passed with the fix; two existing navigation tests also pass (4/4, none ignored).
  • Formatting, scoped Clippy and binary build pass. Independent Astra review found no remaining issues.
  • Real desktop GUI verified receipt restoration, fetching the correct contract, returning to the retained creator receipt and Create another token, without another payment.
  • Late/error/network-switch routing is covered by tests and source review. Full workspace CI and other operating systems were not run locally.

🤖 Co-authored by Claudius the Magnificent AI Agent

Open contract details on their own screen and dispatch the fetch from that
screen. Keep the creator's draft and receipt intact when returning, and keep
closed preview results from completing a later preview.

Cover receipt return, another draft, stale results and fetch failures with
isolated UI tests that capture every backend request.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@thepastaclaw

Copy link
Copy Markdown
Collaborator

🕓 Review not started yet because this PR is a draft.

  • Request normal review — click when the PR is ready for review.
  • Request priority review — click to move this review to the front of the queue.

Commit 77c2a6c. Normal review starts when eligible; priority review starts as soon as a slot is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants