Repository navigation
fix(dpns): keep a previous network's contest refresh off the new network - #1156
Conversation
Show published avatars, compact username controls, responsive Home cards, and Profile navigation. Reuse the wallet send form with fixed identity parties and owned-wallet withdrawal destinations. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Keep contacts at the top of the right column beside quick actions. Place left-aligned username cards with setup and payment history, using A05 column proportions and stacked cards in narrow windows. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Preserve the development-branch update alongside the Home layout fix. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Codex GPT-6 <noreply@openai.com>
SDK responses include recipient addresses. Only update balances for Platform addresses registered to the selected wallet, preventing unrelated wallets from offering foreign funds for identity top-ups or transfers. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Codex GPT-6 <noreply@openai.com>
…idle The offline profile-cache test intentionally leaves the avatar request pending. Render bounded frames while checking the pending fetch and preserving assertions for cached, saved, and absent profile data. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Conflict in src/ui/identity/settings.rs: both sides added methods to SettingsTab at the same place. Kept both (focus_section from this branch, usernames_card_mut and accepts_legacy_recovery_result from #1076) and this branch's doc comment on render. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
IDH-004 still described a `Set up your social profile` checklist entry with its own skip affordance. Home renders an optional `Set a display name` step, and the only dismiss control, `Hide this for now`, hides the whole checklist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
…owns The only Move to wallet test ran against a context without wallets and asserted that an external address is refused, so it would also pass if the ownership check refused every address. Register a wallet, take one of its receiving addresses, and drive the production validation and confirmation: the dispatched withdrawal must carry the bound identity, that address and the entered amount. An external address is still refused, and the owned address is refused once its wallet is removed. Nothing is broadcast. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
Every frame of an identity-bound send form restored the binding, which allocated a new box and cloned the identity twice for Send and Move to wallet, and looked up the username again for Top up, even when nothing had changed. The check `validated_send_route` already made is now a shared predicate, and the per-frame call restores only when that predicate fails. Construction, reset and refresh still restore unconditionally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
Home tracked which request its payment preview answered, but not which identity the rows belonged to. The selected identity can change without the hub hearing of it, for example when another screen's identity selector is used and that screen is closed without a refresh. Home then showed the new identity above the previous identity's payments, and the load guard kept the new identity's history from being requested. Home state now records its owner and reconciles it before rendering: content of another identity is dropped and its pending request forgotten, so a late answer is discarded and the new history loads. A refresh for the same identity keeps the preview on screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
…llet Move to wallet opens the shared send form, whose Max for an identity sender always kept back the fee of a transfer between identities. A withdrawal to a Core address costs far more, so Max offered an amount the network refused, and the form only compared the amount with the balance. The reserve now follows the destination: a Core address keeps back the withdrawal estimate, every other destination keeps what it kept before. Max and send validation read the same value, and a withdrawal that would leave too little for the fee is refused before the confirmation, naming the highest amount that works. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
…s app Send from Identity Home dispatched its transfers without a signing key. The backend passed that on, and the SDK then takes the identity's first TRANSFER key, including a disabled one, without asking whether the local signer holds it. An identity with an earlier disabled key, or one imported with only a later key, could not send. Transfers to an identity and to Platform addresses now resolve the key before any network call: an active TRANSFER key the signer can use, lowest id first. An explicitly requested key that is unusable is refused rather than replaced, and a missing key is reported as its own error. The send form resolves the same key, passes it along, and refuses before the confirmation when there is none. This also covers the MCP transfer tools, which dispatch without a key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
…registration The fixture wired the wallet backend before registering its wallet, which starts a background registration next to the awaited one, and then polled for the addresses. Registering the wallet first leaves the awaited calls as the only registration, so the owned address is available as soon as they return and the wait is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
Home and the Contacts tab share one ContactsState, and the hub reset it only for identity changes it made itself. Selecting another identity on a screen opened from the hub (Add contact, then Cancel) left the previous identity's contacts and requests on screen under the new identity, with the load slot still claimed, so the new identity's lists never loaded and Accept paired the new identity with the old identity's request. ContactsState now records the identity its lists belong to. Home and the Contacts tab bind it before reading or loading: on a change the lists are dropped and the load re-armed. Paid-action guards are keyed by request and survive the change, so a request both identities can see stays guarded while its action is still running. The Home payments test no longer depends on which frame its load goes out in: the contact load now takes the first frame after such a change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…latform address The shared send form reserved the identity-to-identity transfer fee for a Platform address destination, while the task it dispatches estimates the larger transfer-to-addresses fee, and it accepted any amount up to the full balance. The transfer screen it replaced used the transfer-to-addresses estimate for Max, the fee shown and an amount-plus-fee check. Max, the fee preview and the confirmation text now read one reserve that uses the existing transfer-to-addresses estimate for this route, and an amount that leaves less than that fee in the identity is refused before the confirmation, with the highest amount that works. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… took The hub replaces the tab's action with the header's when both produce one in the same frame. A tab that returned its contact or payment-history load on that frame had already claimed the load's one dispatch slot, so the load never ran, and cancelling the screen the header opened returns to the hub without refreshing it. Home and the Contacts tab now take a `may_load` flag. The hub clears it on a frame where the header returned an action, so the slot stays free and the load goes out on the next frame. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er screen Home asks for its payment history once per arrival and accepts only the answer to that request. An answer that arrived while Send or Top up covered the hub went to the covering screen, which ignores it; Cancel returns without refreshing, so the preview stayed empty or stale until an explicit refresh. The app now forwards a payment history result to the hidden hub as it does for profile results. The hub still records only the answer to its own request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The existing tests call the key resolver directly, so they would still pass if a transfer task stopped calling it. This one dispatches both transfer tasks through `run_identity_task` against a mock SDK, with no usable key and with an explicitly requested unusable one, and expects the dedicated error: a task that got past the resolver would fail on the mock instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the list The preview took six entries from a vector of every matching contact, built again on each frame. `ContactsState` now offers the matches as an iterator, which the preview bounds before reading; the Contacts tab keeps the collected list where it needs the count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The hub asks for its contacts and contact requests once per arrival, and Home now shows them. Answers that arrived while Send or Top up covered the hub went to the covering screen, which ignores them; Cancel returns without refreshing, so Home's contact preview stayed empty until an explicit refresh. The app now forwards both results to the hidden hub, next to the payment history. The hub keeps dropping lists loaded for an identity other than the one it shows, which the new test covers with a result for another identity. The payment history test shares the new helper that covers the hub with the Send screen and cancels back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in #1077, #1078 and #1079. No conflicts: docs/user-stories.md and src/ui/identity/settings.rs merged automatically. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
Home's Top up now opens the shared send form, which numbered a wallet-funded top-up by the count of stored top-ups. A stored history can have gaps, so with entries 0 and 2 the form chose 2 and the finished top-up replaced that entry in the identity's stored history; every later one did the same. The screen it replaced used the highest stored index plus one. `QualifiedIdentity::next_top_up_index` is now the one place that chooses the index: one past the highest stored, or the lowest free one when the highest possible index is taken, so it can neither overflow nor reuse an entry. The shared send form and the older top-up screen both use it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The identity top-up tool numbered a top-up by the count of stored top-ups, so a history with a gap had an entry replaced, as in the shared send form. It now uses `QualifiedIdentity::next_top_up_index`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…decided A hub frame merges actions from the top bar, the sidebar, the header, the tab, the breadcrumb and a confirmation dialog, and the last non-empty one wins. The tabs returned their data loads from rendering, claiming the load's one dispatch slot on the spot. A load could then replace a sidebar or top bar click made on the same frame, and a breadcrumb entry applied after the tab could replace a load whose slot was already claimed, so it never ran. The earlier header-only flag covered one of those sources. Home and the Contacts tab no longer load while rendering. The hub asks the rendered tab for its due load at the end of the frame, only when nothing produced an action, and nothing after that point replaces an action. So a click anywhere keeps its frame and a claimed load is always the action returned. The load binds the lists to the selected identity first, so an identity chosen in the breadcrumb is loaded once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on this device The transfer key resolver took any stored key entry for a usable key. An entry that only refers to a wallet needs that wallet on this device: without it an earlier such key was chosen over a later key whose material is here, and an identity with only such a key reached the confirmation, to fail when the transfer was signed. The resolver now asks whether the private half can be obtained. The rule is the one username registration already uses; it moves to `QualifiedIdentity` so both read it from one place. A locked wallet still counts, as the app asks for its password when it signs. `can_sign_with` is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The app hands every failure to the visible screen as a message without a task context, and Wallet Send took any of them for the failure of its own send: it left the waiting state and showed the filled form again while the payment was still running, so the user could confirm it a second time. Home starts loads of its own right before Send or Top up opens, which makes such a failure likely. A confirmed send now goes out under a dispatch context of its own and the screen remembers it. While it waits, only a failure carrying that context ends the wait; other failures are still reported by the banner. The send no longer joins a task batch, which cannot carry a context: an asset-lock maximum lookup due in the same frame is asked for on the next one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… form runs Home's Top up opens the shared send form, which remembered a running top-up only on the screen. Leaving the waiting form by its breadcrumb destroyed that record, so a reopened form offered the same identity another top-up while the first still ran: funds would leave twice, and both could be recorded under one index. The form now records its top-ups in the registry Add Funds keeps outside any screen, and refuses a top-up of an identity that has one in flight. The app releases the entry on that top-up's own result, as it does for Add Funds, and hands the result to the form that waits on it. Either screen holds back while the other's top-up runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Wallet Send tests entered the waiting state through a hook that took a hand-made context, which no dispatch ever produced. They now go through `dispatch_send`, the path a confirmed send takes, so the screen waits on a dispatch of its own and the tests keep holding when the screen relies on it. The unused hook is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…acy encrypted format Early versions kept a private key in a per-key encrypted format. This version stores such an entry but cannot open it, with or without a password, yet the transfer key resolver counted it as usable: an earlier such key was chosen over a later key that can sign, and an identity with only such a key reached the confirmation, to fail when the transfer was signed. The shared rule now says such a key cannot be obtained. A key in the vault and a key also held in a readable way stay eligible. Username registration keeps reporting such a key as ready, as before: it needs a status and guidance of its own first, and the note saying so moves to where that decision is made. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Ready for review — files with no dedicated owner: lklimek. |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 2 only (no Phase 1 for this repository)
The network attribution fix correctly suppresses contest-refresh notifications while a different network is active, and the CI code checks are green. One blocking race remains: switching away and then back to the same network allows an old mid-task refresh notification to be treated as current and terminate a newly started refresh; the PR should also add generation/request correlation. The backend tests should additionally assert that the emitted result carries the source context's network.
🔴 1 blocking | 🟡 1 suggestion(s)
Review provenance
Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
normalbygpt-6.1-sol(effort low) — This is a focused but cross-cutting behavioral fix spanning async task results, network-aware routing, UI refresh state, and integration tests, without touching a critical surface such as funds, cryptography, consensus, or storage migrations. - Phase 1 reviewers: not run (disabled for this repository)
- Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— rust-quality (completed, effort high); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `src/app/result_delivery.rs`:
- [BLOCKING] src/app/result_delivery.rs:158-162: Reject stale contest results after switching back to the same network
The fallback route identifies an unattributed contest-refresh result only by its `Network`, so it cannot distinguish refresh generations. A Testnet refresh can remain in flight while the app switches to Mainnet, switches back to Testnet, and starts a new Testnet refresh. The old `RefreshedDpnsContests` result has `BackendTaskContext::Unknown`; because its network now equals the active network, this code routes it as `Visible` and the observer path also receives it when the voting panel is hidden. `VotesPanelResult::ContestsRefreshed` then unconditionally calls `refresh()`, clears the progress banner, and marks the newly started refresh complete. The dispatched final result is correlated by its dispatch owner, but this mid-task result is not. Carry a refresh generation/request identifier through the mid-task result, or use an equivalent network-context identity, and only settle the matching pending refresh.
In `src/backend_task/contested_names/mod.rs`:
- [SUGGESTION] src/backend_task/contested_names/mod.rs:1710-1713: Assert the emitted refresh result carries the source network
The routing fix depends on `query_dpns_contested_resources` stamping `RefreshedDpnsContests` with the network of the `AppContext`, but both backend tests only match `RefreshedDpnsContests { .. }`. The routing test constructs the result synthetically, so the actual producer could emit an incorrect network while all current tests still pass. Extract the emitted result in this test and in the analogous background-refresh test, then assert that its `network` equals `context.network()`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
|
Waiting for bot review — coderabbitai skipped after its own rate limit · thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
thepastaclaw
left a comment
There was a problem hiding this comment.
Re-review — Final validation — Phase 2 only (no Phase 1 for this repository)
The PR correctly carries the source network on mid-task contest refresh results and prevents refreshes from a switched-away network from reaching the active screen or observers. The supplied build, test, lint, and platform checks pass; the remaining same-network refresh-generation race and producer assertion gap are explicitly tracked for #1159 and do not block this targeted fix.
🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)
Review provenance
Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
normalbygpt-6.1-sol(effort low) — This is a contained but cross-cutting Rust logic change affecting backend result routing, network attribution, UI refresh state, and integration tests, without touching a critical surface such as funds, cryptography, consensus, or storage migrations. - Phase 1 reviewers: not run (disabled for this repository)
- Fresh final gate: an independent Phase-2 review ran after iterative findings were reconciled
- Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— rust-quality (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— rust-quality (completed, effort high); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.
No unresolved findings remain from the prior review on this head.
|
Ready for review — files with no dedicated owner: lklimek. |
|
Policy satisfied — this can merge. |
TL;DR
A name-contest refresh that ran on the network you just switched away from no longer touches the voting panel on the new network. Before, its late "contests refreshed" signal ended the new network's own refresh early: the "Refreshing name contests…" banner vanished and the Refresh button came back while that refresh was still running. The same refresh's final result could end it too. #1100 (6d2cefd) fixes that path; this PR fixes the mid-task signal.
User story
Not a new user-facing feature. The fix keeps NET-001 (switch networks) honest: nothing still running for the previous network changes what the new network's screens show.
Scenario
Detailed discussion
Root cause:
query_dpns_contested_resourcesreports stored contests with a mid-taskTaskResult::unattributed_success(RefreshedDpnsContests). Both the user'sQueryDPNSContestsand the background refresh run through it. The result carriesBackendTaskContext::Unknown, so #1100's network-aware routing had nothing to go on. The result went to the screen in view, or to the voting panel's observer (MasternodesScreen::observe_backend_result), whichever network it came from. The previous review round recorded this as the known "unattributed mid-task result" limitation.Changes:
BackendTaskSuccessResult::RefreshedDpnsContestsbecameRefreshedDpnsContests { network }, filled with the refreshing context's network (src/backend_task/mod.rs,query_dpns_contested_resources.rs).dpns_contests_refresh_network()reads it back.AppState::take_result_route(src/app/result_delivery.rs) checks the context for a network (the scheduled-vote sweep, from refactor(app): separate task routing, domain state, and shutdown responsibilities #1100) or the result. If that network isn't the active one, the route isResultRoute::PreviousNetwork(None), which reaches no screen and no observer. A refresh on the active network routes as before (Visible). The module doc insrc/app/request_routing.rsnames both cases.RequestOwnersentry. Stamping the dispatch context on a mid-task result would let that result take the entry, and the task's final result would then lose its sender.end_previous_network_request. The voting panel used to stop any contest refresh on that error. In refactor(app): separate task routing, domain state, and shutdown responsibilities #1100, 6d2cefd makes it stop only the refresh it dispatched, tracked with aPendingRequest. refactor(app): separate task routing, domain state, and shutdown responsibilities #1100 also adds thetesting-only seams this PR's test uses (DPNSScreen::begin_contest_refresh_for_test,contest_refresh_in_progress_for_test,contest_refresh_banner_live_for_test).Not changed:
Progressupdates and other mid-task results still carry no network. They keep the documented limitation.Testing
request_routing::a_contest_refresh_from_the_previous_network_leaves_the_voting_panel_alone. The voting panel starts a refresh, the network switches, and the panel starts its own refresh on the new network. The previous network's refresh then ends as a real refresh does: first its mid-taskRefreshedDpnsContests, then its dispatch's final result. The new refresh keeps running and keeps its progress banner, with the panel both in view and hidden behind another root screen (the observer path). ARefreshedDpnsContestsfor the active network then ends it and takes the banner down. RED with only the mid-task result, before the route change: "the previous network's refresh leaves the new one running (in view: true)" (ledger2aa59e32650a6d83da05f21ef07e1a7a, exit 101).cargo test --test kittest --all-features -- request_routing masternode_tab: 51 passed (ledgerfa314a2caab5998cd183f2cb459456bf).cargo test --lib --all-features -- app:: contested_names dpns_contested_names_screen: 309 passed (ledgerce36782a2174df08b6921b017c127423).cargo clippy --all-features --lib --test kittest -- -D warningsclean (ledger7019545d700e2c182526699d8c1206ea);cargo fmt --all -- --checkclean.🤖 Generated with Claude Code
https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
PR Hygiene ·
eaf6e39src/app/request_routing.rs,src/app/result_delivery.rs,src/backend_task/contested_names/mod.rsand 4 more) — approved by lklimekWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.