Skip to content

fix(app): keep a previous network's background events and a request's progress where they belong - #1159

Open
Claudius-Maginificent wants to merge 101 commits into
v1.0-devfrom
fix/backend-event-isolation
Open

Claudius-Maginificent wants to merge 101 commits into
v1.0-devfrom
fix/backend-event-isolation

Conversation

@Claudius-Maginificent

@Claudius-Maginificent Claudius-Maginificent commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

TL;DR: Background work that belongs to the network you left no longer touches the screens of the network you are on. This covers a deposit the old network's wallet saw, its balance refresh, a search's progress, and one failed step of a contest refresh. A progress message now reaches the screen that started the work, even while another screen covers it. Progress never ends the wait; only the operation's own result does.

User story

As a user who switches networks or navigates while something runs, I want each screen to show only its own network's and its own operation's state, so that a late event from elsewhere cannot advance a form, flash a banner or end a running refresh.

Scenario

Base flow

On Testnet, open Load Identity → Search by wallet, then open another screen on top. Or switch to Mainnet while a Testnet search, contest refresh or wallet sync is still running.

Actual behavior

Progress updates whichever screen is visible. After a network switch, Testnet events still reach Mainnet:

  • a deposit advances Mainnet's Add Funds form;
  • a balance push lands in Mainnet's wallets;
  • DashPay detection runs against Mainnet's contacts;
  • a failed contest sub-query shows a banner on Mainnet.

Expected behavior

Progress updates the covered form that started the search. After the switch, Mainnet's forms stay idle, no Testnet banner appears, and Mainnet's own refresh keeps running. A Testnet deposit leaves Mainnet's Add Funds waiting, and a Testnet balance push lands in Testnet's wallet only. Each operation's own result still ends it exactly as before.

Detailed discussion

Stacked on #1156; merge that first. #1157 also edits src/app.rs. The edits here are local to the DashPayIncomingDetected, PlatformReadyDiscoverIdentities, PlatformAddressSyncPushed and Progress arms and one guard in the generic error arm, so whichever merges second resolves a small conflict.

What was done

  • Wallet-backend events carry their network. The EventBridge is created per network and tags its events with BackendTaskContext::WalletSync { network }. This covers received UTXOs, incoming DashPay payments, Platform address balance pushes, and identity discovery on Platform ready.
    • After a switch, the router sends them to PreviousNetwork(None): no screen and no observer.
    • Their data is applied to their own network's context (AppState::network_context_of). DashPay detection is dispatched on that context, under the event's context, so its outcome is network-guarded too.
  • Mid-task reports are interim. Progress, DPNS end-time and contender sub-query errors, ScheduledVotesInProgress, FetchedNonce and ProofErrorLogged carry BackendTaskContext::Interim { network, request }.
    • The request comes from a tokio task-local that task_dispatch::spawn sets. Both DPNS sub-query tokio::spawns propagate it.
    • Routing uses RequestOwners::peek, never take, so the owner stays on record. operation() leaves Interim wrapped, so no PendingRequest settles on progress.
    • A previous network's interim raises no banner. Outside a dispatch (MCP, start-up, tests), reports fall back to Unknown, which is the earlier behaviour, and a debug log records it.
  • scheduled_vote_sweep_network is generalised to undispatched_network, which covers the sweep, background refresh, WalletSync and Interim.
  • request_routing.rs docs drop the "known limitation" about progress. App-started tasks with an Other context still go to the visible screen after a switch; that limitation is documented.

Testing

  • Kittest, each failing first with the routing stashed:
    • a_balance_push_from_the_previous_network_updates_only_that_networks_wallet
    • a_deposit_seen_by_the_previous_network_leaves_the_new_networks_add_funds_waiting
    • a_progress_report_reaches_the_covered_form_that_started_the_search_and_ends_nothing
    • a_sub_query_failure_of_a_contest_refresh_ends_nothing_and_stays_on_its_network
    • an_older_refreshs_failed_step_leaves_the_newer_refreshs_banner_up
    • a_progress_report_of_a_closed_form_raises_no_banner_and_ends_nothing
    • a_progress_report_from_the_previous_network_leaves_the_new_networks_form_alone
  • Unit:
    • the bridge names its network;
    • task-local scope, fallback outside a dispatch, and a spawned subtask;
    • an interim names its request without a dispatch id;
    • a running request's report leaves its owner on record.
  • Local runs: clippy --all-features --all-targets -D warnings clean; 417 lib tests and 74 kittests in the touched areas pass; cargo fmt --check clean.

Breaking changes

None for users. Internal:

  • scheduled_vote_sweep_network becomes undispatched_network;
  • new BackendTaskContext::{WalletSync, Interim};
  • unattributed_error is test-only.

Attribution

🤖 Generated with Claude Code

🤖 Co-authored by Claudius the Magnificent AI Agent

PR Hygiene · 35b681d

  • Bots — coderabbitai skipped after its own rate limit · thepastaclaw ✓
  • Self-review — not asked of a bot author
  • Build green
  • Approvals
    • files with no dedicated owner (src/app.rs, src/app/request_routing.rs, src/app/result_delivery.rs and 14 more) — lklimek

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

lklimek and others added 30 commits October 12, 2026 12:26
Show published avatars, compact username controls, responsive Home cards, and Profile navigation. Reuse the wallet send form with fixed identity parties and owned-wallet withdrawal destinations.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Keep contacts at the top of the right column beside quick actions. Place
left-aligned username cards with setup and payment history, using A05
column proportions and stacked cards in narrow windows.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Preserve the development-branch update alongside the Home layout fix.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
SDK responses include recipient addresses. Only update balances for
Platform addresses registered to the selected wallet, preventing unrelated
wallets from offering foreign funds for identity top-ups or transfers.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
…idle

The offline profile-cache test intentionally leaves the avatar request
pending. Render bounded frames while checking the pending fetch and
preserving assertions for cached, saved, and absent profile data.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Conflict in src/ui/identity/settings.rs: both sides added methods to
SettingsTab at the same place. Kept both (focus_section from this branch,
usernames_card_mut and accepts_legacy_recovery_result from #1076) and this
branch's doc comment on render.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
IDH-004 still described a `Set up your social profile` checklist entry
with its own skip affordance. Home renders an optional `Set a display
name` step, and the only dismiss control, `Hide this for now`, hides the
whole checklist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
…owns

The only Move to wallet test ran against a context without wallets and
asserted that an external address is refused, so it would also pass if the
ownership check refused every address.

Register a wallet, take one of its receiving addresses, and drive the
production validation and confirmation: the dispatched withdrawal must carry
the bound identity, that address and the entered amount. An external address
is still refused, and the owned address is refused once its wallet is removed.
Nothing is broadcast.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
Every frame of an identity-bound send form restored the binding, which
allocated a new box and cloned the identity twice for Send and Move to
wallet, and looked up the username again for Top up, even when nothing had
changed.

The check `validated_send_route` already made is now a shared predicate, and
the per-frame call restores only when that predicate fails. Construction,
reset and refresh still restore unconditionally.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
Home tracked which request its payment preview answered, but not which
identity the rows belonged to. The selected identity can change without the
hub hearing of it, for example when another screen's identity selector is
used and that screen is closed without a refresh. Home then showed the new
identity above the previous identity's payments, and the load guard kept the
new identity's history from being requested.

Home state now records its owner and reconciles it before rendering: content
of another identity is dropped and its pending request forgotten, so a late
answer is discarded and the new history loads. A refresh for the same
identity keeps the preview on screen.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
…llet

Move to wallet opens the shared send form, whose Max for an identity sender
always kept back the fee of a transfer between identities. A withdrawal to a
Core address costs far more, so Max offered an amount the network refused,
and the form only compared the amount with the balance.

The reserve now follows the destination: a Core address keeps back the
withdrawal estimate, every other destination keeps what it kept before. Max
and send validation read the same value, and a withdrawal that would leave
too little for the fee is refused before the confirmation, naming the highest
amount that works.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
…s app

Send from Identity Home dispatched its transfers without a signing key. The
backend passed that on, and the SDK then takes the identity's first TRANSFER
key, including a disabled one, without asking whether the local signer holds
it. An identity with an earlier disabled key, or one imported with only a
later key, could not send.

Transfers to an identity and to Platform addresses now resolve the key before
any network call: an active TRANSFER key the signer can use, lowest id first.
An explicitly requested key that is unusable is refused rather than replaced,
and a missing key is reported as its own error. The send form resolves the
same key, passes it along, and refuses before the confirmation when there is
none. This also covers the MCP transfer tools, which dispatch without a key.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
…registration

The fixture wired the wallet backend before registering its wallet, which
starts a background registration next to the awaited one, and then polled
for the addresses. Registering the wallet first leaves the awaited calls as
the only registration, so the owned address is available as soon as they
return and the wait is gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
Home and the Contacts tab share one ContactsState, and the hub reset it only
for identity changes it made itself. Selecting another identity on a screen
opened from the hub (Add contact, then Cancel) left the previous identity's
contacts and requests on screen under the new identity, with the load slot
still claimed, so the new identity's lists never loaded and Accept paired the
new identity with the old identity's request.

ContactsState now records the identity its lists belong to. Home and the
Contacts tab bind it before reading or loading: on a change the lists are
dropped and the load re-armed. Paid-action guards are keyed by request and
survive the change, so a request both identities can see stays guarded while
its action is still running.

The Home payments test no longer depends on which frame its load goes out
in: the contact load now takes the first frame after such a change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…latform address

The shared send form reserved the identity-to-identity transfer fee for a
Platform address destination, while the task it dispatches estimates the
larger transfer-to-addresses fee, and it accepted any amount up to the full
balance. The transfer screen it replaced used the transfer-to-addresses
estimate for Max, the fee shown and an amount-plus-fee check.

Max, the fee preview and the confirmation text now read one reserve that
uses the existing transfer-to-addresses estimate for this route, and an
amount that leaves less than that fee in the identity is refused before the
confirmation, with the highest amount that works.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… took

The hub replaces the tab's action with the header's when both produce one
in the same frame. A tab that returned its contact or payment-history load
on that frame had already claimed the load's one dispatch slot, so the load
never ran, and cancelling the screen the header opened returns to the hub
without refreshing it.

Home and the Contacts tab now take a `may_load` flag. The hub clears it on a
frame where the header returned an action, so the slot stays free and the
load goes out on the next frame.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er screen

Home asks for its payment history once per arrival and accepts only the
answer to that request. An answer that arrived while Send or Top up covered
the hub went to the covering screen, which ignores it; Cancel returns
without refreshing, so the preview stayed empty or stale until an explicit
refresh.

The app now forwards a payment history result to the hidden hub as it does
for profile results. The hub still records only the answer to its own
request.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The existing tests call the key resolver directly, so they would still pass
if a transfer task stopped calling it. This one dispatches both transfer
tasks through `run_identity_task` against a mock SDK, with no usable key and
with an explicitly requested unusable one, and expects the dedicated error:
a task that got past the resolver would fail on the mock instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the list

The preview took six entries from a vector of every matching contact, built
again on each frame. `ContactsState` now offers the matches as an iterator,
which the preview bounds before reading; the Contacts tab keeps the
collected list where it needs the count.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The hub asks for its contacts and contact requests once per arrival, and
Home now shows them. Answers that arrived while Send or Top up covered the
hub went to the covering screen, which ignores them; Cancel returns without
refreshing, so Home's contact preview stayed empty until an explicit
refresh.

The app now forwards both results to the hidden hub, next to the payment
history. The hub keeps dropping lists loaded for an identity other than the
one it shows, which the new test covers with a result for another identity.
The payment history test shares the new helper that covers the hub with the
Send screen and cancels back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in #1077, #1078 and #1079. No conflicts: docs/user-stories.md and
src/ui/identity/settings.rs merged automatically.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
Home's Top up now opens the shared send form, which numbered a wallet-funded
top-up by the count of stored top-ups. A stored history can have gaps, so
with entries 0 and 2 the form chose 2 and the finished top-up replaced that
entry in the identity's stored history; every later one did the same. The
screen it replaced used the highest stored index plus one.

`QualifiedIdentity::next_top_up_index` is now the one place that chooses the
index: one past the highest stored, or the lowest free one when the highest
possible index is taken, so it can neither overflow nor reuse an entry. The
shared send form and the older top-up screen both use it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The identity top-up tool numbered a top-up by the count of stored top-ups,
so a history with a gap had an entry replaced, as in the shared send form.
It now uses `QualifiedIdentity::next_top_up_index`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…decided

A hub frame merges actions from the top bar, the sidebar, the header, the
tab, the breadcrumb and a confirmation dialog, and the last non-empty one
wins. The tabs returned their data loads from rendering, claiming the load's
one dispatch slot on the spot. A load could then replace a sidebar or top
bar click made on the same frame, and a breadcrumb entry applied after the
tab could replace a load whose slot was already claimed, so it never ran.
The earlier header-only flag covered one of those sources.

Home and the Contacts tab no longer load while rendering. The hub asks the
rendered tab for its due load at the end of the frame, only when nothing
produced an action, and nothing after that point replaces an action. So a
click anywhere keeps its frame and a claimed load is always the action
returned. The load binds the lists to the selected identity first, so an
identity chosen in the breadcrumb is loaded once.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on this device

The transfer key resolver took any stored key entry for a usable key. An
entry that only refers to a wallet needs that wallet on this device: without
it an earlier such key was chosen over a later key whose material is here,
and an identity with only such a key reached the confirmation, to fail when
the transfer was signed.

The resolver now asks whether the private half can be obtained. The rule is
the one username registration already uses; it moves to `QualifiedIdentity`
so both read it from one place. A locked wallet still counts, as the app asks
for its password when it signs. `can_sign_with` is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The app hands every failure to the visible screen as a message without a
task context, and Wallet Send took any of them for the failure of its own
send: it left the waiting state and showed the filled form again while the
payment was still running, so the user could confirm it a second time. Home
starts loads of its own right before Send or Top up opens, which makes such
a failure likely.

A confirmed send now goes out under a dispatch context of its own and the
screen remembers it. While it waits, only a failure carrying that context
ends the wait; other failures are still reported by the banner. The send no
longer joins a task batch, which cannot carry a context: an asset-lock
maximum lookup due in the same frame is asked for on the next one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… form runs

Home's Top up opens the shared send form, which remembered a running top-up
only on the screen. Leaving the waiting form by its breadcrumb destroyed that
record, so a reopened form offered the same identity another top-up while the
first still ran: funds would leave twice, and both could be recorded under
one index.

The form now records its top-ups in the registry Add Funds keeps outside any
screen, and refuses a top-up of an identity that has one in flight. The app
releases the entry on that top-up's own result, as it does for Add Funds, and
hands the result to the form that waits on it. Either screen holds back while
the other's top-up runs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Wallet Send tests entered the waiting state through a hook that took a
hand-made context, which no dispatch ever produced. They now go through
`dispatch_send`, the path a confirmed send takes, so the screen waits on a
dispatch of its own and the tests keep holding when the screen relies on it.
The unused hook is removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…acy encrypted format

Early versions kept a private key in a per-key encrypted format. This version
stores such an entry but cannot open it, with or without a password, yet the
transfer key resolver counted it as usable: an earlier such key was chosen
over a later key that can sign, and an identity with only such a key reached
the confirmation, to fail when the transfer was signed.

The shared rule now says such a key cannot be obtained. A key in the vault and
a key also held in a readable way stay eligible. Username registration keeps
reporting such a key as ready, as before: it needs a status and guidance of
its own first, and the note saying so moves to where that decision is made.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preserve request-scoped interim delivery and network-isolated wallet
events alongside the base branch's DPNS paging fixes and runtime test keys.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-authored-by: Codex <noreply@openai.com>
@lklimek
lklimek marked this pull request as ready for review November 3, 2026 15:12
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet · thepastaclaw requested changes — dismiss the review or push a fix. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Nov 3, 2026

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 2 only (no Phase 1 for this repository)

Verified the Phase-2 findings against head 65dc148 and combined them into one confirmed banner-lifecycle defect. Interim failures preserve the request and busy state but still dismiss the running refresh's progress banner through the generic error callback. This was a static review; no builds or tests were run, and Test Suite and Clippy remain pending.

🔴 1 blocking

1 finding(s) not shown inline (the lines are not part of this PR's diff)

🔴 Blocking: Interim failures still dismiss the running contest refresh's progress banner
src/ui/dpns/dpns_contested_names_screen.rs:2766-2769

An active-network contest sub-query failure bypasses the request-aware banner lifecycle. finish_contest_refresh(context) correctly leaves an Interim report unsettled, but AppState's generic error path subsequently calls display_task_error and, for an unhandled error, display_message(Error) (src/app.rs:2399–2458). Masternodes forwards that callback here, where it unconditionally clears refresh_banner. The refresh therefore remains busy with its owner recorded, but its progress banner disappears before the terminal result. After switching away and back, an interim failure from an older refresh on that same network can also clear a newer refresh's banner. This conflicts with the PR's operation-isolation goal. Remove context-free teardown of this banner and leave completion cleanup to the matching terminal context. Extend a_sub_query_failure_of_a_contest_refresh_ends_nothing_and_stays_on_its_network to assert contest_refresh_banner_live_for_test() after the active-network failure, and cover an older same-network refresh reporting while a newer one is pending.

source: gpt-6.1-sol (phase2-reviewer: general)

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — This is an intricate, cross-cutting change to asynchronous event ownership, network isolation and progress routing, but the diff does not change funds movement, cryptography, consensus, peer-facing deserialization or storage migrations.
  • Phase 1 reviewers: not run (disabled for this repository)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort high); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `src/ui/dpns/dpns_contested_names_screen.rs`:
- [BLOCKING] src/ui/dpns/dpns_contested_names_screen.rs:2766-2769: Interim failures still dismiss the running contest refresh's progress banner
  An active-network contest sub-query failure bypasses the request-aware banner lifecycle. `finish_contest_refresh(context)` correctly leaves an `Interim` report unsettled, but AppState's generic error path subsequently calls `display_task_error` and, for an unhandled error, `display_message(Error)` (src/app.rs:2399–2458). Masternodes forwards that callback here, where it unconditionally clears `refresh_banner`. The refresh therefore remains busy with its owner recorded, but its progress banner disappears before the terminal result. After switching away and back, an interim failure from an older refresh on that same network can also clear a newer refresh's banner. This conflicts with the PR's operation-isolation goal. Remove context-free teardown of this banner and leave completion cleanup to the matching terminal context. Extend `a_sub_query_failure_of_a_contest_refresh_ends_nothing_and_stays_on_its_network` to assert `contest_refresh_banner_live_for_test()` after the active-network failure, and cover an older same-network refresh reporting while a newer one is pending.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. and removed waiting-bots Waiting for the review bots to report on this head labels Nov 3, 2026
lklimek and others added 3 commits November 4, 2026 10:51
…ed step

A failed sub-query of a running or older contest refresh reached the
voting panel's display_message, which tore down the refresh banner with
no regard to which request failed. The refresh kept waiting with its
progress banner gone. Only the refresh's own result (or a newer refresh
or a network switch) now takes the banner down.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The progress-routing tests asserted that no global banner exists after a
network switch, which races the connection banner chain sync raises by
itself once SPV starts on the new network ("Looking for peers…"). They
now check for the progress report's own text. Also cover a failed step
keeping the contest refresh's banner up, for the active refresh and for
an older refresh on the same network.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…g its absence

Both progress-routing tests first deliver a report to the open form and
check that its progress banner is found by text, so the later "no
progress banner" assertion cannot pass vacuously.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Claudius-Maginificent

Copy link
Copy Markdown
Collaborator Author

Re latest review-body findings:

Interim failures still dismiss the running contest refresh's progress banner (FIXED): Confirmed: the generic error arm calls display_message(Error) for an unhandled failure, and DPNSScreen::display_message cleared refresh_banner regardless of which request failed. The override is gone (the trait default is a no-op); the banner's teardown is now only finish_contest_refresh for the matching request, a newer refresh, or a network switch (src/ui/dpns/dpns_contested_names_screen.rs:592-603). a_sub_query_failure_of_a_contest_refresh_ends_nothing_and_stays_on_its_network asserts the banner stays live, and the new an_older_refreshs_failed_step_leaves_the_newer_refreshs_banner_up covers an older same-network refresh. Both were RED before the fix. Fixed in 76d0c5b (tests: a47f403).

Test Suite run 41661466117 (a_progress_report_from_the_previous_network_leaves_the_new_networks_form_alone) (FIXED): A flake in this PR's own test: !MessageBanner::has_global after a switch raced the connection banner ("Looking for peers…") that chain sync raises by itself once SPV starts on the new network. A local probe reproduced it with no delivery at all. Both progress tests now check for the progress text itself (search_progress_banner_shown, tests/kittest/request_routing.rs:1441-1448). Each test first shows the form's progress banner is found by its text, so the absence check cannot pass vacuously. Routing a previous network's interim report to the visible screen (src/app/result_delivery.rs:157-159) makes that check fail. Fixed in a47f403 and 35b681d.

🤖 Co-authored by Claudius the Magnificent AI Agent

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet · thepastaclaw ✓. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added waiting-bots Waiting for the review bots to report on this head and removed waiting-self-review Waiting for the author to post /self-reviewed bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. labels Nov 4, 2026

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 2 only (no Phase 1 for this repository)

Static verification of the complete diff at 35b681d found no actionable in-scope defects: wallet events retain their originating network, interim reports preserve request ownership, and contest refresh completion remains request-specific. The prior progress-banner finding is fixed, with regression assertions covering failures from both the running refresh and an older refresh. Current GitHub checks show Test Suite, Clippy, and Platform pin guard passing; PR Hygiene remains pending, and no builds or tests were run locally.

🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — This is a cross-cutting asynchronous event and request-routing change with substantial regression coverage, but the diff does not itself alter funds movement, cryptography, consensus, network deserialization, or storage migrations.
  • Phase 1 reviewers: not run (disabled for this repository)
  • Fresh final gate: an independent Phase-2 review ran after iterative findings were reconciled
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort high); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.

No unresolved findings remain from the prior review on this head.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Ready for review — files with no dedicated owner: lklimek.
Full checklist in the description.

@github-actions github-actions Bot added ready-for-human Bots have reported, the author has self-reviewed, and the build is green: this needs a human. bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. and removed waiting-bots Waiting for the review bots to report on this head labels Nov 4, 2026
@github-actions
github-actions Bot requested a review from lklimek November 4, 2026 13:21
@Claudius-Maginificent Claudius-Maginificent added priority: high High priority — address soon priority: medium Medium priority priority: low Low priority — nice to have and removed priority: high High priority — address soon priority: medium Medium priority priority: low Low priority — nice to have labels Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. priority: high High priority — address soon ready-for-human Bots have reported, the author has self-reviewed, and the build is green: this needs a human.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants