Repository navigation
chore(deps): bump dashpay/platform to v5.1-dev 6323a430 - #1153
Claudius-Maginificent wants to merge 17 commits into
Conversation
Saved contracts must survive every dashpay/platform bump. The existing round-trip tests encode and decode with the same dpp, so they cannot see a decoder that stops reading bytes an earlier build wrote. Pin the bytes DET writes today (dpp of platform 575d961fe0) for a user contract and the DPNS, DashPay and token-history contracts at protocol 10 to 15, and check each still decodes to the same contract and re-encodes byte for byte at every later protocol version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
Move dash-sdk, rs-sdk-trusted-context-provider, platform-wallet and platform-wallet-storage from 575d961fe0 to 0d91c133f0, which adds: - platform#5584: an active group config update proposal is reported as success by the SDK. DET's config update task broadcasts through `broadcast_and_wait::<StateTransitionProofResult>` and never matched `ConfigUpdateResult`, so no call site changes. - platform#5578: the stored contract format with compiled document types. DET keeps writing format version 0/1 and reads with the untrusted decoder, which reads a version 2 contract from its schemas; the pinned-bytes test shows contracts saved before the bump still load. - platform#4740: platform-wallet rescans DashPay contact accounts from the contact request height. No API change for DET. - platform#5602: dashmate only. Cargo.lock changes only the platform git source; the wallet-storage migration fingerprint is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
Refresh expected-migration-fingerprint.txt with check-pin-ancestry.sh --update: the fingerprint is unchanged, only the recorded pin moves. List 0d91c133 among the platform revisions that leave the wallet-storage migrations untouched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
The pinned saved-contract bytes covered only a minimal user contract. Contracts users actually save carry more, and a decode break there would make them silently disappear from the app. Add a user contract with a group, mixed-case keywords, a description, `$defs` with a `$ref`, a contested unique index, and a token with group-controlled rules, perpetual and pre-programmed distribution. Its bytes for protocol 10 to 15 were written by the dpp of platform 575d961fe0 (the previous pin), the same way as the existing fixtures, which are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
🕓 Review not started yet because the new head is waiting for the 30-minute push debounce.
Commit dd7d840. Normal review starts when eligible; priority review starts as soon as a slot is available. |
|
Waiting for bot review — coderabbitai not yet · thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 2 only (no Phase 1 for this repository)
The dependency and lockfile updates are internally consistent, and CI reports successful build, test, and lint checks. However, this pin adopts the DashPay historical-rescan behavior while retaining a documented race: an in-flight SPV filter batch can certify coverage after the checkpoint rewind without being invalidated, allowing historical contact payments to remain undetected.
🔴 1 blocking
Review provenance
Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
normalbygpt-6.1-sol(effort low) — This is a broad dependency upgrade with Rust compatibility changes and a substantial stored-contract regression test, but the diff does not itself alter a critical surface such as funds movement, cryptography, consensus, or migrations. - Phase 1 reviewers: not run (disabled for this repository)
- Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— rust-quality (completed, effort high); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `Cargo.toml`:
- [BLOCKING] Cargo.toml:38-41: The pinned DashPay rescan can still skip historical contact payments during an in-flight SPV scan
This pin adopts platform-wallet's contact-account rescan, and DET invokes that path through `WalletBackend::sync_contact_requests` at `src/wallet_backend/dashpay.rs:1054`. In the pinned platform source, `reconcile_dashpay_rescan` lowers `synced_height` but explicitly documents that the rewind does not change the account generation and tracks the resulting race as platform issue #4955 (`packages/rs-platform-wallet/src/wallet/identity/network/payments.rs:302-315`). The pinned dash-spv commit snapshots the wallet's account generation when a batch starts and rejects the batch only if that generation changes (`dash-spv/src/sync/filters/manager.rs:595-607`); otherwise its checkpoint-contiguity check can still certify the batch. The pinned platform contact registration still uses `insert_funds_bearing_account`, while the later platform commit `5adbe62929` changes this path to `add_managed_account` specifically to invalidate filter-scan generation; that commit is not an ancestor of the pinned platform revision. Therefore, if a contact-account registration/rewind occurs while a batch is in flight, the batch can advance the checkpoint over blocks that were scanned before the new contact scripts were monitored, permanently missing an incoming historical payment. Pin a platform/rust-dashcore revision containing the equivalent invalidation fix, or otherwise resolve the upstream race before adopting this rescan behavior.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
Move dash-sdk, rs-sdk-trusted-context-provider, platform-wallet and platform-wallet-storage from 0d91c133f0 to 6323a430c7 (29 commits, platform 5.0.1). rust-dashcore stays at aca02026, matching the platform's own pin. DET adaptations: - platform#4899 adds `VotePoll::YesNoVotePoll`. The DPNS end-time refresh skips yes/no polls, and pages on every poll the end-date index returns, so a page holding only yes/no polls no longer ends the walk before later DPNS contests. `contested_vote_poll_for_document_properties` returns the contested poll directly, which simplifies the DPNS registration classifier. - platform#5561 adds `SdkError::ProtocolVersionNotActive`, raised when the SDK refuses a request the network does not serve yet. It maps to a new `TaskError::PlatformFeatureNotActive` instead of the generic SDK error. Known: platform#5561 also stops the public `Sdk::verify_response_metadata` from recording a verified protocol version, which the test helpers that simulate a proven network version relied on; those tests fail until a replacement seam exists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
Refresh expected-migration-fingerprint.txt with check-pin-ancestry.sh --update: the fingerprint is unchanged (19 migrations), only the recorded pin moves. List 6323a430 among the platform revisions that leave the wallet-storage migrations untouched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
platform#5561 stops the public `Sdk::verify_response_metadata` from recording a verified protocol version: upstream learns one only from a response whose proof and quorum signature it checked itself, and a mock expectation raises only the stored version (platform#5622). The test helpers that simulated a proven network version through that hook no longer moved anything. `AppContext::protocol_version_info` folds a test-only override into the SDK's answer in `cargo test` builds; every other build is unchanged. The override is bound to the SDK it was set for, so a rebuilt connection still starts with nothing proven. `prove_protocol_version` sets it, and the MCP refresh tests install their mock SDK and then prove the newest version through it. The mid-transfer shield test runs its wallet backend on a mock connection at protocol 13 and moves it with a mocked fetch. `a_failed_epoch_fetch_still_advises_updating_for_a_newer_network` still fails: the epoch task reads `Sdk::protocol_version_info` directly, which the override does not reach. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
…pdate advice A failed epoch fetch still degrades to the unavailable-epoch report; the test now asserts that report. It no longer proves a protocol version newer than this build: the task reads the SDK's own verified version, which a mock cannot record since dashpay/platform#5561 (dashpay/platform#5622). A TODO restores the update-advice assertion once it can; the advice itself stays covered by `a_newer_proven_protocol_appends_the_update_advisory`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
|
Waiting for bot review — coderabbitai not yet · thepastaclaw requested changes — dismiss the review or push a fix. Wait for the missing reviews, or a writer can post |
thepastaclaw
left a comment
There was a problem hiding this comment.
Re-review — Final validation — Phase 2 only (no Phase 1 for this repository)
The dependency and API adaptations are internally consistent, and the targeted regression coverage plus completed tests and Clippy checks are successful. However, this pin adopts the DashPay historical-payment rescan while retaining an upstream in-flight rewind race that can permanently miss contact payments; the remaining Test Suite check is still in progress.
🔴 1 blocking
1 carried-forward finding(s) already raised on this PR; not re-posting as new inline comments.
Review provenance
Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
normalbygpt-6.1-sol(effort low) — This is a broad dependency upgrade with substantial adaptations across backend logic, contract persistence compatibility, shielded handling, and MCP resolution, but the diff does not itself change a critical surface such as funds movement, cryptography, consensus rules, or storage migrations. - Phase 1 reviewers: not run (disabled for this repository)
- Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— rust-quality (completed, effort high); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `Cargo.toml`:
- [BLOCKING] Cargo.toml:38-41: The pinned DashPay rescan can still skip historical contact payments during an in-flight SPV scan
(existing thread: https://github.com/dashpay/dash-evo-tool/pull/1153#discussion_r4401257525)
This dependency bump adopts platform-wallet's DashPay contact-account rescan. In the pinned platform source, `reconcile_dashpay_rescan` lowers `synced_height` and arms the rewind barrier, but explicitly notes that a rewind occurring inside an already-running filter batch does not change that batch's account generation (`payments.rs:307-309`). The pinned dash-spv engine snapshots each wallet's account generation when the batch starts and only rejects certification when the generation changes (`manager.rs:595-607`). Consequently, a batch that scanned a range before the rewind can still certify coverage over blocks scanned without the newly watched contact scripts, permanently missing a historical incoming contact payment. The separate contact-registration race is fixed by `note_account_registered`, but the rewind-inside-an-in-flight-batch race remains at `6323a430`, is tracked as dashpay/platform#4955, and the proposed upstream invalidation commit `5adbe62929` is not an ancestor of the pin. Pin a revision containing the upstream fix or add a safe workaround in the owning wallet layer before shipping this rescan behavior.
Stored-contract byte stability is a Platform consensus guarantee: dpp cannot change how existing contracts decode without breaking chain replay. DET does not need its own fixtures for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
|
Waiting for bot review — coderabbitai ✓, 2 threads unresolved — resolve them · thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
…rm-0d91c133 # Conflicts: # src/model/dpns.rs Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Head branch was pushed to by a user without write access
|
Waiting for bot review — coderabbitai not yet · thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Merged |
|
Waiting for bot review — coderabbitai not yet · thepastaclaw ✓. Wait for the missing reviews, or a writer can post |
thepastaclaw
left a comment
There was a problem hiding this comment.
Re-review — Final validation — Phase 2 only (no Phase 1 for this repository)
Reviewed the complete diff at ff28190 and the relevant pinned upstream implementations; no blocking implementation defect was verified. One non-blocking documentation issue remains: this dependency pin already supports compiled contract storage at protocol 15, contrary to the PR's compatibility explanation. This was a static review only; current checks show review and hygiene checks pending, with no Rust build, test, or lint result exposed for this exact head.
🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)
Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.
Follow-up candidates (optional) (1)
New non-blocking observations on code unchanged since the last full review. No inline threads are opened for them and later reviews do not repeat them: fix forward or track separately if they are worth it.
🟡 Suggestion: Correct the compiled-storage activation assessment for this pin
Cargo.toml:27
The PR description says no protocol version selects storage format 2 and assigns the saved-contract follow-up to a future dependency bump. This exact revision already includes platform commit 60cc5f4508 (#5579): packages/rs-platform-version/src/version/dpp_versions/dpp_contract_versions/v7.rs sets contract_storage_serialization_version to 2, and version/v15.rs selects that table. Another dependency bump is therefore not required for this build to encounter compiled contracts on a protocol-15 network. DET still persists schema-only bytes through serialize_to_bytes_with_platform_version in src/context/contract_token_db.rs and reconstructs contracts through versioned_deserialize_untrusted, rather than retaining the proof-authenticated compiled representation. Correct the compatibility discussion to distinguish dependency support from network activation, and explicitly document acceptance of that persistence limitation or link its follow-up instead of placing it behind a future dependency bump. No concrete current-parser divergence was established, so this is a documentation correction rather than a blocking corruption finding.
source: gpt-6.1-sol (phase2-reviewer: general)
Review provenance
Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
normalbygpt-6.1-sol(effort low) — The dependency bump includes cross-cutting Rust API adaptations, poll pagination logic, and typed error handling, but the diff does not itself make large or intricate changes to a qualifying critical surface. - Phase 1 reviewers: not run (disabled for this repository)
- Fresh final gate: an independent Phase-2 review ran after iterative findings were reconciled
- Code unchanged since the last final review (
cae33646): 1 new suggestion(s) listed as follow-up candidates, not posted inline - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— rust-quality (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— rust-quality (completed, effort high); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.
No unresolved findings remain from the prior review on this head.
|
Ready for review — files with no dedicated owner: lklimek. |
|
Policy satisfied — this can merge. |
…rsion `prove_protocol_version` now records only the proven version in a test seam and leaves the SDK's own version as it was. The test still built its contactRequest queries before the first mocked response raised the SDK to the latest version, so DET built later queries against a different system contract than the expectations. The mock lookup missed and fell back to proof parsing of an empty response. Start the mock SDK at LATEST_VERSION with `mock_sdk_at_for` so both sides use the same contract. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Waiting for bot review — coderabbitai not yet · thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
|
/skip-bots |
TL;DR: Moves Dash Evo Tool to the latest Dash Platform development code. Data contracts already saved on your computer keep loading. If you use a feature the network has not switched on yet, the app now says so plainly and asks you to try again after the network upgrade.
Detailed discussion
This is a dependency bump. Its only user-observable change is the plain message for a feature the network has not activated yet, so this PR has no
User storyorScenario. DET adapts to two upstream API changes.What was done
The four dashpay/platform git dependencies (
dash-sdk,rs-sdk-trusted-context-provider,platform-wallet,platform-wallet-storage) move from575d961fe0tov5.1-dev6323a430c7(platform 5.0.1, 33 commits). rust-dashcore stays ataca02026, as upstream pins it;tenderdash-abcimoves to tagv1.8.1with upstream. The wallet-storage migrations are unchanged (19), the migration fingerprint records the new pin, andscripts/migration-fixtures/check-pin-ancestry.shpasses.The upstream changes and what each means for DET:
fix(sdk)!: an active group config update proposal is reported as success.ConfigUpdateResult::GroupActionWithDocumentnow carriesOption<Document>. DET does not callSdk::token_update_contract_token_configurationand never matchesConfigUpdateResult.backend_task/tokens/update_token_config.rsbroadcasts throughbroadcast_and_wait::<StateTransitionProofResult>, which already acceptedVerifiedTokenGroupActionWithDocument(_, None)for an active proposal. So no call site changes. Every other group-gated token result DET matches (mint, burn, transfer, freeze, unfreeze, set price, purchase) already tookOption<Document>. The direct consumer is refactor(tokens)!: send token actions through platform-wallet #1128 (token actions throughplatform-wallet), which runs on a side pin for #5584 today and will be rebased onto this PR.feat(dpp)!: stored contract format with compiled document types. This addsDataContractInSerializationFormat::V2, which only Drive state will hold, plus a separate storage selector (contract_storage_serialization_version), which every protocol version still sets to format 0 or 1. None selects format 2 yet.serialize_to_bytes_with_platform_version. That still followscontract_serialization_version(format 0 or 1), not the new storage selector.versioned_deserialize_untrusted. Its format 0/1 path is a refactor with the same behaviour. A version 2 contract on this path is read from its schemas (into_schema_form), never from compiled types nothing vouches for. The contract visualizer's pasted-bytes decoder takes the same untrusted path.document_schemas_mutorschema_mut, so the breaking API changes do not reach it.VotePollandVotegainYesNoVotePoll/YesNoVote, andVotePoll::unique_id()now takes the platform version. DET adapts:query_ending_times) skips yes/no polls and pages on every poll returned, so a page holding only yes/no polls no longer ends the walk before later DPNS contests. Yes/no polls never reach the DPNS contest screens. Unit tests added.model/dpns.rs) is simplified, because upstream now returns the contested poll directly.SdkError::ProtocolVersionNotActive, instead of banning the node. DET maps it to a newTaskError::PlatformFeatureNotActive: "This feature is not active on the network yet. Try again later, after the network upgrade." It is matched structurally and covered by tests. New stale-node reasons already map toDapiStaleNode.ConnectKeygains a rotation (DET does not use it), and the vault's parent-directory check is relaxed on Android only.Saved-contract compatibility. Contracts DET saved earlier keep loading because dpp cannot change how existing stored bytes decode: that would break Platform's chain replay. DET relies on that consensus guarantee and adds no fixtures of its own.
Test seam for the protocol-version gate
#5561 also stopped the public
Sdk::verify_response_metadatafrom recording a verified protocol version, and mock SDK expectations raise only the stored version, never the verified one (dashpay/platform#5622). DET's test helpers relied on the old behaviour. A#[cfg(test)]override inAppContext::protocol_version_info()now stands in for a proven version in tests:TODO(upstream)pointing to #5622.The mid-transfer shield test moves its mock backend's version through a mocked contract fetch instead. One test,
a_failed_epoch_fetch_degrades_to_the_unavailable_epoch_report, checks the failure-branch report without the newer-protocol advice: that branch reads the SDK's own verified version, which a mock cannot set.a_newer_proven_protocol_appends_the_update_advisorystill covers the advice itself.Known upstream limitation
dashpay/platform#4955 is still open at
6323a430. Contact-account registration already invalidates in-flight filter scans (dashpay/platform#5026). A checkpoint rewind inside an already-running filter batch does not, so that batch can still certify blocks scanned before a new contact account was watched (payments.rs:306-308). The race exists at the old pin too. DET does not work around it.Testing
cargo test --all-features --lib: 3908 passed, 0 failed, on6323a430. This includes the new yes/no-poll and feature-not-active tests.scripts/migration-fixturesand the CI script suites pass. The migration matrix runs in CI, because the fixture password is a CI secret.cargo clippy --all-features --all-targets -- -D warnings: clean.cargo fmt --all -- --check: clean.scripts/migration-fixtures/check-pin-ancestry.sh: the pin is onv5.1-devand the fingerprint matches.Known duplicates left as they are
Cargo.lockstill holds two pre-existing duplicate git crates. This bump does not change either one, and both need upstream work:grovestarkpin (5b9e289, already grovestark's HEAD) depends on grovedb33dfd48(4.0.0), while platform uses2128ea1(6.1.1). Removing the duplicate needs a grovestark release on grovedb 6.1.1. Platform itself does not depend on grovestark.d9e0d24comes in through rust-dashcoreaca0202, and33fcc59throughdpp.Note for the bump that turns on version 2 storage
Not a defect at this pin, since no protocol version stores format 2 yet. Once one does, a contract DET fetched with proofs holds its compiled document types in memory. After a restart, DET's saved copy (format 1) is re-parsed from its schemas by the parser of the running build. #5578 exists so that a document type keeps the meaning it was registered with when a later parser differs. DET's reloaded copy could therefore drift from the network's, so local document validation, form generation and fee estimates could disagree with Platform. The network still validates every transition, so this cannot corrupt state, but the user could see confusing rejections.
The bump that activates version 2 storage should do one of two things: refetch saved contracts with proofs on load, or store the version 2 bytes locally and trust them behind an integrity check.
Breaking changes
None for DET users or the on-disk format.
Prior work
platform-wallet.platform-wallet. It is stacked on this PR's pin and will be rebased onto it.Attribution
🤖 Co-authored by Claudius the Magnificent AI Agent
🤖 Generated with Claude Code
https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
PR Hygiene ·
dd7d840Cargo.lock,Cargo.toml,scripts/migration-fixtures/expected-migration-fingerprint.txtand 11 more) — approved by lklimekWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.Summary by CodeRabbit