Skip to content

chore(deps): bump dashpay/platform to v5.1-dev 6323a430 - #1153

Open
Claudius-Maginificent wants to merge 17 commits into
v1.0-devfrom
chore/bump-platform-0d91c133
Open

Claudius-Maginificent wants to merge 17 commits into
v1.0-devfrom
chore/bump-platform-0d91c133

Conversation

@Claudius-Maginificent

@Claudius-Maginificent Claudius-Maginificent commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

TL;DR: Moves Dash Evo Tool to the latest Dash Platform development code. Data contracts already saved on your computer keep loading. If you use a feature the network has not switched on yet, the app now says so plainly and asks you to try again after the network upgrade.

Detailed discussion

This is a dependency bump. Its only user-observable change is the plain message for a feature the network has not activated yet, so this PR has no User story or Scenario. DET adapts to two upstream API changes.

What was done

The four dashpay/platform git dependencies (dash-sdk, rs-sdk-trusted-context-provider, platform-wallet, platform-wallet-storage) move from 575d961fe0 to v5.1-dev 6323a430c7 (platform 5.0.1, 33 commits). rust-dashcore stays at aca02026, as upstream pins it; tenderdash-abci moves to tag v1.8.1 with upstream. The wallet-storage migrations are unchanged (19), the migration fingerprint records the new pin, and scripts/migration-fixtures/check-pin-ancestry.sh passes.

The upstream changes and what each means for DET:

  • fix(sdk)!: report active group config update proposals as success platform#5584 fix(sdk)!: an active group config update proposal is reported as success. ConfigUpdateResult::GroupActionWithDocument now carries Option<Document>. DET does not call Sdk::token_update_contract_token_configuration and never matches ConfigUpdateResult. backend_task/tokens/update_token_config.rs broadcasts through broadcast_and_wait::<StateTransitionProofResult>, which already accepted VerifiedTokenGroupActionWithDocument(_, None) for an active proposal. So no call site changes. Every other group-gated token result DET matches (mint, burn, transfer, freeze, unfreeze, set price, purchase) already took Option<Document>. The direct consumer is refactor(tokens)!: send token actions through platform-wallet #1128 (token actions through platform-wallet), which runs on a side pin for #5584 today and will be rebased onto this PR.
  • feat(dpp)!: stored contract format with compiled document types platform#5578 feat(dpp)!: stored contract format with compiled document types. This adds DataContractInSerializationFormat::V2, which only Drive state will hold, plus a separate storage selector (contract_storage_serialization_version), which every protocol version still sets to format 0 or 1. None selects format 2 yet.
    • DET writes saved contracts with serialize_to_bytes_with_platform_version. That still follows contract_serialization_version (format 0 or 1), not the new storage selector.
    • DET reads its saved contracts with versioned_deserialize_untrusted. Its format 0/1 path is a refactor with the same behaviour. A version 2 contract on this path is read from its schemas (into_schema_form), never from compiled types nothing vouches for. The contract visualizer's pasted-bytes decoder takes the same untrusted path.
    • Contracts fetched from the network are different. Once Drive stores format 2, the SDK's proof verifier reads them from their compiled types, which the proof authenticates. DET then saves them in format 1 and re-parses them from their schemas on the next load.
    • DET has no exhaustive match on the format enum and does not use document_schemas_mut or schema_mut, so the breaking API changes do not reach it.
    • A side benefit: a contested-field regex that does not compile now matches nothing, where it used to panic.
  • fix(platform-wallet): rescan DashPay contact accounts from the contact request height platform#4740: platform-wallet rescans DashPay contact accounts from the contact request height. Wallet-internal. It recovers payments received before the wallet learned about its outgoing contact request, including one-way contacts. The public API and the persisted format do not change for DET.
  • fix(dashmate): wait out the previous lego container's removal in ssl obtain platform#5602: dashmate only. No effect on DET.
  • feat(platform)!: yes/no masternode vote poll kind with supermajority and minimum voting power platform#4899: yes/no vote polls. VotePoll and Vote gain YesNoVotePoll / YesNoVote, and VotePoll::unique_id() now takes the platform version. DET adapts:
    • The DPNS contest end-time refresh (query_ending_times) skips yes/no polls and pages on every poll returned, so a page holding only yes/no polls no longer ends the walk before later DPNS contests. Yes/no polls never reach the DPNS contest screens. Unit tests added.
    • The DPNS registration classifier (model/dpns.rs) is simplified, because upstream now returns the contested poll directly.
  • fix(sdk)!: refuse requests the network cannot serve yet instead of banning nodes platform#5561: protocol-version gate. The SDK refuses requests for a feature the network has not activated, with SdkError::ProtocolVersionNotActive, instead of banning the node. DET maps it to a new TaskError::PlatformFeatureNotActive: "This feature is not active on the network yet. Try again later, after the network upgrade." It is matched structurally and covered by tests. New stale-node reasons already map to DapiStaleNode.
  • Broadcast and asset locks (upstream internals). A transition refused only because its address nonce is ahead is retried with the same signed bytes on another node. An asset lock whose InstantSend proof is refused is retried with a ChainLock proof. Neither can spend twice: replay and concurrent-spend refusals stay final, and the lock is not consumed twice.
  • Other upstream changes with no DET impact: DIP-13 ConnectKey gains a rotation (DET does not use it), and the vault's parent-directory check is relaxed on Android only.

Saved-contract compatibility. Contracts DET saved earlier keep loading because dpp cannot change how existing stored bytes decode: that would break Platform's chain replay. DET relies on that consensus guarantee and adds no fixtures of its own.

Test seam for the protocol-version gate

#5561 also stopped the public Sdk::verify_response_metadata from recording a verified protocol version, and mock SDK expectations raise only the stored version, never the verified one (dashpay/platform#5622). DET's test helpers relied on the old behaviour. A #[cfg(test)] override in AppContext::protocol_version_info() now stands in for a proven version in tests:

  • It does nothing in non-test builds. No production code changed for it.
  • It is bound to the SDK it was set for, so a rebuilt connection still reports no proven version.
  • It carries a TODO(upstream) pointing to #5622.

The mid-transfer shield test moves its mock backend's version through a mocked contract fetch instead. One test, a_failed_epoch_fetch_degrades_to_the_unavailable_epoch_report, checks the failure-branch report without the newer-protocol advice: that branch reads the SDK's own verified version, which a mock cannot set. a_newer_proven_protocol_appends_the_update_advisory still covers the advice itself.

Known upstream limitation

dashpay/platform#4955 is still open at 6323a430. Contact-account registration already invalidates in-flight filter scans (dashpay/platform#5026). A checkpoint rewind inside an already-running filter batch does not, so that batch can still certify blocks scanned before a new contact account was watched (payments.rs:306-308). The race exists at the old pin too. DET does not work around it.

Testing

  • cargo test --all-features --lib: 3908 passed, 0 failed, on 6323a430. This includes the new yes/no-poll and feature-not-active tests.
  • scripts/migration-fixtures and the CI script suites pass. The migration matrix runs in CI, because the fixture password is a CI secret.
  • cargo clippy --all-features --all-targets -- -D warnings: clean. cargo fmt --all -- --check: clean.
  • scripts/migration-fixtures/check-pin-ancestry.sh: the pin is on v5.1-dev and the fingerprint matches.
  • Not run: a live group-gated config update or a live contest end-time refresh against testnet.

Known duplicates left as they are

Cargo.lock still holds two pre-existing duplicate git crates. This bump does not change either one, and both need upstream work:

  • grovedb. DET's own grovestark pin (5b9e289, already grovestark's HEAD) depends on grovedb 33dfd48 (4.0.0), while platform uses 2128ea1 (6.1.1). Removing the duplicate needs a grovestark release on grovedb 6.1.1. Platform itself does not depend on grovestark.
  • base-sdk. d9e0d24 comes in through rust-dashcore aca0202, and 33fcc59 through dpp.

Note for the bump that turns on version 2 storage

Not a defect at this pin, since no protocol version stores format 2 yet. Once one does, a contract DET fetched with proofs holds its compiled document types in memory. After a restart, DET's saved copy (format 1) is re-parsed from its schemas by the parser of the running build. #5578 exists so that a document type keeps the meaning it was registered with when a later parser differs. DET's reloaded copy could therefore drift from the network's, so local document validation, form generation and fee estimates could disagree with Platform. The network still validates every transition, so this cannot corrupt state, but the user could see confusing rejections.

The bump that activates version 2 storage should do one of two things: refetch saved contracts with proofs on load, or store the version 2 bytes locally and trust them behind an integrity check.

Breaking changes

None for DET users or the on-disk format.

Prior work

Attribution

🤖 Co-authored by Claudius the Magnificent AI Agent

🤖 Generated with Claude Code

https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT

PR Hygiene · dd7d840

  • Bots — coderabbitai skipped by lklimek · thepastaclaw skipped by lklimek
  • Self-review — not asked of a bot author
  • Build running
  • Approvals
    • files with no dedicated owner (Cargo.lock, Cargo.toml, scripts/migration-fixtures/expected-migration-fingerprint.txt and 11 more) — approved by lklimek

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Summary by CodeRabbit

  • Bug Fixes
    • DPNS contest lookups now continue pagination using the latest timestamp across all poll types, including pages without DPNS polls.
    • DPNS registration results now show a pending community vote whenever a vote poll is present.
    • Errors for platform features that are not yet active now provide clearer guidance; temporary protocol-version issues continue to be reported as service unavailable.
  • Documentation
    • Added Platform revisions to the list of revisions that leave migrations unchanged.

lklimek and others added 4 commits October 27, 2026 14:38
Saved contracts must survive every dashpay/platform bump. The existing
round-trip tests encode and decode with the same dpp, so they cannot see
a decoder that stops reading bytes an earlier build wrote.

Pin the bytes DET writes today (dpp of platform 575d961fe0) for a user
contract and the DPNS, DashPay and token-history contracts at protocol
10 to 15, and check each still decodes to the same contract and
re-encodes byte for byte at every later protocol version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
Move dash-sdk, rs-sdk-trusted-context-provider, platform-wallet and
platform-wallet-storage from 575d961fe0 to 0d91c133f0, which adds:

- platform#5584: an active group config update proposal is reported as
  success by the SDK. DET's config update task broadcasts through
  `broadcast_and_wait::<StateTransitionProofResult>` and never matched
  `ConfigUpdateResult`, so no call site changes.
- platform#5578: the stored contract format with compiled document
  types. DET keeps writing format version 0/1 and reads with the
  untrusted decoder, which reads a version 2 contract from its schemas;
  the pinned-bytes test shows contracts saved before the bump still load.
- platform#4740: platform-wallet rescans DashPay contact accounts from
  the contact request height. No API change for DET.
- platform#5602: dashmate only.

Cargo.lock changes only the platform git source; the wallet-storage
migration fingerprint is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
Refresh expected-migration-fingerprint.txt with check-pin-ancestry.sh
--update: the fingerprint is unchanged, only the recorded pin moves. List
0d91c133 among the platform revisions that leave the wallet-storage
migrations untouched.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
The pinned saved-contract bytes covered only a minimal user contract.
Contracts users actually save carry more, and a decode break there would
make them silently disappear from the app.

Add a user contract with a group, mixed-case keywords, a description,
`$defs` with a `$ref`, a contested unique index, and a token with
group-controlled rules, perpetual and pre-programmed distribution. Its
bytes for protocol 10 to 15 were written by the dpp of platform
575d961fe0 (the previous pin), the same way as the existing fixtures,
which are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 684a931 and dd7d840.

Files selected for processing: 2

  • src/backend_task/mod.rs
  • src/model/fee_estimation.rs

No actionable comments were generated in the recent review.

Walkthrough

The changes update Platform dependency revisions, adjust DPNS poll classification and pagination, and add protocol-version error handling. Test support and tests now use SDK protocol-version behavior rather than synthetic response metadata.

Changes: Platform dependency pins

Layer / File(s) Summary
Update Platform revision references
Cargo.toml, scripts/migration-fixtures/expected-migration-fingerprint.txt, src/wallet_backend/platform_compatibility/fixtures/README.md
The Platform Git dependencies and migration-source reference use revision 6323a430c731a14bbec1d7a18466ca28bb083316. The compatibility documentation adds three revisions that leave migrations unchanged.

DPNS poll handling

Layer / File(s) Summary
Classify DPNS poll results
src/model/dpns.rs
Any present poll result now produces PendingCommunityVote.
Track timestamps across poll pages
src/backend_task/contested_names/query_ending_times.rs
The query collects DPNS contest names while advancing pagination by the latest timestamp across all poll types. Tests cover mixed, yes/no-only, and empty pages.

Protocol-version handling and tests

Layer / File(s) Summary
Map inactive protocol errors
src/backend_task/error.rs
Transient ProtocolVersionNotActive errors map to DapiUnavailable. Other such errors map to TaskError::PlatformFeatureNotActive. Both retain the SDK error source.
Add protocol-version test support
src/context/mod.rs, src/context/test_support.rs
Test builds apply an SDK-specific proven-version override. Test support adds a helper to create mock SDKs at a specified protocol version.
Exercise protocol-version scenarios
src/backend_task/platform_info.rs, src/backend_task/shielded/mod.rs, src/mcp/resolve.rs
Tests use the shared proof helper or mocked contract fetches to exercise protocol-version state. The epoch-fetch test checks the unavailable-epoch report.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Suggested reviewers: lklimek, thepastaclaw

Merge Risk: Minimal · previous review 684a9

This dependency bump and its adaptations look safe to merge. Transient failures to confirm the network version now give retry guidance instead of telling users to wait for an upgrade. The one remaining gap is in a test and does not affect users.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names a dependency bump of dashpay/platform to v5.1-dev at revision 6323a430, which matches the Cargo.toml and migration fingerprint changes. It is a conventional-commit style title that is …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names a dependency bump of dashpay/platform to v5.1-dev at revision 6323a430, which matches the Cargo.toml and migration fingerprint changes. It is a conventional-commit style title that is short and specific. It does not mention the wider adaptations (yes/no poll handling, protocol-version error mapping, test support changes), but those are supporting work and the title still states the primary change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 215ac1a and 684a931.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 6

  • src/backend_task/contested_names/query_ending_times.rs
  • src/backend_task/error.rs
  • src/backend_task/shielded/mod.rs
  • src/context/mod.rs
  • src/mcp/resolve.rs
  • src/model/dpns.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@thepastaclaw

thepastaclaw commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

🕓 Review not started yet because the new head is waiting for the 30-minute push debounce.

  • Request normal review — click when the PR is ready for review.
  • Request priority review — click to move this review to the front of the queue.

Commit dd7d840. Normal review starts when eligible; priority review starts as soon as a slot is available.

@Claudius-Maginificent
Claudius-Maginificent marked this pull request as ready for review October 28, 2026 10:25
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet · thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Oct 28, 2026

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 2 only (no Phase 1 for this repository)

The dependency and lockfile updates are internally consistent, and CI reports successful build, test, and lint checks. However, this pin adopts the DashPay historical-rescan behavior while retaining a documented race: an in-flight SPV filter batch can certify coverage after the checkpoint rewind without being invalidated, allowing historical contact payments to remain undetected.

🔴 1 blocking

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — This is a broad dependency upgrade with Rust compatibility changes and a substantial stored-contract regression test, but the diff does not itself alter a critical surface such as funds movement, cryptography, consensus, or migrations.
  • Phase 1 reviewers: not run (disabled for this repository)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort high); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `Cargo.toml`:
- [BLOCKING] Cargo.toml:38-41: The pinned DashPay rescan can still skip historical contact payments during an in-flight SPV scan
  This pin adopts platform-wallet's contact-account rescan, and DET invokes that path through `WalletBackend::sync_contact_requests` at `src/wallet_backend/dashpay.rs:1054`. In the pinned platform source, `reconcile_dashpay_rescan` lowers `synced_height` but explicitly documents that the rewind does not change the account generation and tracks the resulting race as platform issue #4955 (`packages/rs-platform-wallet/src/wallet/identity/network/payments.rs:302-315`). The pinned dash-spv commit snapshots the wallet's account generation when a batch starts and rejects the batch only if that generation changes (`dash-spv/src/sync/filters/manager.rs:595-607`); otherwise its checkpoint-contiguity check can still certify the batch. The pinned platform contact registration still uses `insert_funds_bearing_account`, while the later platform commit `5adbe62929` changes this path to `add_managed_account` specifically to invalidate filter-scan generation; that commit is not an ancestor of the pinned platform revision. Therefore, if a contact-account registration/rewind occurs while a batch is in flight, the batch can advance the checkpoint over blocks that were scanned before the new contact scripts were monitored, permanently missing an incoming historical payment. Pin a platform/rust-dashcore revision containing the equivalent invalidation fix, or otherwise resolve the upstream race before adopting this rescan behavior.

Comment thread Cargo.toml Resolved
@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. and removed waiting-bots Waiting for the review bots to report on this head labels Oct 28, 2026
lklimek and others added 6 commits October 29, 2026 15:11
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
Move dash-sdk, rs-sdk-trusted-context-provider, platform-wallet and
platform-wallet-storage from 0d91c133f0 to 6323a430c7 (29 commits,
platform 5.0.1). rust-dashcore stays at aca02026, matching the
platform's own pin.

DET adaptations:
- platform#4899 adds `VotePoll::YesNoVotePoll`. The DPNS end-time
  refresh skips yes/no polls, and pages on every poll the end-date
  index returns, so a page holding only yes/no polls no longer ends
  the walk before later DPNS contests. `contested_vote_poll_for_document_properties`
  returns the contested poll directly, which simplifies the DPNS
  registration classifier.
- platform#5561 adds `SdkError::ProtocolVersionNotActive`, raised when
  the SDK refuses a request the network does not serve yet. It maps to
  a new `TaskError::PlatformFeatureNotActive` instead of the generic
  SDK error.

Known: platform#5561 also stops the public
`Sdk::verify_response_metadata` from recording a verified protocol
version, which the test helpers that simulate a proven network
version relied on; those tests fail until a replacement seam exists.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
Refresh expected-migration-fingerprint.txt with check-pin-ancestry.sh
--update: the fingerprint is unchanged (19 migrations), only the
recorded pin moves. List 6323a430 among the platform revisions that
leave the wallet-storage migrations untouched.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
platform#5561 stops the public `Sdk::verify_response_metadata` from
recording a verified protocol version: upstream learns one only from a
response whose proof and quorum signature it checked itself, and a mock
expectation raises only the stored version (platform#5622). The test
helpers that simulated a proven network version through that hook no
longer moved anything.

`AppContext::protocol_version_info` folds a test-only override into the
SDK's answer in `cargo test` builds; every other build is unchanged.
The override is bound to the SDK it was set for, so a rebuilt connection
still starts with nothing proven. `prove_protocol_version` sets it, and
the MCP refresh tests install their mock SDK and then prove the newest
version through it. The mid-transfer shield test runs its wallet backend
on a mock connection at protocol 13 and moves it with a mocked fetch.

`a_failed_epoch_fetch_still_advises_updating_for_a_newer_network` still
fails: the epoch task reads `Sdk::protocol_version_info` directly, which
the override does not reach.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
…pdate advice

A failed epoch fetch still degrades to the unavailable-epoch report;
the test now asserts that report. It no longer proves a protocol
version newer than this build: the task reads the SDK's own verified
version, which a mock cannot record since dashpay/platform#5561
(dashpay/platform#5622). A TODO restores the update-advice assertion
once it can; the advice itself stays covered by
`a_newer_proven_protocol_appends_the_update_advisory`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet · thepastaclaw requested changes — dismiss the review or push a fix. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added waiting-bots Waiting for the review bots to report on this head and removed waiting-self-review Waiting for the author to post /self-reviewed bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. labels Oct 29, 2026
@Claudius-Maginificent Claudius-Maginificent changed the title chore(deps): bump dashpay/platform to v5.1-dev 0d91c133 chore(deps): bump dashpay/platform to v5.1-dev 6323a430 Oct 29, 2026

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 2 only (no Phase 1 for this repository)

The dependency and API adaptations are internally consistent, and the targeted regression coverage plus completed tests and Clippy checks are successful. However, this pin adopts the DashPay historical-payment rescan while retaining an upstream in-flight rewind race that can permanently miss contact payments; the remaining Test Suite check is still in progress.

🔴 1 blocking

1 carried-forward finding(s) already raised on this PR; not re-posting as new inline comments.

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — This is a broad dependency upgrade with substantial adaptations across backend logic, contract persistence compatibility, shielded handling, and MCP resolution, but the diff does not itself change a critical surface such as funds movement, cryptography, consensus rules, or storage migrations.
  • Phase 1 reviewers: not run (disabled for this repository)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort high); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `Cargo.toml`:
- [BLOCKING] Cargo.toml:38-41: The pinned DashPay rescan can still skip historical contact payments during an in-flight SPV scan
  (existing thread: https://github.com/dashpay/dash-evo-tool/pull/1153#discussion_r4401257525)
  This dependency bump adopts platform-wallet's DashPay contact-account rescan. In the pinned platform source, `reconcile_dashpay_rescan` lowers `synced_height` and arms the rewind barrier, but explicitly notes that a rewind occurring inside an already-running filter batch does not change that batch's account generation (`payments.rs:307-309`). The pinned dash-spv engine snapshots each wallet's account generation when the batch starts and only rejects certification when the generation changes (`manager.rs:595-607`). Consequently, a batch that scanned a range before the rewind can still certify coverage over blocks scanned without the newly watched contact scripts, permanently missing a historical incoming contact payment. The separate contact-registration race is fixed by `note_account_registered`, but the rewind-inside-an-in-flight-batch race remains at `6323a430`, is tracked as dashpay/platform#4955, and the proposed upstream invalidation commit `5adbe62929` is not an ancestor of the pin. Pin a revision containing the upstream fix or add a safe workaround in the owning wallet layer before shipping this rescan behavior.

Stored-contract byte stability is a Platform consensus guarantee: dpp cannot
change how existing contracts decode without breaking chain replay. DET does
not need its own fixtures for it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WunYYhY7P2FJqHVgkHiXtT
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai ✓, 2 threads unresolved — resolve them · thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

…rm-0d91c133

# Conflicts:
#	src/model/dpns.rs

Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
auto-merge was automatically disabled November 12, 2026 09:02

Head branch was pushed to by a user without write access

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet · thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added waiting-bots Waiting for the review bots to report on this head and removed ready-for-human Bots have reported, the author has self-reviewed, and the build is green: this needs a human. bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. labels Nov 12, 2026
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>

Copilot AI commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@copilot please fix the merge conflicts in this pull request.

Merged v1.0-dev and resolved the DPNS conflict in 684a931. The merge exposed a related Platform API compile error; I fixed it in ff28190. Formatting and 112 focused tests pass.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet · thepastaclaw ✓. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

Copilot AI requested a review from lklimek November 12, 2026 09:08

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 2 only (no Phase 1 for this repository)

Reviewed the complete diff at ff28190 and the relevant pinned upstream implementations; no blocking implementation defect was verified. One non-blocking documentation issue remains: this dependency pin already supports compiled contract storage at protocol 15, contrary to the PR's compatibility explanation. This was a static review only; current checks show review and hygiene checks pending, with no Rust build, test, or lint result exposed for this exact head.

🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)

Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.

Follow-up candidates (optional) (1)

New non-blocking observations on code unchanged since the last full review. No inline threads are opened for them and later reviews do not repeat them: fix forward or track separately if they are worth it.

🟡 Suggestion: Correct the compiled-storage activation assessment for this pin
Cargo.toml:27

The PR description says no protocol version selects storage format 2 and assigns the saved-contract follow-up to a future dependency bump. This exact revision already includes platform commit 60cc5f4508 (#5579): packages/rs-platform-version/src/version/dpp_versions/dpp_contract_versions/v7.rs sets contract_storage_serialization_version to 2, and version/v15.rs selects that table. Another dependency bump is therefore not required for this build to encounter compiled contracts on a protocol-15 network. DET still persists schema-only bytes through serialize_to_bytes_with_platform_version in src/context/contract_token_db.rs and reconstructs contracts through versioned_deserialize_untrusted, rather than retaining the proof-authenticated compiled representation. Correct the compatibility discussion to distinguish dependency support from network activation, and explicitly document acceptance of that persistence limitation or link its follow-up instead of placing it behind a future dependency bump. No concrete current-parser divergence was established, so this is a documentation correction rather than a blocking corruption finding.

source: gpt-6.1-sol (phase2-reviewer: general)

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — The dependency bump includes cross-cutting Rust API adaptations, poll pagination logic, and typed error handling, but the diff does not itself make large or intricate changes to a qualifying critical surface.
  • Phase 1 reviewers: not run (disabled for this repository)
  • Fresh final gate: an independent Phase-2 review ran after iterative findings were reconciled
  • Code unchanged since the last final review (cae33646): 1 new suggestion(s) listed as follow-up candidates, not posted inline
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort high); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.

No unresolved findings remain from the prior review on this head.

@github-actions

Copy link
Copy Markdown
Contributor

Ready for review — files with no dedicated owner: lklimek.
Full checklist in the description.

@github-actions github-actions Bot added ready-for-human Bots have reported, the author has self-reviewed, and the build is green: this needs a human. bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. and removed waiting-bots Waiting for the review bots to report on this head labels Nov 12, 2026
@lklimek
lklimek enabled auto-merge (squash) November 16, 2026 14:43
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Policy satisfied — this can merge.
Full checklist in the description.

@github-actions github-actions Bot removed the ready-for-human Bots have reported, the author has self-reviewed, and the build is green: this needs a human. label Nov 16, 2026
…rsion

`prove_protocol_version` now records only the proven version in a test
seam and leaves the SDK's own version as it was. The test still built its
contactRequest queries before the first mocked response raised the SDK
to the latest version, so DET built later queries against a different
system contract than the expectations. The mock lookup missed and fell
back to proof parsing of an empty response. Start the mock SDK at
LATEST_VERSION with `mock_sdk_at_for` so both sides use the same
contract.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet · thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added waiting-bots Waiting for the review bots to report on this head and removed bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. labels Nov 16, 2026
@lklimek

lklimek commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

/skip-bots

@github-actions github-actions Bot added bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. and removed waiting-bots Waiting for the review bots to report on this head labels Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. priority: medium Medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants