Skip to content

chore(deps): apply compatible dependency updates and minor majors - #1183

Draft
Claudius-Maginificent wants to merge 1 commit into
v1.0-devfrom
chore/deps-compatible-2026-11-16
Draft

Claudius-Maginificent wants to merge 1 commit into
v1.0-devfrom
chore/deps-compatible-2026-11-16

Conversation

@Claudius-Maginificent

Copy link
Copy Markdown
Collaborator

TL;DR

Updates third-party libraries to their latest releases that need no code changes, including fixes for two published security advisories. The app should behave the same.

Detailed discussion

Dependency-only change with no user-observable effect, so this PR has no User story or Scenario. Only Cargo.toml and Cargo.lock change; no Rust source is touched. Dashpay git pins (platform, rust-dashcore, grovedb, grovestark, …) are untouched, so the platform pin guard and migration fingerprint stay as they are (check-pin-ancestry.sh passes). Platform moves separately in #1153.

Semver-compatible lockfile updates (cargo update)

~90 crates.io packages move to their newest compatible releases, among them tonic/prost 0.14.x, wgpu/naga 30.0.2, aws-lc-rs 1.19, toml 1.2, uuid 1.29.2, rustls-webpki 0.103.17, webpki-roots 1.0.12. defmt drops out of the tree.

Advisory Crate Fixed by
RUSTSEC-2026-0433 pulldown-cmark 0.13.5 0.13.6
RUSTSEC-2026-0462 rmcp 3.7.0 3.10.0

Major bumps that build without code changes

Crate Old → New Notes
rfd 0.17.2 → 0.18.0 GTK3/zenity fixes; "All files" filters now also match names without a dot
nix 0.31.3 → 0.32.0 only signal feature used; breaking changes are in socket/vmsplice APIs we do not call
resvg 0.49.0 → 0.50.0 no API fallout

Manifest minimums raised to the locked versions

rmcp 3.10.0 (security), arc-swap 1.9.5, rand 0.10.4, rust-embed 8.14.0.

Deliberately not updated

  • egui / eframe / egui_extras / egui_kittest 0.37, egui_commonmark 0.26 — ~90 Id::new deprecations (choose Id::unique vs IdSalt::new per call site, which affects persisted widget state) plus egui::Event API changes in kittest. Needs its own PR.
  • rusqlite 0.43 / refinery 0.10 — rusqlite must match platform-wallet, platform-wallet-storage and grovedb-commitment-tree (single sqlite3 link). Blocks the libsqlite3-sys fix (RUSTSEC-2026-0459, needs ≥ 0.39) until upstream moves.
  • bip39 3, zip32 0.3 — types shared with key-wallet / orchard / platform-wallet.
  • time 0.3.55, zeroize 1.9.1, keyring stores, matchit — newer releases need a newer Rust than the 1.99 pin.

Remaining advisories (upstream-blocked)

libsqlite3-sys (above) and zip 8.6.0 (RUSTSEC-2026-0367/-0368/-0369/-0429, build-dependency of tenderdash-proto-compiler), plus unmaintained-only warnings.

Testing

  • cargo check --all-features --all-targets: clean, no warnings.
  • cargo fmt --all -- --check: clean.
  • cargo metadata --locked: lockfile consistent with the manifest.
  • Full test/clippy sweep left to CI.

🤖 Co-authored by Claudius the Magnificent AI Agent

🤖 Generated with Claude Code

Move crates.io dependencies to their newest semver-compatible
releases (fixes RUSTSEC-2026-0433 in pulldown-cmark and
RUSTSEC-2026-0462 in rmcp) and take three majors that build without
code changes: rfd 0.18, nix 0.32, resvg 0.50. Raise manifest minimums
for rmcp, arc-swap, rand and rust-embed to the locked versions.

Dashpay git pins are untouched.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@thepastaclaw

Copy link
Copy Markdown
Collaborator

🕓 Review not started yet because this PR is a draft.

  • Request normal review — click when the PR is ready for review.
  • Request priority review — click to move this review to the front of the queue.

Commit bb0a126. Normal review starts when eligible; priority review starts as soon as a slot is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants