Skip to content

sdk%chore(ci): refresh actions.lock after rust-toolchain@stable moved - #133

Merged
PastaPastaPasta merged 1 commit into
developfrom
pasta/ci-rust-toolchain-pin
Nov 16, 2026
Merged

PastaPastaPasta merged 1 commit into
developfrom
pasta/ci-rust-toolchain-pin

Conversation

@PastaPastaPasta

@PastaPastaPasta PastaPastaPasta commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Motivation

dtolnay/rust-toolchain rebuilds its stable branch on every upstream change, so the commit actions.lock pins it to (b725eda525362e7cf34af9a7243cac1e3f01a7ec) left the ref. Every run now fails lockfile verification, develop's push run 43672876347 included. The pin moves to 39008827e6b4319a349e9a42dfc90579dd25f1ca, the current head of stable (compare).

Additional Information

The commit is the output of gh actions-lock --no-narrow --no-interactive --accept-moved run from the repository root, with nothing edited by hand. Without --accept-moved the tool writes nothing and asks for it, because of the unreachable pin.

On the same run the tool also changed three other entries:

  • taiki-e/install-action@v2 moves from 68a389c788b2cd04016ce8c80ee23b80d2ab3d68 to ab49d3c64680143e184118bed66a46419fc15519 (compare). The tag moved forward, and the old pin is an ancestor of the new one.
  • Mic92/niks3-action@v1 moves from 6d24bc1d87acdfac8e5dc3266f7b28ae99051adf to 01820a2b97ac01531ad9fb859db94af63ffcbd83, which is v1.10.0 (compare). The tag moved forward, and the old pin is an ancestor of the new one.
  • jlumbroso/free-disk-space@v2 is now lumbroso-commons/free-disk-space@v2 in the lockfile and in six workflows. The repository was transferred, with the same repository ID and the same pinned commit.

Breaking Changes

None.

How Has This Been Tested?

gh actions-lock --verify

It reports all 16 workflows valid. CI on this pull request runs the lockfile check and every workflow that uses the changed actions.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional tests
  • I have made corresponding changes to the documentation
  • I did not use agentic assistance (i.e. LLMs, AI) except as disclosed and can answer questions,
    comments and concerns without said assistance. I assume authorship of the code submitted.
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Agent disclosure

The commit was generated by gh actions-lock. The commit message and this description were written with Claude Code using Claude Opus 5.5 at high effort, running autonomously as an agent on behalf of the author.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 13318ea and ec78d9e.

Files ignored due to path filters: 1

  • .github/workflows/actions.lock is excluded by !**/*.lock, !**/*.lock
Files selected for processing: 6

  • .github/workflows/build_bazel.yml
  • .github/workflows/build_corpora.yml
  • .github/workflows/build_cross.yml
  • .github/workflows/build_msrv.yml
  • .github/workflows/build_stable.yml
  • .github/workflows/pages.yml

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Updated the disk-space cleanup step used by the automated build, corpus, cross-platform, compatibility, stable, lint, and documentation publishing workflows. No changes were made to the workflows’ existing platform conditions or other cleanup settings. These updates do not change features or behavior available in the product.

Six GitHub Actions workflows now use lumbroso-commons/free-disk-space@v2 instead of jlumbroso/free-disk-space@v2. Existing settings and job conditions remain unchanged.

Suggested reviewers: kwvg

Merge Risk: Minimal · previous review 13318

This updates the disk-space cleanup action to its new repository name across six CI workflows. The behavior stays the same, and no merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: refreshing actions.lock after the rust-toolchain stable ref moved. It uses the sdk%chore(ci) prefix convention and is specific to the changeset. The title does not men…
Description check Passed The description explains why the lockfile pin changed (the stable commit became unreachable and lockfile verification failed), what the new pin is, the other entries the tool changed, and how the chan…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: refreshing actions.lock after the rust-toolchain stable ref moved. It uses the sdk%chore(ci) prefix convention and is specific to the changeset. The title does not mention the other pin updates or the free-disk-space rename, which is acceptable for a title.

Full details: Description check

Explanation

The description explains why the lockfile pin changed (the stable commit became unreachable and lockfile verification failed), what the new pin is, the other entries the tool changed, and how the change was tested. It is directly related to the changeset.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between ba9785a and 13318ea.

Files ignored due to path filters: 1

  • .github/workflows/actions.lock is excluded by !**/*.lock, !**/*.lock
Files selected for processing: 6

  • .github/workflows/build_bazel.yml
  • .github/workflows/build_corpora.yml
  • .github/workflows/build_cross.yml
  • .github/workflows/build_msrv.yml
  • .github/workflows/build_stable.yml
  • .github/workflows/pages.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

Copy link
Copy Markdown

Note

This pull request has no conflicts! 🎊 🎉 🎊

@thepastaclaw

thepastaclaw commented Nov 15, 2026 •

Copy link
Copy Markdown

✅ Final review complete — Phase 1 only — no blockers (commit ec78d9e) · triage: trivial

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review — Phase 1 only (trivial change)

The change is a minimal one-line update to the action lockfile, replacing the stale dtolnay/rust-toolchain stable pin with the current stable branch head. The diff preserves the lockfile structure, and all relevant code and lint checks passed; no in-scope issues were found.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-gate-verifier, role: final-verifier)

  • Triage: trivial by gpt-6.1-sol (effort low) — This is a one-line CI lockfile pin update with no application behavior or security-critical code changes, and a second review round is unlikely to add value.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 97% left, weekly 51% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-gate-verifier
  • Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves
Out-of-scope follow-up suggestions (1)

These are valid observations, but they are outside this PR's scope and should be handled in separate issues or author/maintainer-requested PRs rather than blocking this review.

  • Automate recurring stable-toolchain repins — The lockfile tracks a moving stable branch, so verification will eventually fail again when dtolnay/rust-toolchain regenerates that branch. This does not affect the correctness of this minimal repin, but recurring maintenance could be reduced with scheduled or dependabot-style automation that runs a targeted actions-lock update.
    • Follow-up: Open a follow-up issue or PR for scheduled, targeted repinning of moving action references such as dtolnay/rust-toolchain@stable.

@PastaPastaPasta
PastaPastaPasta force-pushed the pasta/ci-rust-toolchain-pin branch from ba9785a to 13318ea Compare November 15, 2026 16:19
@PastaPastaPasta PastaPastaPasta changed the title sdk%chore(ci): repin dtolnay/rust-toolchain@stable to its current head sdk%chore(ci): refresh actions.lock after rust-toolchain@stable moved Nov 15, 2026
@codecov

codecov Bot commented Nov 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…oved

`stable` is rebuilt upstream, so the locked b725eda5 left the ref. From
`gh actions-lock --no-narrow --no-interactive --accept-moved`.
@PastaPastaPasta
PastaPastaPasta force-pushed the pasta/ci-rust-toolchain-pin branch from 13318ea to ec78d9e Compare November 15, 2026 16:30

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final review — Phase 1 only (trivial change)

The change is limited to the generated GitHub Actions lockfile refresh and the corresponding repository-owner rename across six workflows. The updated pins and workflow references are consistent with the stated mechanical refresh, and all code, build, lint, and coverage checks reported by CI succeeded; no in-scope issues were found.

🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-gate-verifier, role: final-verifier)

  • Triage: trivial by gpt-6.1-sol (effort low) — This is a contained CI configuration and action-pin refresh with no product behavior or runtime code changes, and its correctness is directly verifiable through lockfile validation.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 97% left, weekly 51% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-gate-verifier
  • Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.

No unresolved findings remain from the prior review on this head.
Out-of-scope follow-up suggestions (1)

These are valid observations, but they are outside this PR's scope and should be handled in separate issues or author/maintainer-requested PRs rather than blocking this review.

  • Schedule proactive GitHub Actions lockfile refreshes — Moving action refs can invalidate the pinned lockfile before a normal push or pull request exposes the problem. A scheduled refresh would detect and propose updates proactively rather than relying on a failing develop run.
    • Follow-up: Open a separate maintainer PR adding a scheduled workflow that runs the existing lockfile refresh command and opens an update PR when actions.lock changes.

@PastaPastaPasta

Copy link
Copy Markdown
Member Author

Ready for steward review at ec78d9e

  • The commit is the unedited output of gh actions-lock --no-narrow --no-interactive --accept-moved. The recipe without --accept-moved writes nothing because of the unreachable pin. Besides the dtolnay/rust-toolchain@stable pin, the tool moved taiki-e/install-action@v2 and Mic92/niks3-action@v1 forward along their tags, and followed the free-disk-space transfer in six workflows. The description lists all three.
  • gh actions-lock --verify: all 16 workflows valid.
  • CI on this head: 52 pass, 2 skipping, and Lint passes the lockfile check. thepastaclaw's final review at this head reports 0 blocking. just comb passes on the commit (fork run 43735880692).

🤖 Posted autonomously by Claude on behalf of pasta.

@PastaPastaPasta
PastaPastaPasta merged commit 5946424 into develop Nov 16, 2026
55 checks passed
@PastaPastaPasta
PastaPastaPasta deleted the pasta/ci-rust-toolchain-pin branch November 16, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants