Repository navigation
Description
The maintainer (kwvg) is away. Until he is back, pull requests in this repository are reviewed and merged by a steward: an AI agent (Claude) acting for PastaPastaPasta. Merges appear under that account, and each one has a comment below. This issue is the record for kwvg to read on his return.
Rules
- The steward reviews and merges. It writes no feature code and does not push to PR branches. Authors never approve or merge their own PRs.
- The standard is kwvg's reviews on sdk%fix: range-check decoded lengths, apply Dash Core's decode-time caps #57 to primitives%fix!: check operator keys under the payload's BLS scheme #129, applied as written. A finding he raised once is a blocker the second time. His reviews are never dismissed or edited.
- Class A: makes the SDK accept, refuse, decode or encode what the reference implementation does, inside existing types and APIs. Steward decides.
- Class B: a new typed message, payload or primitive that a named consumer needs, in the style of the existing ones. Steward decides.
- Class C: a new public abstraction (trait, macro, wrapper, feature flag, crate, dependency) or a reshaping of existing types. Needs a written proposal and a unanimous council of three models (Claude Fable 5.2, Claude Opus 5.5 and GPT 6.1 Sol). So does any change to operative crypto in
dash-pkc, a PR he never reviewed that adds more than about 300 lines of library source, and a thread of his that the author disputes. If the council is not unanimous, it does not merge and the question is listed below. - Class D: conflicts with one of his rulings (state or tunables, devnets or builders, a BLS scheme chosen at run time, a consensus-level choice made inside the SDK, check-order parity, debugging allowances, handler policy, V1 transport). Nothing in class D merges.
- Before a merge:
just combpasses on every commit, CI is green on the exact head including the Codecov patch checks, and a model from a different family than the author has reviewed the diff. Merges are made withcontrib/git_merge.py. - The steward does not publish, tag or bump versions, does not change
AGENTS.md, the style guide, the PR template, lint or CI policy or the MSRV, and does not force-pushdevelop. - To undo a merge:
git revert -m 1 <merge sha>. Each entry below gives the command.
Questions for kwvg
-
Operator signatures on legacy payloads.
Signable::verifyonProUpServTxandProUpRevTxpicks the BLS scheme from the payload version (OperatorKey::verify; it wasverify_operatorin primitives%feat!: decode v24 special transactions as the reference implementation does #88, and primitives%fix!: check operator keys under the payload's BLS scheme #129 moved it without changing the rule). The reference implementation verifies under the scheme active at the block (CheckHashSig,VerifyInsecure). A version 1ProUpServTxmined on mainnet after v19 (for example at block 1991126) is legacy-encoded and signed under the basic scheme, andverifyrefuses it. The same happens when the masternode's stored key is legacy-encoded and the payload is version 2 or 3. Found while reviewing primitives%feat!: add payload sign hashes, read signatures of any length #121, whose corpus holds such transactions. Not changed by any merged or open PR. The operator key itself is read under the payload version in the reference, so the key check added in primitives%fix!: check operator keys under the payload's BLS scheme #129 does not depend on this. Question: how should the caller name the scheme here? Until answered, any proposal goes to a council as class C. -
Check-table rows that pin which error is reported first (
case::x_before_y).develophas them in several modules (proregtx.rs,proupsharetx.rs,netinfo.rs), and primitives%fix: check net info entries after purposes and the reward #109 says the order of checks is not something to match. Question: are new rows of this kind wanted? Until answered, new PRs add none, and the ones ondevelopare left alone. -
The lockfile pins
dtolnay/rust-toolchain@stable, a branch that upstream rebuilds on top of master, so the pinned commit leaves the ref and CI fails until the pin is refreshed (sdk%chore(ci): refreshactions.lockafterrust-toolchain@stablemoved #133). Question: keep the branch ref and refresh it with--accept-movedwhen it breaks, or pin a ref that does not move? Until answered, the steward refreshes it with your recipe, as in sdk%chore(ci): refreshactions.lockafterrust-toolchain@stablemoved #133.
Activity
PastaPastaPasta commentedon Nov 14, 2026
His threads, all from the review at 7b552ac:
GovObjectdoc and drop the layout block: the doc is "Governance object." and the block is gone.GovObject-level tests are gone.codec_base_bounds_a_limited_fieldincodec.rschecks thefield: limitform on a stand-in struct, with an empty field, a field at the limit and a count over it.CHANGELOG.md. The wording is in the description's "Breaking Changes".The threads are left unresolved on GitHub and the review is not dismissed, so both read as he left them.
Judgment calls:
codec_base!is exported and gains afield: limitform. I classed that as A, not as a new public abstraction. It only passes the limit on toimpl_vec!'s form from p2p_core%feat!: bound inventory, locator and address counts #119, whose description named this field as the follow-up, and his review of this PR asked for a test of the form and did not question it. He did not see the final head.GovObjectwith a 97-byte signature. The bound onGovObjectitself rests on the macro test plus the one linesig: Self::MAX_SIGNATURE_SIZE. That is what his thread asked for; the corpora hold signatures of 0 and 96 bytes.Proof:
just combpassed on both commits, run by the steward. CI and every Codecov patch and project check were green on ed32612. The independent review had no findings.🤖 Posted autonomously by Claude on behalf of pasta.
PastaPastaPasta commentedon Nov 14, 2026
What it is: one commit, ten lines in
pkgs/primitives/src/support.rs.RevocationReasonnamed codes 1 to 3KeyCompromise,ChangeOfKeys,ViolationOfService. The reference names them termination of service, compromised keys and change of keys (providertx.h#L396-L401). They are nowTerminationOfService,CompromisedKeys,ChangeOfKeys. The codes, the codec and the check on an unknown reason are unchanged. The consumer is a block explorer that shows the names.Judgment calls:
ChangeOfKeyskeeps its name and moves from code 2 to code 3, so code written against the old enum compiles and means a different code. The alternative was a name that differs from the old one for code 3 as well, which would have turned the silent change into a compile error at the cost of not using the reference's name. I took the reference's names; the description's "Breaking Changes" states the move first. The independent review found that the description had missed it.developunnoticed: nothing but a reading against the reference checks a name.Proof:
just combpassed on the commit, run by the steward. CI and every Codecov patch and project check were green on 8b25917. The independent review's two findings were both on the description and were corrected before merge.🤖 Posted autonomously by Claude on behalf of pasta.
primitives%fix!: check operator keys under the payload's BLS scheme (#…
PastaPastaPasta commentedon Nov 14, 2026
What it is: the ProRegTx, ProUpRegTx and ProUpSharedRegTx checks refused an operator key only when it was null. They now also refuse a key that is not valid under the scheme the reference reads it with: legacy for a version 1 ProRegTx or ProUpRegTx, basic otherwise (providertx.h#L188, #L354, #L542, bls.h#L495-L515). The validity rule is
dash-pkc'sis_canonical; nothing indash-pkcchanges.His threads, from the review at 75dab82:
dash-primitives, and the same tests were repeated in three structs (three threads): all removed. The check tables keep each payload'snull_operatorrow, and one row inproregtx.rswhere a version 2 payload from the chain is set to version 1.KeyEditenum, flagged before in primitives%feat!: decode v24 special transactions as the reference implementation does #88: gone, with nothing in its place.is_validas an inherent function, and add a commit that folds inverify_operator:OperatorKeysits besideOperatorSig, withis_valid(version). The second commit movesverify_operatorintoOperatorKey::verify, and ProUpServTx and ProUpRevTx take anOperatorKeyas theirSignable::Key.Judgment calls:
dash-pkc's to own. The corpus rows run the check on version 1 and version 2 payloads, so both branches execute, but no test in this crate shows that direction refusing.is_valid(version)picks the scheme from the payload version. The reviewer first read that as a scheme chosen at run time and withdrew it on re-check: the type carries no scheme, the choice ends in a compile-time scheme parameter asverify_operatoralready did, and it is the function his thread asked for.OperatorKey::verifykeeps the rule that the signature scheme follows the payload version. That rule is question 1 in this issue's list and is still open. This PR moves it without changing it; the key check does not depend on it, because the reference does read the key under the payload version.Proof:
just combpassed on both commits, run by the steward. CI and every Codecov patch and project check were green on 1193b7e. The independent review ran three times: on the first ready head, on its own findings after I disputed three of them, and on this head. The first ready head (60cedb5) went back for a test that could not fail, a duplicated row and a history fold.🤖 Posted autonomously by Claude on behalf of pasta.
p2p_core%feat!: type the BIP37 and BIP157 messages (#122)
PastaPastaPasta commentedon Nov 15, 2026
What it is: the ten BIP37 and BIP157 messages, which
dash-p2p-corecarried as raw bytes, become typed messages, anddash-primitivesgainsTxMerkleNode. This undoes the compact filter regression listed in #40.His review at 31a4a44 offered two options: defer the PR for
bitcoin-p2p-messagesand undo #39, or align with upstream semantics and leave a TODO for the substitution. The second was taken. Names, fields and field order follow rust-bitcoin at 94c6f791. Each module has oneTODO(pasta)naming the types upstream's can replace,PartialMerkleTree,FilterHashandFilterHeader. The description says why the others stay.Council (Claude Fable 5.2, Claude Opus 5.5, GPT 6.1 Sol, all high; unanimous in round 2, 2026-11-14; recorded in #122 and below):
BloomFlagsis an openenum_map!enum withUnknown, so it reads every byte, as the reference does. Upstream's enum is closed. That is the one place this PR departs from upstream, and it is whyBloomFlagsandFilterLoadstay this SDK's types.bitcoin-unitsbecomes a direct dependency ofdash-p2p-core, forstart_height: BlockHeightingetcfiltersandgetcfheaders. Your earlier file (228e54c) had it, and upstream types the field the same way.Judgment calls:
bitcoin-unitsdependency. The council accepted it, but on a strict reading the "consumer is blocked without it" test for class C is not met: the crate could use its own height type.CFCheckptis typed although no node code reads its fields yet. A reviewer first raised it under p2p_core%refac!: gate all inner values of encodable types, applygetterpolicy to crate, restrictmake_num!behind {get,set}ters #92 and withdrew it, for three reasons: the variant was already public as bytes, Known Issues #40 lists the stubs as a regression, and your file typed it.filterloadrefuses a filter over 36,000 bytes, andfilteraddan element over 520 bytes, while reading. The reference refuses both while deserialising (bloom.h#L76-L78, net_processing.cpp#L5584-L5589), so I treated them as the same fault at the same stage, not handler policy. The two bounds are public associated constants,FilterLoad::MAX_FILTER_SIZEandFilterAdd::MAX_DATA_SIZE, in the formaddr.rsuses. The node needs them to build a filter, sincenewtakes any length.merkleblockrows hash to the merkle root of block 2,000,000, and that thecfheadershashes and the header chain recompute from the filters in the rows.contrib:contrib/cfilter.py:31lacks the two blank lines beforedef field. CI's lint does not flag it.parse_argsandmainare the same twelve lines in both scripts.Proof:
just combpassed on all three commits, run by the steward. CI and every Codecov check were green on 7ce7bcf.Reviews:
One mistake of mine: deleting the branch closed #128, which was stacked on it. I restored the branch at 7ce7bcf and reopened #128. Its base stays on that branch until the author rebases it onto
develop.🤖 Posted autonomously by Claude on behalf of pasta.
PastaPastaPasta commentedon Nov 16, 2026
What it is:
developwas red at d8cfd14 for a reason outside any PR.dtolnay/rust-toolchainrebuilds itsstablebranch on top of master, so b725eda5, the commitactions.lockpinned it to, was no longer on the ref (compare). The stable jobs failed at "Set up job" and Lint failed its lockfile check (run 43672876347). The commit is the output of yourgh actions-lockrecipe, plus--accept-moved. The tool refuses to write without that flag when a pin has left its ref.Judgment calls:
taiki-e/install-action@v2andMic92/niks3-action@v1moved forward along their tags, made by their maintainers, and each old pin is an ancestor of the new one.jlumbroso/free-disk-spaceis nowlumbroso-commons/free-disk-spacein the lockfile and in six workflows. It is the same repository (ID 506133999) at the same commit, transferred to an organisation of which jlumbroso is a member.uses:references with no library code. The reviewer checked every new pin against GitHub and found nothing beyond two nits. One was that the command adds--accept-movedto your recipe. The other was that the pin will break again the next time upstream rebuildsstable, which is question 3 in this issue's body.Proof: CI on ec78d9e had 52 checks passing and 3 skipped, Lint's lockfile check included. There is no Rust change, so the CI run on the head was the proof.
🤖 Posted autonomously by Claude on behalf of pasta.