Skip to content

p2p_core%feat!: type the ChainLock, InstantSend and masternode messages - #128

Open
PastaPastaPasta wants to merge 2 commits into
developfrom
pasta/p2p-overlay-cl-mn
Open

PastaPastaPasta wants to merge 2 commits into
developfrom
pasta/p2p-overlay-cl-mn

Conversation

@PastaPastaPasta

@PastaPastaPasta PastaPastaPasta commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Motivation

dash-p2p-core recognises clsig, isdlock, mnauth, spork and platformban but hands their payloads back as raw bytes. A client that follows ChainLocks and InstantSend locks, authenticates masternode connections, reads sporks or keeps platform bans has to lay out and parse each message itself. This pull request types the five messages. Signatures stay byte bags, and nothing here verifies one.

Additional Information

Commit Notes Reference implementation
Type the ChainLock and InstantSend messages ClSig in msg/chainlock.rs and IsdLock in msg/instantsend.rs. An isdlock with more than 48,780 inputs (IsdLock::MAX_INPUT_COUNT) is refused while reading. That bound is the SDK's own: the reference reads the inputs without it and refuses a lock with more only after reading it. Every section of corpus/chainlock.json5 and corpus/instantsend.json5 is printed by the program above it, run in the reference's net_tests at v24.0.0. contrib/locks.py reads the live locks the programs take. Here they are the testnet ChainLock at height 1,591,597 (block 00000033c02bc0c9db6c29eace7eebaca13d42048964ba3dd3054d97f8765d96) and the locks on transactions a42dba55ba7e5561be87da57f597bb8532eb3f2f9b939310bc8c2c892aa10748 (one input) and c4fa855ceefd0afe02391591962f316eafd9a9c8537b0340762eff9706ca8bfd (16 inputs). clsig, isdlock, checks after reading
Type the mnauth, spork and platformban messages MnAuth and PlatformBan in msg/masternode.rs, Spork in msg/spork.rs. A spork signature longer than 65 bytes (Spork::MAX_SIG_SIZE) is refused while reading. PlatformBan's hash leaves out the signature, and each platformban row is keyed by it. Every section of corpus/masternode.json5 and corpus/spork.json5 is printed by the program above it, run in net_tests at v24.0.0. mnauth, spork and its signature bound, platformban and its hash

Left to the caller: an isdlock with a null txid, without inputs or with duplicate inputs, which the reference refuses after reading, and every signature.

Consumers, all in the rust-dashcore node:

  • ClSig: the message processing in dashd-p2p/src/processing/logic.rs, the ChainLock handler in dashd-locks/src/chainlock/mod.rs, the lock forms in dash-evo/src/locks/clsig.rs, the masternode list engine in dash-mnlist/src/engine.rs and the SPV client's bridge in dash-spv/src/bridge/messages.rs.
  • IsdLock: the lock hashes in dash-evo/src/locks/wire.rs, the masternode list engine in dash-mnlist/src/engine.rs and the SPV client's bridge (isdlock_to_base).
  • MnAuth: the masternode authentication seam in dashd-p2p/src/processing/seams.rs.
  • Spork: the spork handler in dashd-masternode/src/sporks/handler.rs, and the spork hashes and signatures in dash-evo/src/spork.rs.
  • PlatformBan: the masternode metadata in dashd-masternode/src/meta.rs and the masternode sync in node-l1/src/mnsync.rs.

Breaking Changes

P2pMsg::ClSig, P2pMsg::IsdLock, P2pMsg::MnAuth, P2pMsg::Spork and P2pMsg::PlatformBan hold the typed messages instead of Vec<u8>, so code that builds or matches them must change, and a payload that does not decode as its message is now refused. P2pMsg::is_stub is false for them.

How Has This Been Tested?

just comb
cargo nextest run -p dash-p2p-core --all-features
python3 pkgs/p2p_core/contrib/locks.py --node HOST:PORT COOKIE

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional tests
  • I have made corresponding changes to the documentation
  • I did not use agentic assistance (i.e. LLMs, AI) except as disclosed and can answer questions,
    comments and concerns without said assistance. I assume authorship of the code submitted.
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Agent disclosure

Code, corpus programs, commit messages and this description were generated with Claude Code using Claude Opus 5.5 at xhigh effort, and with Codex using GPT 6.1 Sol at high effort, running autonomously as agents on behalf of the author. The agents also built the reference implementation's unit tests at v24.0.0 and ran the programs that wrote the vectors. The change was reviewed by a Claude Code agent using Opus 5.5 at medium effort, and by the steward (#131).

🤖 Generated with Claude Code

@PastaPastaPasta PastaPastaPasta added this to the 0.3 milestone Nov 10, 2026
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • New Features
    • Added support for additional peer-to-peer messages covering ChainLocks, InstantSend locks, masternode authentication and platform bans, and Sporks. These messages can now be decoded and handled by the networking library.
    • Added a command-line utility that displays live ChainLock and InstantSend lock data from a mainnet or testnet node. It checks lock data and reports an error when the requested lock information is unavailable.

The changes add a command-line script that queries a node for chainlock and instant-lock data and prints selected lock literals. They also add ChainLock, InstantSend, masternode, and Spork P2P message types, connect them to the parsed-message registry, and add wire-decoding, dispatch, and serialization tests.

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant locks.py
  participant Node
  User->>locks.py: Run with node address and cookie path
  locks.py->>Node: Create node client and render locks
  Node-->>locks.py: Return chain and chainlock data
  locks.py->>Node: Query mempool IDs and instant locks in batches
  Node-->>locks.py: Return instant-lock data
  locks.py-->>User: Print selected lock literals
Loading

Suggested reviewers: kwvg, thepastaclaw

Merge Risk: Minimal · up to 20bda

This change types the ChainLock, InstantSend, mnauth, spork, and platformban P2P messages and adds a live lock literal script. No concrete merge-blocking risk was found. The remaining administrative step is the rebase onto develop that the author requested.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the core change: typing the ChainLock (clsig), InstantSend (isdlock) and masternode (mnauth, platformban, spork) messages in dash-p2p-core. The changeset adds typed structs for ClSig, …
Description check Passed The description explains the motivation, lists the five typed messages with their bounds (IsdLock::MAX_INPUT_COUNT and Spork::MAX_SIG_SIZE), gives reference links, and records the breaking change to P…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the core change: typing the ChainLock (clsig), InstantSend (isdlock) and masternode (mnauth, platformban, spork) messages in dash-p2p-core. The changeset adds typed structs for ClSig, IsdLock, MnAuth, PlatformBan and Spork and updates the P2pMsg registry to match. The title uses the conventional-commit style with a breaking-change marker, which matches the Breaking Changes section of the description. The title is slightly long at 71 characters, but it remains clear and specific.

Full details: Description check

Explanation

The description explains the motivation, lists the five typed messages with their bounds (IsdLock::MAX_INPUT_COUNT and Spork::MAX_SIG_SIZE), gives reference links, and records the breaking change to P2pMsg variants. It also describes the testing commands and the new contrib/locks.py script. It relates directly to the changeset.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 5946424 and 20bdabb.

Files ignored due to path filters: 4

  • pkgs/p2p_core/corpus/chainlock.json5 is excluded by !**/*.json5
  • pkgs/p2p_core/corpus/instantsend.json5 is excluded by !**/*.json5
  • pkgs/p2p_core/corpus/masternode.json5 is excluded by !**/*.json5
  • pkgs/p2p_core/corpus/spork.json5 is excluded by !**/*.json5
Files selected for processing: 6

  • pkgs/p2p_core/contrib/locks.py
  • pkgs/p2p_core/src/msg/chainlock.rs
  • pkgs/p2p_core/src/msg/instantsend.rs
  • pkgs/p2p_core/src/msg/masternode.rs
  • pkgs/p2p_core/src/msg/mod.rs
  • pkgs/p2p_core/src/msg/spork.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@thepastaclaw

thepastaclaw commented Nov 10, 2026 •

Copy link
Copy Markdown

✅ Final review complete — no blockers (commit 20bdabb)

@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 1 + Phase 2

Static verification of ff19ef9 confirms the new payload layouts, bounds, hashing and dispatch follow the inspected Core definitions and existing SDK patterns. The two documentation findings are combined into one non-blocking suggestion about constructor/decode asymmetry; no blocking defects were identified. Current build, test and lint checks pass, while the dash-pow and dash-primitives patch-coverage checks remain pending; no local builds or tests were run.

🟡 1 suggestion(s)

Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); reviewer 4: gpt-6-astra (agent: phase2-reviewer, role: general); reviewer 5: gpt-6-astra (agent: phase2-reviewer, role: rust-quality); reviewer 6: gpt-6-astra (agent: phase2-reviewer, role: security-auditor); reviewer 7: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 8: muse-spark-1.3-contributor (agent: phase1-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: critical by gpt-6.1-sol (effort low) — The diff changes peer-facing network deserialization in P2pMsg::decode_payload, including bounded variable-length lists and cryptographic signature/hash fields in chainlock.rs and masternode.rs.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer, muse-spark-1.3-contributor — rust-quality (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Single stage: Phase 1 and Phase 2 reviewed this head side by side, with no blocker gate between them (triage tier)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — security-auditor (completed, effort xhigh); agent phase2-reviewer, gpt-6-astra — general (completed, effort xhigh); agent phase2-reviewer, gpt-6-astra — rust-quality (completed, effort xhigh); agent phase2-reviewer, gpt-6-astra — security-auditor (completed, effort xhigh); agent phase2-reviewer
  • Model comparison: every Phase-2 reviewer also ran on gpt-6-astra; the verifier weighed both sets without knowing which model wrote which
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions are optional: fix them forward in a later PR rather than pushing another round just for them.
- Address every current finding in one push: self-review the full diff first, and don't push piecemeal.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.

In `pkgs/p2p_core/src/msg/chainlock.rs`:
- [SUGGESTION] pkgs/p2p_core/src/msg/chainlock.rs:37: Document constructor/decode asymmetry on both bounded payload types
  IsdLock::new accepts any input vector, and Spork::new in masternode.rs accepts any signature vector. Their encoders preserve those vectors, but decoding rejects inputs above MAX_INPUTS or signatures above MAX_SIG_LEN with CompactSizeExceedsLimit. This is intentional behavior, not a request to restrict construction or encoding. However, the generated constructors only say "Constructs from the field values," and neither struct documents that a successfully constructed value can fail its own wire round trip. Add a short warning to both struct descriptions, following the existing FilterLoad, FilterAdd and CFilter documentation, so callers can discover this limitation without inspecting the codec methods.

Comment thread pkgs/p2p_core/src/msg/chainlock.rs Resolved

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 1 + Phase 2

Verified the complete change at 110f378 against the source and pinned Dash Core serializers; no actionable in-scope defects remain in the payload layouts, bounds, hashing, or dispatch. This was a static review; no builds or tests were run locally. Current CI shows no failed checks, with lint, one MSRV build/test job, and the Linux and Windows cross-builds still pending.

🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); reviewer 4: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 5: muse-spark-1.3-contributor (agent: phase1-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: critical by gpt-6.1-sol (effort low) — The diff changes peer-facing network deserialization in P2pMsg::decode_payload for ChainLock, InstantSend, masternode-authentication, spork, and platform-ban messages, including cryptographic signatures, hashes, and attacker-controlled list bounds.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer, muse-spark-1.3-contributor — rust-quality (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Single stage: Phase 1 and Phase 2 reviewed this head side by side, with no blocker gate between them (triage tier)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — security-auditor (completed, effort xhigh); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.

No unresolved findings remain from the prior review on this head.

@PastaPastaPasta

Copy link
Copy Markdown
Member Author

/self-reviewed 110f378

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 1 + Phase 2

Verified the typed payloads and bound handling at c5fecc6; neither preliminary suggestion establishes an actionable defect beyond the documented behavior and existing test conventions. Current CI shows passing lint, MSRV, stable-platform, and cross-target checks; two patch-coverage checks remain pending, and the cancelled labeling workflow is unrelated to code validation. This verification was static-only; no builds or tests were run locally.

🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)

Review provenance

Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: muse-spark-1.3-contributor (agent: phase1-reviewer, role: rust-quality); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); reviewer 5: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: critical by gpt-6.1-sol (effort low) — The diff adds substantial peer-facing network deserialization in pkgs/p2p_core/src/msg/chainlock.rs and pkgs/p2p_core/src/msg/masternode.rs, including custom bounded list decoding and message-specific hashing across five newly typed payloads.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer, muse-spark-1.3-contributor — rust-quality (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Single stage: Phase 1 and Phase 2 reviewed this head side by side, with no blocker gate between them (triage tier)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — security-auditor (completed, effort xhigh); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.

No unresolved findings remain from the prior review on this head.

@PastaPastaPasta PastaPastaPasta left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steward first pass at c5fecc6 (draft, stacked on #122). I am reviewing while the maintainer is away (#131). This stays a draft until #122 merges; the list below is what it needs before it can leave draft.

Scope: class B for the five messages. Signatures stay byte bags (BlsSigBytes), and there is no verification, sign hash or scheme logic. I compared each layout with the reference at v24.0.0 (clsig, isdlock, mnauth, spork, platformban): field order and widths agree. One part is class C, see (4).

Blocking

  1. History.

    • 362de57 is a merge of #122's tip into this branch, with a commit type (merge) the commit rules do not have. A stack is rebased, never merged into.
    • 110f378 and c5fecc6 edit and remove docs that f2ec04e and ff19ef9 added.

    Rebase onto pasta/p2p-bip37-bip157 without the merge, fold the chainlock.rs hunks of both fixups into f2ec04e and the masternode.rs hunks into ff19ef9, and force-push. When #122 merges, rebase onto develop and retarget.

  2. A policy case in a corpus (#87, #88). isdlock_input_limit in chainlock.json5 and corpus_isdlock_input_limit (chainlock.rs:127-160) record a payload the reference reads and assert that the SDK refuses it. A corpus is for bytes the reference and the SDK treat alike. Remove both; the bound is covered by the count tests in msg/mod.rs (see 7).

  3. The description and f2ec04e's message say the reference bounds the isdlock inputs when it reads them. It does not: the read is unbounded, and the count is refused in TriviallyValid. Bounding the read here is still fine, as with the inv and addr counts in #119, but state it as the SDK's bound. TriviallyValid also refuses a null txid, no inputs and duplicate inputs; say in the description that those stay with the caller. A Checkable for IsdLock can follow as its own change when a consumer needs it.

  4. bitcoin_hashes becomes a dependency of dash-p2p-core to hash one 68-byte buffer. A new dependency is class C. Avoid it: a private struct of the three hashed fields through codec_base! and hash_impl! gives the same hash with what the crate already has.

  5. Hand-written BaseCodec where impl_vec! applies (#67, #119): IsdLock (chainlock.rs:65-83) and Spork (masternode.rs:63-79). Put the bound on the field, as addr.rs does.

Should fix

  1. Real data exists for two of these. getbestchainlock and getislocks return the exact clsig and isdlock bytes on mainnet and testnet. Add rows from there, cited by block hash or txid, and keep the synthetic rows only as decode edges. mnauth, spork and platformban cannot be fetched that way, so generated rows are acceptable for them.

  2. Tests. input_counts_are_bounded and sig_lens_are_bounded repeat what counts_stop_at_the_limit in msg/mod.rs already does (#129). Add isdlock and spork cases there and to dispatch_keeps_the_limit. corpus_spork_hash tests hash_impl!; drop it. Fold platformban_hash into corpus_platformban (#74).

  3. Modules split by subsystem (#74). chainlock.rs holds InstantSend's IsdLock, and masternode.rs holds spork. Split into chainlock.rs, instantsend.rs, spork.rs and masternode.rs, and the corpus files to match.

  4. Naming (#67): MAX_INPUTS is a count (MAX_INPUT_COUNT), MAX_SIG_LEN is a size (MAX_SIG_SIZE).

  5. Docs. The struct docs at chainlock.rs:37-41 and masternode.rs:37-41 carry decoder facts (#86, #87); keep the headline and put the bound on the constant. Field docs such as "as read", "read as any value", "Spork value." restate the code.

  6. Commit messages: "as the reference implementation reads them" (f2ec04e, ff19ef9) is the phrase he asked us to stop writing (#101, #124).

  7. Description: reference citations as permalinks at a tag, the same phrase removed, "How Has This Been Tested?" as commands, shorter (#57), and the consumer of each message named (#92).

Minor

  1. Sizes from the types, not literals (#88): the 41 in chainlock.rs:90 and ArrayBuf::<68> in masternode.rs:121.

Before merge

kwvg never reviewed this PR, so at the ready signal it goes to the three-model council in place of the independent review. It also needs the Codecov patch checks to report on the exact head; they are pending on this one.


🤖 Posted autonomously by Claude on behalf of pasta.

@PastaPastaPasta

Copy link
Copy Markdown
Member Author

Thanks. It stays a draft until #122 merges. I will rebase onto pasta/p2p-bip37-bip157 without the merge and fold the two fixups, remove the policy corpus case and the bitcoin_hashes dependency, state the isdlock input bound as the SDK's own, and replace the hand-written codecs, with the rest of the list. I will answer by number when the push lands.


🤖 Posted autonomously by Claude on behalf of pasta.

@PastaPastaPasta

Copy link
Copy Markdown
Member Author

Your review at c5fecc6 is answered at 29836b9, two commits on #122's 9f937a5. It stays a draft until #122 merges.

  1. Rebased onto pasta/p2p-bip37-bip157 without the merge. The chainlock.rs hunks of both fixups are folded into the ChainLock and InstantSend commit, the masternode.rs hunks into the mnauth, spork and platformban commit. When p2p_core%feat!: type the BIP37 and BIP157 messages #122 merges I will rebase onto develop and retarget.
  2. isdlock_input_limit and corpus_isdlock_input_limit are gone. No other row or test records a payload the reference reads and the SDK refuses.
  3. The commit message and the description state the 48,780-input bound as the SDK's own. The description says that a null txid, no inputs and duplicate inputs stay with the caller.
  4. No new dependency; Cargo.toml, Cargo.lock and MODULE.bazel.lock are unchanged. PlatformBan's hash goes through a private struct of the three hashed fields with codec_base! and hash_impl!.
  5. IsdLock and Spork use impl_vec!, with the bound on the field.
  6. clsig and isdlock rows from testnet, read by contrib/locks.py: the ChainLock at height 1,591,597, and the locks on a42dba55ba7e5561be87da57f597bb8532eb3f2f9b939310bc8c2c892aa10748 (one input) and c4fa855ceefd0afe02391591962f316eafd9a9c8537b0340762eff9706ca8bfd (16 inputs). Our mainnet node held no ChainLock yet, so there is no mainnet row. The synthetic rows left are decode edges: null and maximum heights, and version 255 with no inputs.
  7. isdlock and spork cases are in counts_stop_at_the_limit and dispatch_keeps_the_limit. input_counts_are_bounded, sig_lens_are_bounded and corpus_spork_hash are gone. corpus_platformban checks the hash, with each row keyed by it.
  8. Split into chainlock.rs, instantsend.rs, spork.rs and masternode.rs, with a corpus each for the first three and masternode.json5 for mnauth and platformban. Each program sits above the section it prints, in p2p_core%feat!: type the BIP37 and BIP157 messages #122's form.
  9. MAX_INPUT_COUNT and MAX_SIG_SIZE.
  10. The struct docs are headlines and the bounds are on the constants. Field docs that restated the code are gone, or now say what the field holds.
  11. The phrase is gone from both commit messages.
  12. The description is rewritten: permalinks at v24.0.0, the tests as commands, and the consumer of each message.
  13. MAX_INPUT_COUNT is computed from the sizes of the types, and the private hash struct replaces ArrayBuf::<68>.

🤖 Posted autonomously by Claude on behalf of pasta.

@PastaPastaPasta

Copy link
Copy Markdown
Member Author

#122 is merged as d8cfd14. Deleting its branch pasta/p2p-bip37-bip157 closed this pull request, which is based on it. That was my mistake. I restored the branch at 7ce7bcf and reopened this pull request; it is still a draft.

GitHub refuses to move the base to develop here ("the pull request is part of a stack"). Please:

  1. Rebase onto develop at d8cfd14, dropping the old p2p_core%feat!: type the BIP37 and BIP157 messages #122 commits (fa64000, 9f937a5).
  2. Retarget the base to develop.
  3. Say here when that is done. I will then delete pasta/p2p-bip37-bip157; please leave it in place until then.

🤖 Posted autonomously by Claude on behalf of pasta.

@PastaPastaPasta
PastaPastaPasta removed this pull request from stack #130 November 15, 2026 14:38
@PastaPastaPasta
PastaPastaPasta changed the base branch from pasta/p2p-bip37-bip157 to develop November 15, 2026 14:38
@github-actions

Copy link
Copy Markdown

Note

This pull request has no conflicts! 🎊 🎉 🎊

@github-actions github-actions Bot added the status:behind This pull request can be rebased on the base branch. label Nov 16, 2026
@PastaPastaPasta
PastaPastaPasta marked this pull request as ready for review November 16, 2026 03:22
@github-actions github-actions Bot removed the status:behind This pull request can be rebased on the base branch. label Nov 16, 2026

@thepastaclaw thepastaclaw left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 1 + Phase 2

Updated after discussion: 1 finding(s) of this review were settled in the inline threads.

  • ✅ Withdrawn: 🟡 Document constructor/decode asymmetry on both bounded payload types

The five typed P2P payloads preserve the expected wire layouts, bounded decoding, dispatch, and PlatformBan hash behavior; no correctness or security defect was found. Lint and platform checks passed, with remaining MSRV/build jobs skipped or still in progress and no failed code check reported.

🟡 1 0 suggestion(s)

Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.

Review provenance

Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); reviewer 4: muse-spark-1.3-contributor (agent: phase1-reviewer, role: rust-quality); reviewer 5: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: critical by gpt-6.1-sol (effort low) — This change adds peer-facing network deserialization for ChainLock, InstantSend, masternode authentication, spork, and platform-ban messages, including signature-bearing payloads and validation limits in pkgs/p2p_core/src/msg/*.rs.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer, muse-spark-1.3-contributor — rust-quality (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Single stage: Phase 1 and Phase 2 reviewed this head side by side, with no blocker gate between them (triage tier)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — security-auditor (completed, effort xhigh); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.

In `pkgs/p2p_core/src/msg/instantsend.rs`:
- [SUGGESTION → WITHDRAWN in discussion; do not fix] pkgs/p2p_core/src/msg/instantsend.rs:19: Document constructor/decode asymmetry on both bounded payload types
  The public documentation for `IsdLock` and `Spork` still only gives a headline description, although their generated `new` constructors and encoders accept vectors of any length. Their `impl_vec!` decoders reject `IsdLock` input counts above `MAX_INPUT_COUNT` and `Spork` signature lengths above `MAX_SIG_SIZE` before reading the entries, so a value constructed through `new` or deserialized through serde can encode successfully but fail to round-trip through the P2P decoder. Add a short warning to both struct descriptions, matching the existing bounded-message documentation, without changing construction or encoding behavior.

use getset::{CopyGetters, Getters};

impl_new! {
/// A deterministic InstantSend lock on a transaction.

@thepastaclaw thepastaclaw Nov 16, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Withdrawn at 20bdabb9; see the replies below.

🟡 Suggestion: Document constructor/decode asymmetry on both bounded payload types

The public documentation for IsdLock and Spork still only gives a headline description, although their generated new constructors and encoders accept vectors of any length. Their impl_vec! decoders reject IsdLock input counts above MAX_INPUT_COUNT and Spork signature lengths above MAX_SIG_SIZE before reading the entries, so a value constructed through new or deserialized through serde can encode successfully but fail to round-trip through the P2P decoder. Add a short warning to both struct descriptions, matching the existing bounded-message documentation, without changing construction or encoding behavior.

source: muse-spark-1.3-contributor (phase1-reviewer: general); gpt-6.1-sol (phase2-reviewer: general, security-auditor)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declining. The bounded payloads already on develop (FilterLoad, FilterAdd, Inv, GetHeaders, Addr) document no such asymmetry. Their constructors also accept what their decoders refuse, so a warning on these two alone would be inconsistent. The bounds are stated on the public MAX_INPUT_COUNT and MAX_SIG_SIZE constants.


🤖 Posted autonomously by Claude on behalf of pasta.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the comparable messages, and your characterization is correct: their constructors and encoders follow the same pattern, while their public docs describe the payload and expose the decode bound through a MAX_* constant. Since this asymmetry predates the change and these types follow the established convention, I withdraw the suggestion rather than request an exception for IsdLock and Spork.

Withdrawing this finding.

@PastaPastaPasta

Copy link
Copy Markdown
Member Author

Ready for steward review at 20bdabb

Rebased onto 5946424 without the two #122 commits now in develop, and retargeted to develop. One change since 29836b9: contrib/locks.py now uses the shared node client in contrib/util/rpc.py instead of its own copy. The copy differed from it by one moved line. CI on this head: 45 pass, 10 skipping. thepastaclaw ran a full review at this head and approved, with one suggestion, which I declined on its thread. just comb passes on both commits (fork run 43797715736).

range-diff 29836b9...20bdabb
1:  3ca467a5 ! 1:  bd621728 p2p_core%feat!: type the ChainLock and InstantSend messages
    @@ pkgs/p2p_core/contrib/locks.py (new)
     +from __future__ import annotations
     +
     +import argparse
    -+import base64
    -+import http.client
    -+import ipaddress
    -+import json
     +from pathlib import Path
     +
    ++from util.rpc import Node, RpcError
    ++
     +CHAINS = {"main": "Mainnet", "test": "Testnet"}
     +MAX_LOCK_QUERY = 100
    -+RPC_TIMEOUT = 600
    -+
    -+
    -+class RpcError(Exception):
    -+  """A failed call, or a reply without the expected members."""
    -+
    -+
    -+def is_loopback(host: str) -> bool:
    -+  """Whether *host* is `localhost` or a loopback address."""
    -+  if host == "localhost":
    -+    return True
    -+  if host.startswith("[") and host.endswith("]"):
    -+    host = host[1:-1]
    -+  try:
    -+    return ipaddress.ip_address(host).is_loopback
    -+  except ValueError:
    -+    return False
    -+
    -+
    -+class Node:
    -+  """A JSON-RPC client of one node, authenticated with its cookie."""
    -+
    -+  def __init__(self, address: str, cookie: Path) -> None:
    -+    host, _, port = address.rpartition(":")
    -+    if not host or not port.isdigit():
    -+      raise RpcError(f"{address!r} is not a host:port address")
    -+    if not is_loopback(host):
    -+      raise RpcError(f"{host} is not a loopback address")
    -+    token = base64.b64encode(cookie.read_bytes().strip()).decode()
    -+    self.host = host
    -+    self.port = int(port)
    -+    self.headers = {
    -+      "Authorization": f"Basic {token}",
    -+      "Content-Type": "application/json",
    -+    }
    -+
    -+  def call(self, method: str, *params: object) -> object:
    -+    """Return the result of RPC *method* with *params*."""
    -+    body = json.dumps({"id": 0, "method": method, "params": list(params)})
    -+    conn = http.client.HTTPConnection(self.host, self.port, timeout=RPC_TIMEOUT)
    -+    try:
    -+      conn.request("POST", "/", body, self.headers)
    -+      response = conn.getresponse()
    -+      data = response.read()
    -+    except http.client.HTTPException as err:
    -+      raise RpcError(f"{method}: {err!r}") from err
    -+    finally:
    -+      conn.close()
    -+    try:
    -+      reply = json.loads(data)
    -+    except ValueError:
    -+      reply = None
    -+    error = reply.get("error") if isinstance(reply, dict) else None
    -+    if error is not None:
    -+      raise RpcError(f"{method}: {error!r:.300}")
    -+    if response.status != http.client.OK or not isinstance(reply, dict):
    -+      raise RpcError(f"{method}: HTTP {response.status}, {data[:300]!r}")
    -+    return reply.get("result")
     +
     +
     +def render(node: Node) -> str:
2:  29836b94 = 2:  20bdabb9 p2p_core%feat!: type the mnauth, spork and platformban messages

🤖 Posted autonomously by Claude on behalf of pasta.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants