Repository navigation
fix(address-field): draw the scan icon in Dash blue - #66
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 3
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
…ue scan icon Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
romchornyi-pitcrew
left a comment
There was a problem hiding this comment.
Summary
TextFieldCryptoAddressIcon moves from near-black / white to #008DE4 in both appearances, so the scan glyph in AddressFieldView matches the field's Paste action. Two commits: the colour change and the re-recorded testEmpty references.
Verdict: ready to merge. No blockers, majors or findings that need a change.
Verified
- The token has one reader: the scan glyph (
AddressFieldView.swift:249); no other component changes colour. Dash Wallet iOS (develop) does not reference the token directly. - The new value equals
ButtonPlainBlueContent, the colour of the Paste button (DashButton.plainBlue) beside it, andBlueText, in light and dark. - A disabled field draws no trailing controls (
AddressFieldView.swift:113), so there is no disabled glyph that should stay grey. OnlytestEmptydraws the glyph, which matches the two re-recorded references;testDisabled,testError,testFilledandtestLabelAccessorystay green unchanged. - All checks are green, including snapshot tests and Before / After screenshots.
Recommendations
- Nit: the colour set copies
#008DE4rather than followingBlueText; if the brand blue changes, this token has to change with it. Asset catalogs cannot alias a colour, so the alternative is.foregroundStyle(Color.dash.blueText)at the call site, at the cost of the dedicated token. Either is fine; a one-line note in the colour set's group or the PR is enough.
🤖 Reviewed with Claude Code
romchornyi-pitcrew
left a comment
There was a problem hiding this comment.
✅ no blockers · no majors · 1 non-blocking recommendation — reviewed at 9360c0adc3
| Level | Verdict | |
|---|---|---|
| 1 · Idea | ✅ valid | the scan glyph takes Dash blue, like the Paste action beside it |
| 2 · Architecture | ✅ right layer | one colour-set value; the token keeps its name, so no API change |
| 3 · Completeness | ✅ complete | the token's only reader is the scan glyph (AddressFieldView.swift:249); both testEmpty references re-recorded |
| 4 · Code | ✅ clean | #008DE4 in light and dark, equal to ButtonPlainBlueContent and BlueText; all checks green |
1 non-blocking recommendation
- The value is a copy of
BlueText—TextFieldCryptoAddressIcon.colorset/Contents.json— if the brand blue changes, this token has to change with it. Asset catalogs cannot alias a colour; the alternative is.foregroundStyle(Color.dash.blueText)at the call site, at the cost of the dedicated token. Either is fine.
Review details
Static read of the diff at the head, levels 1–4. Checked: every reader of the token in DashUIKit and Dash Wallet iOS (develop, none there); the Paste button's colour set; that a disabled field draws no trailing controls (AddressFieldView.swift:113), so only testEmpty shows the glyph and testDisabled, testError, testFilled, testLabelAccessory pass unchanged. Nothing built locally; CI's snapshot and Before / After jobs are green.
🤖 Reviewed with Claude Code
Issue being fixed or feature implemented
The scan glyph in
AddressFieldViewdrew inTextFieldCryptoAddressIcon, near-black in light mode and white in dark mode. Product wants it in Dash blue, like the field's Paste action.What was done?
TextFieldCryptoAddressIconis now#008DE4(theBlueTextvalue) in both appearances. The token is used only by the scan glyph, so nothing else changes colour. The AddressField snapshot references that show the glyph are re-recorded from CI.How Has This Been Tested?
.github/scripts/conventions.sh.testEmptyreferences as expected; the new ones were fetched with.github/scripts/fetch-snapshots.sh(run 43430871302).Before / After
Snapshot references (
AddressFieldViewSnapshotTests/testEmpty). OnlytestEmptyshows the glyph in an enabled field; re-recorded in 9360c0a.Breaking Changes
None. The token keeps its name; only its value changes.
Checklist:
🤖 Generated with Claude Code