Skip to content

fix(address-field): draw the scan icon in Dash blue - #66

Merged
ross-dash merged 2 commits into
masterfrom
fix/address-field-scan-icon-blue
Nov 16, 2026
Merged

ross-dash merged 2 commits into
masterfrom
fix/address-field-scan-icon-blue

Conversation

@ross-dash

@ross-dash ross-dash commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

The scan glyph in AddressFieldView drew in TextFieldCryptoAddressIcon, near-black in light mode and white in dark mode. Product wants it in Dash blue, like the field's Paste action.

What was done?

TextFieldCryptoAddressIcon is now #008DE4 (the BlueText value) in both appearances. The token is used only by the scan glyph, so nothing else changes colour. The AddressField snapshot references that show the glyph are re-recorded from CI.

How Has This Been Tested?

  • .github/scripts/conventions.sh.
  • Snapshot job failed on the old testEmpty references as expected; the new ones were fetched with .github/scripts/fetch-snapshots.sh (run 43430871302).

Before / After

Snapshot references (AddressFieldViewSnapshotTests/testEmpty). Only testEmpty shows the glyph in an enabled field; re-recorded in 9360c0a.

Before After
Light
Dark
  • No visual change (refactor, tests, docs). Say why in "What was done?".

Breaking Changes

None. The token keeps its name; only its value changes.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 3

  • SnapshotTests/Tests/DashUIKitSnapshotTests/__Snapshots__/AddressFieldViewSnapshotTests/testEmpty.empty-dark.png is excluded by !**/*.png
  • SnapshotTests/Tests/DashUIKitSnapshotTests/__Snapshots__/AddressFieldViewSnapshotTests/testEmpty.empty-light.png is excluded by !**/*.png
  • Sources/DashUIKit/Resources/Media.xcassets/Colors/TextField/CryptoAddress/TextFieldCryptoAddressIcon.colorset/Contents.json is excluded by !**/*.xcassets/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

…ue scan icon

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@romchornyi-pitcrew romchornyi-pitcrew left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

TextFieldCryptoAddressIcon moves from near-black / white to #008DE4 in both appearances, so the scan glyph in AddressFieldView matches the field's Paste action. Two commits: the colour change and the re-recorded testEmpty references.

Verdict: ready to merge. No blockers, majors or findings that need a change.

Verified

  • The token has one reader: the scan glyph (AddressFieldView.swift:249); no other component changes colour. Dash Wallet iOS (develop) does not reference the token directly.
  • The new value equals ButtonPlainBlueContent, the colour of the Paste button (DashButton .plainBlue) beside it, and BlueText, in light and dark.
  • A disabled field draws no trailing controls (AddressFieldView.swift:113), so there is no disabled glyph that should stay grey. Only testEmpty draws the glyph, which matches the two re-recorded references; testDisabled, testError, testFilled and testLabelAccessory stay green unchanged.
  • All checks are green, including snapshot tests and Before / After screenshots.

Recommendations

  • Nit: the colour set copies #008DE4 rather than following BlueText; if the brand blue changes, this token has to change with it. Asset catalogs cannot alias a colour, so the alternative is .foregroundStyle(Color.dash.blueText) at the call site, at the cost of the dedicated token. Either is fine; a one-line note in the colour set's group or the PR is enough.

🤖 Reviewed with Claude Code

@romchornyi-pitcrew romchornyi-pitcrew left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ no blockers · no majors · 1 non-blocking recommendation — reviewed at 9360c0adc3

Level Verdict
1 · Idea ✅ valid the scan glyph takes Dash blue, like the Paste action beside it
2 · Architecture ✅ right layer one colour-set value; the token keeps its name, so no API change
3 · Completeness ✅ complete the token's only reader is the scan glyph (AddressFieldView.swift:249); both testEmpty references re-recorded
4 · Code ✅ clean #008DE4 in light and dark, equal to ButtonPlainBlueContent and BlueText; all checks green
1 non-blocking recommendation
  1. The value is a copy of BlueText — TextFieldCryptoAddressIcon.colorset/Contents.json — if the brand blue changes, this token has to change with it. Asset catalogs cannot alias a colour; the alternative is .foregroundStyle(Color.dash.blueText) at the call site, at the cost of the dedicated token. Either is fine.
Review details

Static read of the diff at the head, levels 1–4. Checked: every reader of the token in DashUIKit and Dash Wallet iOS (develop, none there); the Paste button's colour set; that a disabled field draws no trailing controls (AddressFieldView.swift:113), so only testEmpty shows the glyph and testDisabled, testError, testFilled, testLabelAccessory pass unchanged. Nothing built locally; CI's snapshot and Before / After jobs are green.

🤖 Reviewed with Claude Code

@ross-dash
ross-dash merged commit b295cb8 into master Nov 16, 2026
12 checks passed
@ross-dash
ross-dash deleted the fix/address-field-scan-icon-blue branch November 16, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants