Skip to content

chore(ui): bump DashUIKit to 5fc436c, fix the Local Currency layout - #1411

Merged
ross-dash merged 1 commit into
developfrom
chore/bump-dashuikit
Nov 13, 2026
Merged

ross-dash merged 1 commit into
developfrom
chore/bump-dashuikit

Conversation

@ross-dash

@ross-dash ross-dash commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Bumps DashUIKit from e8ae3e7 to 5fc436c (master) and fixes three layout problems on Local Currency found while checking it.

What the bump brings to the app

Local Currency layout (LocalCurrencyView), all present before the bump:

  • Opening the screen scrolled the selected currency to the centre. For a currency in the first rows that overshot the top of the lazy list and left an empty band above it. The list now stays at the top when the selected currency is among the first 6 rows; further down it is still centred.
  • The header (bar + search) was a measured spacer that sometimes took the status bar's height with it. It is now a top safeAreaInset, so the list starts right under the search bar.
  • The background stopped at the safe area, so the host controller's lighter colour showed as a band under the home indicator. It now runs to the bottom edge.

The scan icon turns blue in a follow-up bump once dashpay/DashUIKit#66 merges.

Screenshots

Same simulator, develop build vs this branch.

bump-search-dark bump-address-field

Test plan

  • dashpay Debug builds
  • Simulator, dark mode, Settings → Local Currency: placeholder readable, list right under the search bar, no band under the home indicator
  • Simulator, Voting → Add masternode voting key: new label and scan icon
  • Local Currency with a currency far down the list selected: centred on open (not checked on the simulator, to keep the wallet's currency)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • UI Improvements
    • The local currency screen now extends its background into device safe areas and keeps the top overlay aligned with the screen.
    • When opening the screen, the selected currency is brought into view if it appears six or more entries down the filtered list. If it appears nearer the top, the list remains at the top.

The bump brings the readable dark search placeholder (DashUIKit#64), the
address field label and scan icon (#61) and the labelled MenuItem toggle (#63).

Local Currency opened with an empty band above the list when the selected
currency was among the first rows: centring it overshot the top of the lazy
list. The list now stays at the top then, the header is a top safe-area inset
instead of a measured spacer, and the background runs under the home
indicator instead of showing the host's lighter colour there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

Walkthrough

The local currency view removes header-height measurement, places the top overlay in a safe-area inset, and changes when the list scrolls to the selected currency.

Changes: Local currency view

Layer / File(s) Summary
Overlay layout and initial scrolling
DashWallet/Sources/UI/Menu/Settings/LocalCurrency/LocalCurrencyView.swift
The view removes header-height measurement and uses a zero-height scroll anchor. It places the top overlay in a zero-spacing safe-area inset and extends the background into safe areas. On appearance, it scrolls to the selected currency only when that currency is present in the filtered items and its index is at least six.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names two changes that the PR objectives describe: a DashUIKit bump to 5fc436c and a Local Currency layout fix. The raw summary covers only the LocalCurrencyView layout change. The DashUIKit…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names two changes that the PR objectives describe: a DashUIKit bump to 5fc436c and a Local Currency layout fix. The raw summary covers only the LocalCurrencyView layout change. The DashUIKit bump is a dependency update, and its code effects fall outside the ignored Package.resolved file, so the title is partially related. It is not off-topic and it is not vague.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 41164e74-009b-46d7-8c60-a2da3b54136c
Commits

Reviewing files that changed from the base of the PR and between c60dff5 and 1baf539.

Files ignored due to path filters: 1

  • DashWallet.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved
Files selected for processing: 1

  • DashWallet/Sources/UI/Menu/Settings/LocalCurrency/LocalCurrencyView.swift

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@thepastaclaw

thepastaclaw commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

✅ Final review complete — no blockers (commit 1baf539) · triage: normal

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 1 + Phase 2

The Local Currency changes introduce two small layout issues: the fixed six-row threshold is not reliable under Dynamic Type, and the new zero-height anchor inherits default VStack spacing that adds an unintended gap above the currency container. No blocking defects were identified. The simulator test remains queued, while the completed policy and accessibility checks passed.

🟡 1 suggestion(s) | 💬 1 nitpick(s)

Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.

1 finding(s) not shown inline (the lines are not part of this PR's diff)

💬 Nitpick: Default VStack spacing adds an unintended gap above the currency list
DashWallet/Sources/UI/Menu/Settings/LocalCurrency/LocalCurrencyView.swift:196-205

The scroll content now places a zero-height top anchor and the currency container in a default-spacing VStack. SwiftUI therefore inserts its default inter-view spacing before the container, in addition to the overlay's six-point bottom padding and the container's own padding. The result is an extra visible gap between the search bar and the list, contrary to the stated goal of starting the list directly below the search bar. Set the VStack spacing explicitly to zero.

                VStack(spacing: 0) {
                    // Anchor for scrolling back to the top on a new search.
                    Color.clear
                        .frame(height: 0)
                        .id(Self.topID)

                    // Currency list
                    currencyContent
                }

source: muse-spark-1.3-contributor (phase1-reviewer: general)

Review provenance

Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — This changes SwiftUI layout and scrolling behavior plus a Swift package dependency pin, so correctness requires ordinary UI and integration review even though it does not affect a critical surface.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Second Phase-2 pass: on this first full review every Phase-2 reviewer also ran a second, independent time, and the verifier weighed both sets
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.

In `DashWallet/Sources/UI/Menu/Settings/LocalCurrency/LocalCurrencyView.swift`:
- [SUGGESTION] DashWallet/Sources/UI/Menu/Settings/LocalCurrency/LocalCurrencyView.swift:215-217: Fixed row threshold can leave the selected currency off-screen with larger text
  The new guard skips scrolling for selected indices 0 through 5, assuming six rows always fit below the search bar. That assumption does not hold for all Dynamic Type sizes on smaller devices: the cell's text scales while the threshold remains fixed, so a selected currency at index 4 or 5 can be below the fold while the list stays pinned at the top. Keep the no-overscroll behavior for rows that fit, but use a top anchor for early selections instead of returning unconditionally.
- [NITPICK] DashWallet/Sources/UI/Menu/Settings/LocalCurrency/LocalCurrencyView.swift:196-205: Default VStack spacing adds an unintended gap above the currency list
  The scroll content now places a zero-height top anchor and the currency container in a default-spacing VStack. SwiftUI therefore inserts its default inter-view spacing before the container, in addition to the overlay's six-point bottom padding and the container's own padding. The result is an extra visible gap between the search bar and the list, contrary to the stated goal of starting the list directly below the search bar. Set the VStack spacing explicitly to zero.

Comment on lines +215 to +217
guard let index = filteredItems.firstIndex(where: { $0.code == selectedCurrencyCode }),
index >= Self.rowsShownAtTop
else { return }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: Fixed row threshold can leave the selected currency off-screen with larger text

The new guard skips scrolling for selected indices 0 through 5, assuming six rows always fit below the search bar. That assumption does not hold for all Dynamic Type sizes on smaller devices: the cell's text scales while the threshold remains fixed, so a selected currency at index 4 or 5 can be below the fold while the list stays pinned at the top. Keep the no-overscroll behavior for rows that fit, but use a top anchor for early selections instead of returning unconditionally.

Suggested change
guard let index = filteredItems.firstIndex(where: { $0.code == selectedCurrencyCode }),
index >= Self.rowsShownAtTop
else { return }
guard let index = filteredItems.firstIndex(where: { $0.code == selectedCurrencyCode })
else { return }
// Defer until the rows exist before scrolling to one.
DispatchQueue.main.async {
proxy.scrollTo(selectedCurrencyCode, anchor: index >= Self.rowsShownAtTop ? .center : .top)
}

source: muse-spark-1.3-contributor (phase1-reviewer: general)

@ross-dash
ross-dash merged commit 7943938 into develop Nov 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants