Repository navigation
chore(ui): bump DashUIKit to 5fc436c, fix the Local Currency layout - #1411
Conversation
The bump brings the readable dark search placeholder (DashUIKit#64), the address field label and scan icon (#61) and the labelled MenuItem toggle (#63). Local Currency opened with an empty band above the list when the selected currency was among the first rows: centring it overshot the top of the lazy list. The list now stays at the top then, the header is a top safe-area inset instead of a measured spacer, and the background runs under the home indicator instead of showing the host's lighter colour there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Walkthrough
Pre-merge checks:
|
|
✅ Final review complete — no blockers (commit 1baf539) · triage: normal |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 1 + Phase 2
The Local Currency changes introduce two small layout issues: the fixed six-row threshold is not reliable under Dynamic Type, and the new zero-height anchor inherits default VStack spacing that adds an unintended gap above the currency container. No blocking defects were identified. The simulator test remains queued, while the completed policy and accessibility checks passed.
🟡 1 suggestion(s) | 💬 1 nitpick(s)
Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.
1 finding(s) not shown inline (the lines are not part of this PR's diff)
💬 Nitpick: Default VStack spacing adds an unintended gap above the currency list
DashWallet/Sources/UI/Menu/Settings/LocalCurrency/LocalCurrencyView.swift:196-205
The scroll content now places a zero-height top anchor and the currency container in a default-spacing VStack. SwiftUI therefore inserts its default inter-view spacing before the container, in addition to the overlay's six-point bottom padding and the container's own padding. The result is an extra visible gap between the search bar and the list, contrary to the stated goal of starting the list directly below the search bar. Set the VStack spacing explicitly to zero.
VStack(spacing: 0) {
// Anchor for scrolling back to the top on a new search.
Color.clear
.frame(height: 0)
.id(Self.topID)
// Currency list
currencyContent
}
source: muse-spark-1.3-contributor (phase1-reviewer: general)
Review provenance
Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
normalbygpt-6.1-sol(effort low) — This changes SwiftUI layout and scrolling behavior plus a Swift package dependency pin, so correctness requires ordinary UI and integration review even though it does not affect a critical surface. - Phase 1 reviewers:
muse-spark-1.3-contributor— general (completed, effort xhigh); agentphase1-reviewer - Phase 1 model:
muse-spark-1.3-contributor— not quota-gated; passed overgemini-3.8-flash-high(antigravity quota lookup failed),glm-5.3-flash(not used above high effort; tier asks max) - Second Phase-2 pass: on this first full review every Phase-2 reviewer also ran a second, independent time, and the verifier weighed both sets
- Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.
In `DashWallet/Sources/UI/Menu/Settings/LocalCurrency/LocalCurrencyView.swift`:
- [SUGGESTION] DashWallet/Sources/UI/Menu/Settings/LocalCurrency/LocalCurrencyView.swift:215-217: Fixed row threshold can leave the selected currency off-screen with larger text
The new guard skips scrolling for selected indices 0 through 5, assuming six rows always fit below the search bar. That assumption does not hold for all Dynamic Type sizes on smaller devices: the cell's text scales while the threshold remains fixed, so a selected currency at index 4 or 5 can be below the fold while the list stays pinned at the top. Keep the no-overscroll behavior for rows that fit, but use a top anchor for early selections instead of returning unconditionally.
- [NITPICK] DashWallet/Sources/UI/Menu/Settings/LocalCurrency/LocalCurrencyView.swift:196-205: Default VStack spacing adds an unintended gap above the currency list
The scroll content now places a zero-height top anchor and the currency container in a default-spacing VStack. SwiftUI therefore inserts its default inter-view spacing before the container, in addition to the overlay's six-point bottom padding and the container's own padding. The result is an extra visible gap between the search bar and the list, contrary to the stated goal of starting the list directly below the search bar. Set the VStack spacing explicitly to zero.
| guard let index = filteredItems.firstIndex(where: { $0.code == selectedCurrencyCode }), | ||
| index >= Self.rowsShownAtTop | ||
| else { return } |
There was a problem hiding this comment.
🟡 Suggestion: Fixed row threshold can leave the selected currency off-screen with larger text
The new guard skips scrolling for selected indices 0 through 5, assuming six rows always fit below the search bar. That assumption does not hold for all Dynamic Type sizes on smaller devices: the cell's text scales while the threshold remains fixed, so a selected currency at index 4 or 5 can be below the fold while the list stays pinned at the top. Keep the no-overscroll behavior for rows that fit, but use a top anchor for early selections instead of returning unconditionally.
| guard let index = filteredItems.firstIndex(where: { $0.code == selectedCurrencyCode }), | |
| index >= Self.rowsShownAtTop | |
| else { return } | |
| guard let index = filteredItems.firstIndex(where: { $0.code == selectedCurrencyCode }) | |
| else { return } | |
| // Defer until the rows exist before scrolling to one. | |
| DispatchQueue.main.async { | |
| proxy.scrollTo(selectedCurrencyCode, anchor: index >= Self.rowsShownAtTop ? .center : .top) | |
| } |
source: muse-spark-1.3-contributor (phase1-reviewer: general)
Summary
Bumps DashUIKit from
e8ae3e7to5fc436c(master) and fixes three layout problems on Local Currency found while checking it.What the bump brings to the app
SearchBarplaceholder is readable in dark mode (Local Currency, Swap coin list, Username voting).AddressFieldViewlabel and scan icon match the design system (Swap enter/refund address, voting key, Create username, evonode withdrawal).MenuItemlabels its toggle for VoiceOver and gains a row action. The app does not use the row action yet; the Settings VoiceOver workaround stays until it is checked against the newMenuItem.Local Currency layout (
LocalCurrencyView), all present before the bump:safeAreaInset, so the list starts right under the search bar.The scan icon turns blue in a follow-up bump once dashpay/DashUIKit#66 merges.
Screenshots
Same simulator, develop build vs this branch.
Test plan
dashpayDebug builds🤖 Generated with Claude Code
Summary by CodeRabbit