Repository navigation
feat(icons): add the system-message public icon - #62
Conversation
DashIcon.SystemMessage.publicVisibility (system-message-public): the design system's blue eye used next to a notice that an amount and a destination become public. Stored like info-rect-small (PNG 1x/2x/3x).
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
romchornyi-pitcrew
left a comment
There was a problem hiding this comment.
🔴 Changes requested — 1 blocker (inline) · 1 major · 4 non-blocking recommendations — reviewed at eea52a444a
| Level | Verdict | |
|---|---|---|
| 1 · Idea | ✅ valid | The Send confirmation for a Shielded → Core payment (dashpay/dashwallet-ios#1358) needs the design's "public" system-message icon |
| 2 · Architecture | ✅ right layer | Design-system assets live here |
| 3 · Completeness | ✅ complete | One icon, one case, docs line |
| 4 · Code | 🔴 1 blocker | The exported PNGs are opaque with a white background |
Blocker
- system-message-public@3x.png (and the 1x/2x) — every pixel has alpha 255 and the background is solid white (
#FFFFFFat the corners and edges), while every sibling, e.g. system-message-info-rect-small@3x.png, is transparent around the glyph. InSystemMessageViewthe icon will sit in a white 30 pt square: a bright box in dark mode, a visible box on the tinted card in light mode. The asset needs a re-export with a transparent background.
Major
- The Light and Dark "After" cells embed the same image, and
screenshots-check.pykeeps only distinct images (L278), so it finds 1 of the 2 it needs and the Before / After screenshots check will fail. A dark render (the icon on a dark card) would also have shown the white square above.
4 non-blocking recommendations
- Check the export against the design node — the PR describes "a blue eye in a circle", but the PNG has a blue eye shape with a white ring and no enclosing circle. Together with the flattened background, this looks like a different layer or frame was exported. (not verified against Figma)
- The case name — Icon_DashUI.swift L237 — every other case is the camel-cased raw-value suffix;
case \public`is legal Swift and reads asDashIcon.SystemMessage.publicat call sites, so the keyword need not forcepublicVisibility`. (not compiled) - Catch opaque icons in CI —
conventions.shandDashIconTestsonly check that the asset loads; a rule flagging icon PNGs whose alpha is 255 everywhere would have caught this. - docs/foundation.md — L126 — the edited line runs to about 150 columns in a paragraph wrapped at about 85, and lists 2 of the 7 system-message icons before "…".
Review details
Trivial-tier asset PR: levels 1–3 inline; level 4 a general code review at high effort plus the UI checklist. The blocker was checked by decoding the PNGs' pixels (corner (255,255,255,255) here vs (0,0,0,0) in info-rect-small) and by drawing the 2x on black; the major against screenshots-check.py. CI was still running at review time.
🤖 Reviewed with Claude Code
…ic`, snapshot - The icon is the design's eye (Figma node 2156:895) as a vector SVG with a transparent background; the opaque PNGs, which carried the page's white background, are gone. Stored like dialogue-warning (preserves vector, original rendering). - The case is `public` (raw value system-message-public); conventions.sh now reads a case name in backticks, with a test. - SystemMessageView gets a Public icon preview and snapshot test. - docs/foundation.md names all seven system-message icons.
|
In cbb0157:
|
romchornyi-pitcrew
left a comment
There was a problem hiding this comment.
✅ Clean once CI renders the new references — the blocker and the major are closed · no blockers — re-reviewed at cbb0157e27
This replaces the verdict of the earlier "changes requested" review.
| Level | Verdict | |
|---|---|---|
| 1 · Idea | ✅ valid | unchanged |
| 2 · Architecture | ✅ right layer | unchanged |
| 3 · Completeness | ✅ complete | |
| 4 · Code | ✅ clean | A transparent vector asset, a snapshot in SystemMessageView, a tested conventions.sh change |
Closed since the last review
- Blocker: opaque PNGs → system-message-public.svg has no background shape; the ring's two subpaths wind in opposite directions, so the default non-zero fill leaves the ring see-through, as the design node draws it. Stored like
dialogue-warning(vector, original rendering). - Major: one image for both Before/After rows →
testPublicIconrenders the icon insideSystemMessageViewin light and dark, and the description will use those two references. - The glyph vs the design → confirmed against the node; the description was wrong, not the glyph, and it is corrected.
- Case name →
case \public`, withconventions.shreading names in backticks and two new cases inconventions-test.sh`. -
docs/foundation.md→ all seven system-message icons named, the paragraph re-wrapped. - The opaque-icon CI rule is left for a separate change, as the author said; it was a recommendation.
Before merging
The public-icon references are not in the branch yet and the description's images still point at eea52a444a (the same PNG twice), so Snapshot tests and Before / After screenshots will fail until the CI-rendered references are fetched with .github/scripts/fetch-snapshots.sh and linked in the description.
Review details
Re-review of eea52a444a..cbb0157e27 against the earlier findings and the author's replies. The SVG was read by hand (no background, winding of the ring), SystemMessageView draws the icon through Image(dash:) with no tint, and the conventions.sh regex change was checked against its new test cases. CI was still queued at review time.
🤖 Reviewed with Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@coderabbitai review |
Action performed
|
Issue being fixed or feature implemented
The design system has a "public" system-message icon (Design system - Hybrid,
system_message-public: a blue eye) shown next to a notice that an amount and a destination become public, but DashUIKit had no asset for it. Dash Wallet iOS needs it on the Send confirmation for a payment from the Shielded balance to Core (dashpay/dashwallet-ios#1358).What was done?
DashIcon.SystemMessage.`public`(system-message-public): a vector SVG exported from the design system, transparent around the eye, stored with "preserve vector data" and original rendering..github/scripts/conventions.shreads a backticked enum case (case `public` = "…"), so theDashIcon↔ imageset check covers it; a case for it inconventions-test.sh.SystemMessageView: a "Public icon" preview and atestPublicIconsnapshot test (light and dark).docs/foundation.mdlists the system-message icons.No existing view changes.
How Has This Been Tested?
.github/scripts/conventions.shand its test: OK.swift build,swift test: pass. The iOSDashIconTests(every case's image loads) run in CI.testPublicIcon.public-icon-light/-dark, rendered by CI and committed withfetch-snapshots.sh; no existing reference changes.Before / After
🤖 Generated with Claude Code
Summary by CodeRabbit