Skip to content

fix(install-engine): fail checkSurvivingPlaceholders on a zero-file scan #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbmml wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −4
Open

fix(install-engine): fail checkSurvivingPlaceholders on a zero-file scan #2060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a36a16
fix(install-engine): fail checkSurvivingPlaceholders on a zero-file scan
jbmml Sep 4, 2026
286870d
fix(install-engine): apply the same change to the sibling copy at Lif…
jbmml Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions LifeOS/Tools/InstallEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,14 +491,16 @@ const IDENTITY_PLACEHOLDERS = [
* or abort.
*/
export function checkSurvivingPlaceholders(rootDir: string): {
passed: boolean; files: Array<{ file: string; placeholder: string; count: number }>; total: number;
passed: boolean; files: Array<{ file: string; placeholder: string; count: number }>; total: number; scanned: number;
} {
const files: Array<{ file: string; placeholder: string; count: number }> = [];
let total = 0;
let scanned = 0;
const processFile = (filePath: string): void => {
if (!TEMPLATE_EXTENSIONS.has(fileExtension(filePath))) return;
let src: string;
try { src = readFileSync(filePath, "utf-8"); } catch { return; }
scanned++;
for (const placeholder of IDENTITY_PLACEHOLDERS) {
const count = src.split(placeholder).length - 1;
if (count > 0) { files.push({ file: filePath, placeholder, count }); total += count; }
Expand All @@ -515,7 +517,9 @@ export function checkSurvivingPlaceholders(rootDir: string): {
};
if (existsSync(rootDir) && lstatSync(rootDir).isFile()) processFile(rootDir);
else walk(rootDir);
return { passed: total === 0, files, total };
// A scan that reached zero template files cannot vouch for anything: a mis-rooted or
// nonexistent rootDir must FAIL the Setup 9(d) gate, not pass it.
return { passed: scanned > 0 && total === 0, files, total, scanned };
}

/**
Expand Down
8 changes: 6 additions & 2 deletions LifeOS/install/skills/LifeOS/Tools/InstallEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,14 +491,16 @@ const IDENTITY_PLACEHOLDERS = [
* or abort.
*/
export function checkSurvivingPlaceholders(rootDir: string): {
passed: boolean; files: Array<{ file: string; placeholder: string; count: number }>; total: number;
passed: boolean; files: Array<{ file: string; placeholder: string; count: number }>; total: number; scanned: number;
} {
const files: Array<{ file: string; placeholder: string; count: number }> = [];
let total = 0;
let scanned = 0;
const processFile = (filePath: string): void => {
if (!TEMPLATE_EXTENSIONS.has(fileExtension(filePath))) return;
let src: string;
try { src = readFileSync(filePath, "utf-8"); } catch { return; }
scanned++;
for (const placeholder of IDENTITY_PLACEHOLDERS) {
const count = src.split(placeholder).length - 1;
if (count > 0) { files.push({ file: filePath, placeholder, count }); total += count; }
Expand All @@ -515,7 +517,9 @@ export function checkSurvivingPlaceholders(rootDir: string): {
};
if (existsSync(rootDir) && lstatSync(rootDir).isFile()) processFile(rootDir);
else walk(rootDir);
return { passed: total === 0, files, total };
// A scan that reached zero template files cannot vouch for anything: a mis-rooted or
// nonexistent rootDir must FAIL the Setup 9(d) gate, not pass it.
return { passed: scanned > 0 && total === 0, files, total, scanned };
}

/**
Expand Down
Loading