fix(install-engine): fail checkSurvivingPlaceholders on a zero-file scan - #2060
Open
jbmml wants to merge 2 commits into
Open
fix(install-engine): fail checkSurvivingPlaceholders on a zero-file scan#2060jbmml wants to merge 2 commits into
jbmml wants to merge 2 commits into
Conversation
A nonexistent or mis-rooted rootDir walked zero template files and returned passed: true, so the Setup 9(d) identity-placeholder gate could not fail in exactly the case it exists to catch. Count the files actually read and require at least one before the check can pass. The result gains a scanned field for diagnostics; existing callers (Doctor.ts sums total only) are unaffected. Fixes danielmiessler#2058 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CvY8QkJKBWyXcZeL2Q2UXc
…eOS/Tools/ LifeOS/Tools/InstallEngine.ts and LifeOS/install/skills/LifeOS/Tools/InstallEngine.ts are byte-identical; Setup.md step 9(d) runs the outer one, Doctor.ts imports the deployed one. Both now fail a zero-file scan. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CvY8QkJKBWyXcZeL2Q2UXc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2058. Version: main @ 5e2f2e8 (also present in 7.40.4). File:
LifeOS/install/skills/LifeOS/Tools/InstallEngine.ts:518, and its byte-identical siblingLifeOS/Tools/InstallEngine.ts(Setup.md step 9(d) runs the outer copy;Doctor.tsimports the deployed one; both are patched here).Repro against a clean tree (script imports the shipped function and points it at four temp roots):
After this change:
Fix: count files actually read (
scanned) and requirescanned > 0 && total === 0. The return type gainsscannedfor diagnostics.Doctor.tssumstotaland never readspassed, so its behavior is unchanged. Setup 9(d) passes the full config root, which always holdsCLAUDE.mdandsettings.json(both template extensions), so a real install still passes.🤖 Generated with Claude Code
https://claude.ai/code/session_01CvY8QkJKBWyXcZeL2Q2UXc