Skip to content

Close post-merge dependency viewer findings - #244

Merged
d6g8k5htny-coder merged 3 commits into
mainfrom
codex/dependency-viewer-postmerge-review-20261003
Oct 3, 2026
Merged

d6g8k5htny-coder merged 3 commits into
mainfrom
codex/dependency-viewer-postmerge-review-20261003

Conversation

@d6g8k5htny-coder

Copy link
Copy Markdown
Owner

PR #243 landed the dependency viewer, then the standalone exact-head PR #242 review identified four additional reader-visible defects. This successor preserves component_role, restricts derived paths to required: true edges, renders validated source/review identities as exact links, and prevents native #node-detail focus from cancelling delayed fragment correction.

Regressions cover contextual-edge exclusion, unsafe-link refusal, metadata search/link provenance, and fragment focus. The hosted browser flow now checks the required path plus the exact pinned Math source and review links at desktop/mobile and light/dark viewports.

Local validation: 12 status-export tests, 96 Node tests, 15 reader-link tests, 14 museum tests, 27 museum geometry/data tests, 9 geometry tests, the public-shop checker, and 5 browser-contract tests pass. The local runtime lacks the pinned Playwright/Chrome environment, so the PR browser-smoke artifact remains the exact browser gate.

OpenAI Codex delegated UI integration. Scientific effect: NONE.

Preserve component-role provenance, limit paths to required dependencies, link validated exact sources, and retain native fragment focus during delayed rendering. Add model and hosted-browser regressions.

OpenAI Codex delegated UI integration. Scientific effect: NONE.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T16:21:49.033571Z 255110b Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

@codex review

Please review exact post-merge successor 935f8df75229b0edaab48e6c27a888db52478f80, tree 906e5265afe9f6f486bfba78acebb43969c48963. It addresses the four late exact-head PR242 findings without changing the pinned graph or scientific status. Focus on required-edge semantics, safe link resolution, native fragment focus, and complete browser regressions. Scientific effect: NONE.

The exact search has two legitimate matches; bind the hosted check to the exact node button instead of asserting a global result count.

Scientific effect: NONE.

Copy link
Copy Markdown
Owner Author

Hosted browser run 37135817149 exercised merge tree 906e5265afe9f6f486bfba78acebb43969c48963. All non-browser suites passed; browser QA failed only because the new search step asserted one global result while the exact query legitimately returns two nodes. Artifact 11278757553 was downloaded byte-exact (5,268,760 bytes, SHA-256 f64a7b99d065a70f372263fb1816201bdd1ede5762a78e7a86285e520e4379cc) and all four reader-tool cases report that same selector failure.

Successor d4d6c574afb9c4fd6a82d62b75272aa8265f6af6, tree 826b05ce4df06a72bfb3e82866b87f2cc78cb699, selects the exact math.lifetime-remainder button and keeps the product changes unchanged. Local browser-contract and syntax checks pass.

@codex review

Please review the exact successor head. Scientific effect: NONE.

Copy link
Copy Markdown
Owner Author

Hosted exact-successor evidence for head d4d6c574afb9c4fd6a82d62b75272aa8265f6af6, tree 826b05ce4df06a72bfb3e82866b87f2cc78cb699:

  • All four PR workflows completed successfully; public-shop run 37135957020 passed both jobs.
  • Browser artifact 11277773533: 7,246,835 bytes; downloaded SHA-256 1c16867d695ed9024480221e2ff026eb7cf5d706cd3212390672e9e1bcec931d, matching GitHub's digest.
  • report.json records Chrome 154.0.8037.57, Playwright 1.62.0, exact head/tree, and 13/13 passing cases with 45 screenshots.
  • Every desktop/mobile and light/dark reader-tool case verifies the required count-interface path, absence of the contextual CH-LIFT route, exact pinned Math source link, exact review-comment link, post-layout focus, invalid-ID refusal, and no document overflow.
  • The four dependency-viewer screenshots were inspected; source links remain visible and underlined, the required path is the only derived path, and no horizontal overflow is visible.

This is hosted PR-tree browser evidence, not deployed-Pages evidence, accessibility certification, or scientific acceptance. Exact-head Codex review remains pending.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4d6c574af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/public_shop_browser_check.py Outdated

Copy link
Copy Markdown
Owner Author

@codex review

Please review exact head 255110b6cca55042569b728b12d9a556c1af20db, including the explicit exact-identifier browser selector added in response to the prior review. Scope remains the six-file corrective viewer change; scientific effect NONE.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 255110b6cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

d6g8k5htny-coder commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner Author

Exact-head integration evidence for 255110b6cca55042569b728b12d9a556c1af20db, tree 2aba0411ece9852b1860eca916f54535da332cb7:

  • All four PR workflows succeeded; public-shop run 37136383762 passed both jobs.
  • Browser artifact 11278209568 is 7,246,993 bytes. Downloaded SHA-256 3817313425524d28650f67e0fd52ee3132a2ed6b9122f0cf6a1e1b0bdc626f3a, matching GitHub's digest.
  • Artifact report.json records Chrome 154.0.8037.57 and 13/13 passing cases; the reader-tool matrix covers desktop/mobile and light/dark and produced 45 screenshots overall.
  • The PR merge-test commit is e557b6cbabea19f221e7b90cad7afa4893e79cc9; its tree is exactly 2aba0411ece9852b1860eca916f54535da332cb7, matching the branch head tree.
  • Exact-head Codex review completed with no findings in comment 5971029475; the superseded inline thread is resolved.

This verifies the PR tree and browser behavior. It is not deployed-Pages evidence, accessibility certification, or scientific acceptance.

@d6g8k5htny-coder
d6g8k5htny-coder merged commit daf69ec into main Oct 3, 2026
8 checks passed
@d6g8k5htny-coder
d6g8k5htny-coder deleted the codex/dependency-viewer-postmerge-review-20261003 branch October 3, 2026 16:22

Copy link
Copy Markdown
Owner Author

Landed verification:

  • PR Close post-merge dependency viewer findings #244 merged as daf69ecb3631e37febda70b3002213ed50b5a223 at 2026-10-03T16:22:52Z.
  • main points to that exact commit.
  • Landed tree 2aba0411ece9852b1860eca916f54535da332cb7 exactly matches the reviewed/tested branch and PR merge-test tree.
  • Post-merge push run public-shop 37136636492 passed both public-shop and browser-smoke jobs.
  • Post-merge push run workspace-landing 37136636648 passed landing-checks, formal / formal-evidence, and the aggregate verify gate.

The late PR242 findings and the PR244 successor review finding are closed in the landed tree. Scientific effect: NONE; no proof, status, or mathematical acceptance changed.

Copy link
Copy Markdown
Owner Author

Visitor UX repair pickup — OpenAI / Codex, current Work Mode /root executor, delegated by Dylan Roy.

Base verified: daf69ecb3631e37febda70b3002213ed50b5a223 (tree 2aba0411ece9852b1860eca916f54535da332cb7). PR244 is completed; this is a separate bounded visitor audit repair, not another review of its unchanged result. Live open PR read shows only #228 and no competing site writer.

Claimed write scope until 2026-10-03T18:35:00Z: docs/site/app.js, museum.mjs, dependencies.mjs, cite.html, related existing frontend tests and tools/public_shop_browser_check.py / its contract test. Isolated successor branch; no proof, source manifest, status register or scientific change. Existing C114 historical receipt remains intact; this native pickup does not claim another chat's R17 lease.

Reproduced findings: (1) failed query fetch leaves query-note loading; (2) delayed museum source completion steals focus after user interaction; (3) dependency query math has 39 matches but shows only 30 without continuation. Minor route repair: Cite should use current Math PROOF_INDEX. Regression-first implementation and exact-head review/hosted checks before guarded integration.

Copy link
Copy Markdown
Owner Author

Visitor UX pickup 5971137771 scope refinement: also claim the existing .github/workflows/public-shop.yml Node test list so the new museum/workspace regressions run on every PR. No other workflow or owner branch is changed. Native lease remains through 18:35Z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant