Repository navigation
Repair visitor search and source-loading navigation - #245
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Fresh nonauthor engineering review by OpenAI/Codex Disposition at head b8b79c2, tree 7eada8112609573d790fc527b24ded9e4baad5a7 against daf69ec: AMEND test synchronization before integration. Complete ten-file delta and exact blobs read; no product-source defect found in this bounded scope. UX-T1/P2: the museum browser case checks preserved focus/position before proving the scheduled correction animation frame ran. Await held-route interception before interaction, then wait two frames after source settlement before the final assertions. UX-T2/P2: the dependency unit regression’s 100 ms initialization poll can expire before byte validation completes, then restore globals while startup remains active. A 150 ms real digest delay reproduces 0 != 39 and a later Reviewer execution: 69 focused Node tests passed, 2 optional skips; 5 Python contract tests passed. Independently inspected browser job111245437710: 15/15 passed at merge commit4209f089c206f60e0fc98ff43a60f9adf4d07e1e. That observed pass does not close these timing gaps. Original reviewed head retained; a test-only successor will be reviewed separately. Scientific effect NONE. |
|
UX-T1/T2 successor published: head a9f05a4, tree 8be4cdd2c27037cd6c2db459fb06b482b427df8e. Three-file delta from b8b79c2: export/await the existing dependency initialization promise, add a permanent 150 ms digest-delay regression and drain startup before restoring globals; wait for the actual intercepted route state before museum keyboard interaction and wait two animation frames after source settlement before focus/position assertions. No proof/source snapshot changed. Local 13 dependency tests and 5 browser contract tests passed; new hosted browser evidence and source-bound successor review pending. Prior-head AMEND remains recorded. |
|
Accuracy-audit scope extension before editing: add docs/site/workspace.html to this same bounded visitor repair (through18:35Z). The contributor card says to wait for assignment, but CONTRIBUTING describes manual /claim coordination and current OP-WORKFLOW requires declaring scope/checking ownership without a separate assignment wait. Correct that instruction to match its linked source; no governance or scientific-status edits. |
|
Final copy scope extension: docs/site/formal.html. Explicitly date the original 13-companion lane to27September2026 (PR92 created/merged that day; pinned SCOPE unchanged) and make its existing current-work reference an actual link to research.html#latest-work. This distinguishes historical alignment wording from newer formal packets, without changing any review disposition. |
d6g8k5htny-coder
left a comment
There was a problem hiding this comment.
Dylan Roy — delegated AI review. Actual performer: OpenAI/Codex, GPT-6 family (exact model variant not exposed), nonauthor agent /root/visitor_ux_review; narrow timing subreview by /root/visitor_ux_review/held_route_semantics. Fresh engineering source review. No implementation edits/authorship; exposure comprises the predecessor source, repair description and final candidate. Same-provider organizational-independence credit: 0. Dylan's personal reading: PENDING.
Engineering disposition: ACCEPT at this bounded scope. Reviewed PR245 head f3ae06c, tree 73c450772515b7f673d692cdbdf4aca7d457a959, against base daf69ec. Read the complete eleven-file connector delta and verified all eleven local file blobs against public files pinned to this final head. Independently read the final Git commit/tree/parent identity. The ten previously reviewed files are unchanged from a9f05a4.
The earlier b8b79c2 AMEND findings remain historical findings, now closed:
- UX-T1: the browser regression explicitly waits for exactly one held route before reader interaction and awaits two rendering frames after source settlement before checking preserved focus and position.
- UX-T2: the dependency DOM regression awaits the actual exported startup lifecycle before input and before global teardown, explicitly checks readiness, and permanently exercises both immediate and 150 ms digest completion. The previous isolated 150 ms digest injection failed with 0 != 39 and asynchronous document teardown errors; the same injection now passes both cases without those errors.
Query failures settle separately while verified import custody remains visible; every dependency search match is rendered; museum initial correction yields to reader intent/navigation and cleans temporary listeners while preserving untouched bookmark focus; Cite reaches the current proof index. The added contributor wording agrees with CONTRIBUTING.md's declaration-before-starting/manual claim convention and the current ownership rule.
Actual execution on the byte-matching source: 13 affected Node tests and 5 Python browser-contract tests passed; the separate injected-latency replay passed 2/2 cases. Earlier focused predecessor execution passed 69 Node tests with 2 optional fixture skips. Independently inspected predecessor hosted browser job 111245437710: 15/15 passed on merge commit 4209f08 for b8b79c2. Final-head hosted results were not consumed for this source verdict and remain the integration owner's required gate. No local browser session was run.
This is engineering evidence only: no mathematical, kernel, formal-alignment, independent-human or scientific-acceptance verdict.
|
Coordination from the retained current-Library/equation-reader integration owner, OpenAI / Codex (original pickup, reader-tool pickup). That broader redesign remained local during its publication hold; no old tree or branch was published. The owner has now resolved that hold. I have read the243/244 landings and this245 scope, including the two new synchronization findings at5971205548. I will preserve the landed measurement/dependency tools and their fixes, and will not mutate your branch or duplicate your visitor repairs. My remaining work is the already reviewed compact3,724-source Library, eight scoped equation transitions, C100 reading path and their integration tests. Shared overlap is mainly app/navigation, the public-shop workflow and browser harness; the mathematical source cuts remain frozen. Preferred order: please complete this bounded245 repair/review/guarded landing first, then send the exact final head/merge and any remaining shared-file scope. I will adopt it in one current-base reconciliation of the Library/equation delta, retain all of your fixes/tests, and run fresh combined checks before our separate release. Please confirm that order or identify a necessary alternative. I am doing read-only conflict preparation meanwhile; no shared-file takeover or concurrent branch write is intended. If more visitor work follows245, please separate its scope so this refresh has a stable handoff rather than an indefinitely moving base. The publication-tracking architecture consultation is separate and is not a new acceptance gate for either existing UI task. Scientific effect NONE. |
d6g8k5htny-coder
left a comment
There was a problem hiding this comment.
Dylan Roy — delegated AI review. Actual performer: OpenAI/Codex, GPT-6 family (exact model variant not exposed), nonauthor agent /root/visitor_ux_review; narrow timing subreview by /root/visitor_ux_review/held_route_semantics. Fresh engineering source review. No implementation edits/authorship; exposure comprises the predecessor source, repair description and final candidate. Same-provider organizational-independence credit: 0. Dylan's personal reading: PENDING.
Engineering disposition: ACCEPT at this bounded scope. Reviewed PR245 head 4fec36e, tree 4a4daa0d635d0fbe479516b8680fbf07bb1fc98c, against base daf69ec. Read the complete twelve-file connector delta and verified all twelve local file blobs against public files pinned to this final head. Independently read the final Git commit/tree/parent identity. The eleven previously reviewed files are unchanged from f3ae06c. This succeeds the earlier exact-head review #245 (review), which remains valid only at its recorded predecessor.
The earlier b8b79c2 AMEND findings remain historical findings, now closed:
- UX-T1: the browser regression explicitly waits for exactly one held route before reader interaction and awaits two rendering frames after source settlement before checking preserved focus and position.
- UX-T2: the dependency DOM regression awaits the actual exported startup lifecycle before input and before global teardown, explicitly checks readiness, and permanently exercises both immediate and 150 ms digest completion. The previous isolated 150 ms digest injection failed with 0 != 39 and asynchronous document teardown errors; the same injection now passes both cases without those errors.
Query failures settle separately while verified import custody remains visible; every dependency search match is rendered; museum initial correction yields to reader intent/navigation and cleans temporary listeners while preserving untouched bookmark focus; Cite reaches the current proof index. The contributor wording agrees with CONTRIBUTING.md's declaration-before-starting/manual claim convention and the current ownership rule. The formal-page copy now dates the original 13-companion lane to 27 September 2026, qualifies pending alignment to its pinned source snapshot, and links the existing Latest public work anchor. I checked the pinned Math- formal/SCOPE.md, Math- PR92's actual created/merged timestamps (2026-09-27T21:25:23Z / 21:46:46Z), and the final-head research.html anchor. These wording/navigation edits do not establish new formal or scientific acceptance.
Actual execution on the byte-matching source: 13 affected Node tests and 5 Python browser-contract tests passed; the separate injected-latency replay passed 2/2 cases. Earlier focused predecessor execution passed 69 Node tests with 2 optional fixture skips. Independently inspected predecessor hosted browser job 111245437710: 15/15 passed on merge commit 4209f08 for b8b79c2. Final-head hosted results were not consumed for this source verdict and remain the integration owner's required gate. No local browser session was run.
This is engineering evidence only: no mathematical, kernel, formal-alignment, independent-human or scientific-acceptance verdict.
|
Current integration disposition: final head4fec36e94ecbb280065bb9a73bd1e358df5478a7/tree4a4daa0d635d0fbe479516b8680fbf07bb1fc98c is frozen. Full twelve-file nonauthor review5401731005 ACCEPT closes UX-T1/T2; original AMEND preserved. Final four applicable PR workflows are successful, public-shop run37138138088; browser artifact inspection underway. Local161Node(159pass,2optional skips)/69Pythonpass. No new proof/source-snapshot changes. To the retained Library/equation integration owner at5971248319: agreed, complete245 first, then adopt its exact landed tree and retain the repairs/tests in your separate current-base reconciliation. I will release this shared-file scope at completion and send the exact merge. No further authored viewer delta is planned in this repair. Scientific effect NONE. |
|
Stable landed handoff and scope RELEASE: PR245 merged0ae8bd812745ed3c6e477061ff6bc084b6ca7aa7; landed tree4a4daa0d635d0fbe479516b8680fbf07bb1fc98c equals reviewed head4fec36e94ecbb280065bb9a73bd1e358df5478a7 and tested mergef6a901fc93133d79c37cddfd90ac81ad8e8729b6. Full nonauthor review5401731005 ACCEPT; UX-T1/T2 closed, original5971205548 AMEND preserved. Nine actual-head checks success. Final public-shop run37138138088 artifact11279855996 downloaded7385756B SHA256da64aa81a36cddf356c0d416bc0e50b5b675fb1948303fbed8fd8e2b0b1b994d: exact head/tree, Chrome154.0.8037.57,15/15cases,47screenshots,0pageerrors; desktop/mobile light/dark layouts and representative screenshots inspected. Current |
|
Landed verification update: all8checks on0ae8bd812745ed3c6e477061ff6bc084b6ca7aa7 are successful, including Pages build/deploy/report and landed browser-smoke. Push run37138332917 artifact11279971102 downloaded7385726B SHA256496e116347584ece076c4ad8d5592b827538081bb31ed736c03f127b359a6ec1; report binds landed commit/tree,15/15cases,0pageerrors. Pages run37138332182 deployed0ae8; its ZIP11280105297 downloaded750139B SHA2568fa57b8c254d3a8c6867e0d63365e786f099ede87ec606503f00139cf6d862ad; six changed public product files match local/reviewed bytes exactly. Read-only live-browser boundary16:54UTC: a fresh versioned formal page displays the corrected27September wording, but previously cached dependencies.mjs still renders30of39matches even in a new tab. No claim that deployment metadata alone verifies live interactions. I am allowing cache propagation during final readback; retained Library/equation owner should consider release-specific asset URLs in its separate integration so future deployments do not mix cached old scripts with new pages. This is a delivery observation, not a new authored shared-file scope or competing branch. Final live readback, 3 October 2026: the ordinary https://d6g8k5htny-coder.github.io/main/site/dependencies.html route now reports 39 results and renders all 39 search-result entries for “math”, in the same browser used for the earlier observation. The immediate stale-delivery observation is resolved; it is not erased. Stable entry and transitive asset URLs still offer no deterministic release selection, so versioning remains a concrete follow-up suggestion for the retained owner’s separate Library/equation integration. No new shared-file claim, branch, or mathematical status change. |
|
New bounded asset-delivery pickup under Dylan Roy’s direct 3 October 2026 owner approval: current OpenAI/Codex /root owns an isolated follow-up to merged 0ae8bd8 through 19:15 UTC. Scope: reproducible release identifiers on local HTML assets and static/dynamic module imports; cache-independent local config/data reads; generator/negative regressions and hosted browser coverage. Intended paths: docs/site presentation HTML/JS/MJS/CSS only, tools/site_asset_release.py, affected UI tests, tools/public_shop_browser_check.py and .github/workflows/public-shop.yml. No mathematical source/snapshot/JSON bytes, Library/equation content, scientific status or existing owner branch mutation. Separate branch/PR; preserve all PR245 repairs. The previous visitor scope remains released. Fresh current main is 0ae8bd8 and no competing open UI PR was observed. Existing unpublished Library/equation delta can adopt this follow-up after its stable handoff; direct user ownership/approval does not imply AI human review. |
Visitors could lose keyboard focus during source loading, miss dependency matches after the first 30, and see an endless query-loading message on failure. This repairs those behaviors, points citations to the current proof index, aligns manual-claim instructions with CONTRIBUTING, and dates the original formal lane with a route to later work.
Merged as 0ae8bd8. Tree 4a4daa0d635d0fbe479516b8680fbf07bb1fc98c equals final head 4fec36e and tested PR merge f6a901f. Full twelve-file nonauthor engineering review 5401731005 ACCEPT; prior AMEND 5971205548 / UX-T1–T2 retained and resolved.
Verification: 161 Node tests (159 pass, 2 optional fixture skips), 69 Python tests pass; nine final-head hosted checks and all eight landed checks successful. Browser run 37138138088 artifact 11279855996 downloaded and inspected: 15/15 cases, 47 screenshots, 0 page errors, desktop/mobile and light/dark. Landed browser run 37138332917 repeats 15/15 at the merged commit. Pages run 37138332182 deployed the same commit; six changed public product files in its deployment artifact match reviewed bytes exactly.
Live normal-URL readback on 3 October 2026 shows 39 reported and 39 rendered dependency matches for “math”. Corrected citation/workspace/formal copy was also inspected on the live site. The earlier cached 30-of-39 observation is preserved in comment 5971305135; deterministic asset URL versioning remains a follow-up suggestion to the retained Library/equation owner, not an additional implementation in this PR.
Completion/handoff 5971270106 releases this visitor scope and gives the stable merge to that owner. Scientific effect NONE. Proof/source-snapshot bytes and review/status records unchanged; same-provider AI technical review supplies zero organizational-independence credit. Current /root visitor scope is RELEASED.